Re: [PATCH] Staging: fbtft: Fix checkpatch warning

2017-03-27 Thread Greg KH
On Fri, Mar 24, 2017 at 03:02:45PM +0600, Anar Adilova wrote: > This patch fixes the checkpatch.pl warning: > > EXPORT_SYMBOL(foo); should immediately follow its function/variable. > > The EXPORT_SYMBOL statements are placed inside if blocks, after both function > implementations. > Please alwa

[PATCH] Staging: fbtft: Fix checkpatch warning

2017-03-24 Thread Anar Adilova
This patch fixes the checkpatch.pl warning: EXPORT_SYMBOL(foo); should immediately follow its function/variable. The EXPORT_SYMBOL statements are placed inside if blocks, after both function implementations. Signed-off-by: Anar Adilova --- drivers/staging/fbtft/fbtft-core.c | 6 -- 1 file

Re: [PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Greg KH
On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote: > Improve code readability. You are doing multiple things in the same patch, and you don't really tell us what you are doing, or why you are doing it... Please take a step back, relax, and wait a day before resending a patch series

[PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Carlos Palminha
Improve code readability. Signed-off-by: Carlos Palminha --- Changes v1->v2: - Added signed-off-by and comment. drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_devi

[PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Carlos Palminha
--- drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e9f25dd..0883715 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft