Re: [PATCH] staging: erofs: don't check special inode layout

2019-06-29 Thread Chao Yu
On 2019/6/28 12:19, Yue Hu wrote: > On Fri, 28 Jun 2019 11:50:21 +0800 > Gao Xiang wrote: > >> Hi Yue, >> >> On 2019/6/28 11:42, Yue Hu wrote: >>> From: Yue Hu >>> >>> Currently, we will check if inode layout is compression or inline if >>> the inode is special in fill_inode(). Also set ->i_mapp

Re: [PATCH] staging: erofs: don't check special inode layout

2019-06-27 Thread Yue Hu
On Fri, 28 Jun 2019 11:50:21 +0800 Gao Xiang wrote: > Hi Yue, > > On 2019/6/28 11:42, Yue Hu wrote: > > From: Yue Hu > > > > Currently, we will check if inode layout is compression or inline if > > the inode is special in fill_inode(). Also set ->i_mapping->a_ops for > > it. That is pointless

Re: [PATCH] staging: erofs: don't check special inode layout

2019-06-27 Thread Gao Xiang
Hi Yue, On 2019/6/28 11:42, Yue Hu wrote: > From: Yue Hu > > Currently, we will check if inode layout is compression or inline if > the inode is special in fill_inode(). Also set ->i_mapping->a_ops for > it. That is pointless since the both modes won't be set for special > inode when creating ER

[PATCH] staging: erofs: don't check special inode layout

2019-06-27 Thread Yue Hu
From: Yue Hu Currently, we will check if inode layout is compression or inline if the inode is special in fill_inode(). Also set ->i_mapping->a_ops for it. That is pointless since the both modes won't be set for special inode when creating EROFS filesystem image. So, let's avoid it. Signed-off-b