Re: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-24 Thread Matthijs Kooijman
Hey Paul, one more thing: > > > > + * -1 - GAHBCFG value will not be > > > > overridden This seems incorrect: If it is set to -1, GAHBCFG will be set to 0x06 (INCR4), it is not left unchanged. I'll also include this in my documentation patch. Gr. Matthijs ___

Re: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-24 Thread Matthijs Kooijman
Hey Paul, > > > diff --git a/drivers/staging/dwc2/core.h b/drivers/staging/dwc2/core.h > > > index fc075a7..e771e40 100644 > > > --- a/drivers/staging/dwc2/core.h > > > +++ b/drivers/staging/dwc2/core.h > > > @@ -150,10 +150,11 @@ enum dwc2_lx_state { > > > * are enabled > >

Re: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-18 Thread Stephen Warren
On 07/16/2013 01:22 PM, Paul Zimmerman wrote: > The dwc2 driver sets the value of the DWC2 GAHBCFG register to 0x6, > which is GAHBCFG_HBSTLEN_INCR4. But different platforms may require > different values. In particular, the Broadcom 2835 SOC used in the > Raspberry Pi needs a value of 0x10, otherw

RE: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-17 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Wednesday, July 17, 2013 4:15 AM > > On Tue, Jul 16, 2013 at 12:22:12PM -0700, Paul Zimmerman wrote: > > The dwc2 driver sets the value of the DWC2 GAHBCFG register to 0x6, > > which is GAHBCFG_HBSTLEN_INCR4. But different platforms may

Re: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-17 Thread Matthijs Kooijman
Hi Paul, On Tue, Jul 16, 2013 at 12:22:12PM -0700, Paul Zimmerman wrote: > The dwc2 driver sets the value of the DWC2 GAHBCFG register to 0x6, > which is GAHBCFG_HBSTLEN_INCR4. But different platforms may require > different values. In particular, the Broadcom 2835 SOC used in the > Raspberry Pi n

[PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-16 Thread Paul Zimmerman
The dwc2 driver sets the value of the DWC2 GAHBCFG register to 0x6, which is GAHBCFG_HBSTLEN_INCR4. But different platforms may require different values. In particular, the Broadcom 2835 SOC used in the Raspberry Pi needs a value of 0x10, otherwise the DWC2 controller stops working after a short pe