Re: [PATCH] staging: dgap: move cleanup function to avoid redundancy

2015-06-09 Thread Gujulan Elango, Hari Prasath (H.)
On Tue, Jun 09, 2015 at 04:51:02PM +0300, Dan Carpenter wrote: > No. See my other email. > > Also this is super ugly and your instinct should have told you that ugly > things are normally wrong. > > regards, > dan carpenter > Dan,I guess functionality wise this also does the job.Maybe this is

Re: [PATCH] staging: dgap: move cleanup function to avoid redundancy

2015-06-09 Thread Dan Carpenter
No. See my other email. Also this is super ugly and your instinct should have told you that ugly things are normally wrong. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/list

[PATCH] staging: dgap: move cleanup function to avoid redundancy

2015-06-09 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango The dgap_stop function need to be invoked only if pci_register_driver() fails.The same cleanup is done in pci_unregister_driver() function if pci_register_driver() succeeds.We can avoid same cleanup being done twice. Signed-off-by: Hari Prasath Gujulan Elango -