Re: [PATCH] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Mark Hounschell
On 02/26/2014 09:01 AM, Dan Carpenter wrote: On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote: -static void dgap_sysfs_create(struct board_t *brd) +static int dgap_tty_register_ports(struct board_t *brd) { struct channel_t *ch; - int j = 0; + int i; + +

Re: [PATCH] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote: > -static void dgap_sysfs_create(struct board_t *brd) > +static int dgap_tty_register_ports(struct board_t *brd) > { > struct channel_t *ch; > - int j = 0; > + int i; > + > + brd->SerialPorts = kcalloc(brd->nasync,

[PATCH] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Mark Hounschell
This patch addresses the follow error message followed by a kernel oops: dgap: driver does not set tty->port. This will crash the kernel later. Fix the driver It also renames the main function this patch addresses because its name is misleading. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Ha