On Tue, Jul 22, 2014 at 04:56:59PM -0400, Jeff Oczek wrote:
> On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote:
> > On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
> > > Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
> > > linux.c:
> >
> > I know you d
On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote:
> On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
> > Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
> > linux.c:
>
> I know you didn't name this variable, but wow, that's a horrid name for
> a global v
On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote:
> Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
> linux.c:
> drivers/staging/cxt1e1/linux.c:86:13: warning:
> symbol 'error_flag' was not declared. Should it be static?
> drivers/staging/cxt1e1/linux.c:91:13:
Put extern declarations in cxt1e1_common.h to reduce sparse warnings for
linux.c:
drivers/staging/cxt1e1/linux.c:86:13: warning:
symbol 'error_flag' was not declared. Should it be static?
drivers/staging/cxt1e1/linux.c:91:13: warning:
symbol 'cxt1e1_max_mru' was not declared. Should it be stat