Re: [PATCH] staging: comedi: remove duplicate pointer assignments in attach functions

2014-04-29 Thread Christian Engelmayer
On Mon, 28 Apr 2014 22:36:13 +, Hartley Sweeten wrote: > Technically, these drivers are fine as-is. They are. The proposed change falls under minor code maintenance only. > They are all legacy comedi drivers and use the manual attach mechanism. The > dev->board pointer is setup by the comed

RE: [PATCH] staging: comedi: remove duplicate pointer assignments in attach functions

2014-04-28 Thread Hartley Sweeten
On Saturday, April 26, 2014 7:04 AM, Christian Engelmayer wrote: > Some board pointer are assigned twice via comedi_board() in the comedi low > level driver attach functions. Remove the duplicate assignment from the > variable definition where the pointer is not used anyway until assigned later > i

Re: [PATCH] staging: comedi: remove duplicate pointer assignments in attach functions

2014-04-26 Thread Ian Abbott
On 26/04/14 15:04, Christian Engelmayer wrote: Some board pointer are assigned twice via comedi_board() in the comedi low level driver attach functions. Remove the duplicate assignment from the variable definition where the pointer is not used anyway until assigned later in the function when dev-

[PATCH] staging: comedi: remove duplicate pointer assignments in attach functions

2014-04-26 Thread Christian Engelmayer
Some board pointer are assigned twice via comedi_board() in the comedi low level driver attach functions. Remove the duplicate assignment from the variable definition where the pointer is not used anyway until assigned later in the function when dev->board_ptr, that comedi_board() relies on, is set