Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Al Viro
On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote: [mA vs. MA] Table 5. SI prefixes Factor NameSymbol 10^6megaM 10^-3 milli m Confusing one for another (especially for electrical units) can be... spectacular. FYI, 1mA is more or less what you get if you li

Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Greg KH
On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote: > Capitalize RANGE_mA to fix camelcase check warning. > Issue reported by checkpatch.pl > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedidev.h | 2 +- > drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++

Re: [Outreachy kernel] [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Greg KH
On Sun, Oct 06, 2019 at 09:01:09PM +0200, Julia Lawall wrote: > > > On Sun, 6 Oct 2019, Jules Irenge wrote: > > > Capitalize RANGE_mA to fix camelcase check warning. > > Issue reported by checkpatch.pl > > I guess mA means something, so it would be better to keep it? Yes it does, we need to ke

Re: [Outreachy kernel] [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Julia Lawall
On Sun, 6 Oct 2019, Jules Irenge wrote: > Capitalize RANGE_mA to fix camelcase check warning. > Issue reported by checkpatch.pl I guess mA means something, so it would be better to keep it? julia > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedidev.h | 2 +- >

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Jules Irenge
Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging/com

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Jules Irenge
Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging/com

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

2019-10-06 Thread Jules Irenge
Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging/com