Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-26 Thread Stephen Brennan
Apologies for the noise, this was the wrong patch. Please ignore this. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-26 Thread Stephen Brennan
Simply break down some long lines and tab-indent them. Signed-off-by: Stephen Brennan --- I'm learning the patch submission process, and this is my first patch. I know it's trivial but I'm just trying to get my feet wet. Thanks in advance for taking the time to review this! drivers/staging/ccre

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-25 Thread Tobin C. Harding
On Tue, Oct 24, 2017 at 11:52:58PM -0700, Stephen Brennan wrote: > Hi Gilad & Tobin, > > > > Perhaps, if Stephen is willing, re-write the code to be more readable > > > by, for example, using a temp > > > variable for the register address, and in doing so both making the > > > code more readable a

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Stephen Brennan
Hi Gilad & Tobin, > > Perhaps, if Stephen is willing, re-write the code to be more readable > > by, for example, using a temp > > variable for the register address, and in doing so both making the > > code more readable as well as > > treating the symptom? I'm definitely willing; however, I don't

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Greg Kroah-Hartman
On Tue, Oct 24, 2017 at 08:44:31PM +1100, Tobin C. Harding wrote: > Removing from CC list: > > - de...@driverdev.osuosl.org (this is the old address, it forwards to > driverdev-devel@linuxdriverproject.org now I believe). Both work equally well, and are interchangable for odd historical reason

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Tobin C. Harding
Removing from CC list: - de...@driverdev.osuosl.org (this is the old address, it forwards to driverdev-devel@linuxdriverproject.org now I believe). - Linux Crypto Mailing List , should we be spamming these guys with checkpatch fixing discussions? Please do correct me if this is not the cor

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-24 Thread Gilad Ben-Yossef
Hi Tobin, On Tue, Oct 24, 2017 at 6:02 AM, Tobin C. Harding wrote: > On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote: >> Simply break down some long lines and tab-indent them. > > Hi Stephen, > > Welcome to the Linux kernel. Great that you have put in a patch, you are, > however,

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-23 Thread Tobin C. Harding
On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote: > Simply break down some long lines and tab-indent them. Hi Stephen, Welcome to the Linux kernel. Great that you have put in a patch, you are, however, unlikely to see success fixing 'line over 80' warnings. There are a bunch of ar

[PATCH] staging: ccree: Fix lines longer than 80 characters

2017-10-23 Thread Stephen Brennan
Simply break down some long lines and tab-indent them. Signed-off-by: Stephen Brennan --- I'm learning the patch submission process, and this is my first patch. I know it's trivial but I'm just trying to get my feet wet. Thanks in advance for taking the time to review this! drivers/staging/ccre