Re: [PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

On Sun, Jun 08, 2014 at 11:45:28PM +0200, Rickard Strandqvist wrote: > Array 'SigBuff' is filled incompletely. > Someone forget to multiply for the sizeof type. > > This was partly found using a static code analysis program called cppcheck. > I took a look at code which uses MAX_RW_SIZE and it's

[PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

Array 'SigBuff' is filled incompletely. Someone forget to multiply for the sizeof type. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/bcm/nvm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

Hi I think someone missed the count sizeof type in memcpy. I'm no expert on this code. But I wonder if also the the next for loop wrong? It will fill with 0XFF00 but it is not a complete 0X you're looking for? So something like: memset(&Buff[sigOffset], 0xFF, MAX_RW_S