Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]

2021-08-23 Thread Dan Carpenter
Google for how to format a v2 patch. On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote: > By doing some last-second wording changes directly in the diff I've > screwed up and managed to use spaces instead of tabs for the Kconfig file. > This is embarrassing! > I love adding backstory to

Re: [PATCH] staging/ks7010: Fix coding style problems

2021-08-18 Thread Frans Klaver
On Mon, Aug 16, 2021 at 8:06 PM Leon Krieg wrote: > > Sorry to bother you with this low-effort patch but I'd really like to get > my feet in the water and this whole process is making me nervous. I'd > really appreciate you taking the time to look over this diff and > hopefully I did not screw up

Re: [PATCH] staging/ks7010: Fix coding style problems

2021-08-16 Thread kernel test robot
Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/stag

Re: [PATCH] staging/ks7010: Fix coding style problems

2021-08-16 Thread kernel test robot
Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/stag

Re: [PATCH] staging/ks7010: Fix coding style problems

2021-08-16 Thread kernel test robot
Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems/20210817-020753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/stag

Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]

2021-08-16 Thread kernel test robot
Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702 base: https://git.kernel.org/pub/scm/linux/kernel/git/g

Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]

2021-08-16 Thread kernel test robot
Hi Leon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702 base: https://git.kernel.org/pub/scm/linux/kernel/git/g

Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]

2021-08-16 Thread Greg KH
On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote: > By doing some last-second wording changes directly in the diff I've > screwed up and managed to use spaces instead of tabs for the Kconfig file. > This is embarrassing! > > Signed-off-by: Leon Krieg > --- > drivers/staging/ks7010/Kcon

Re: [PATCH] staging/ks7010: Fix coding style problems

2021-08-16 Thread Greg KH
On Mon, Aug 16, 2021 at 07:55:03PM +0200, Leon Krieg wrote: > Sorry to bother you with this low-effort patch but I'd really like to get > my feet in the water and this whole process is making me nervous. I'd > really appreciate you taking the time to look over this diff and > hopefully I did not sc

[PATCH] staging/ks7010: Fix coding style problems [Version 2]

2021-08-16 Thread Leon Krieg
By doing some last-second wording changes directly in the diff I've screwed up and managed to use spaces instead of tabs for the Kconfig file. This is embarrassing! Signed-off-by: Leon Krieg --- drivers/staging/ks7010/Kconfig | 7 --- drivers/staging/ks7010/ks_hostif.c | 2 +- driv

[PATCH] staging/ks7010: Fix coding style problems

2021-08-16 Thread Leon Krieg
Sorry to bother you with this low-effort patch but I'd really like to get my feet in the water and this whole process is making me nervous. I'd really appreciate you taking the time to look over this diff and hopefully I did not screw up to badly. Signed-off-by: Leon Krieg --- drivers/staging/ks