Re: [PATCH] rts5208: fix a missing check of ms read

2019-01-02 Thread Dan Carpenter
On Thu, Dec 20, 2018 at 02:00:01PM -0600, Kangjie Lu wrote: > When ms_read_extra_data fails, the data read in "extra" buffer is > just incorrect and thus should be used. However, "extra" is used > in multiple places no matter ms_read_extra_data() fails or not. > The fix checks the status of ms_read

Re: [PATCH] rts5208: fix a missing check of ms read

2018-12-20 Thread Dan Carpenter
LGTM. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] rts5208: fix a missing check of ms read

2018-12-20 Thread Kangjie Lu
When ms_read_extra_data fails, the data read in "extra" buffer is just incorrect and thus should be used. However, "extra" is used in multiple places no matter ms_read_extra_data() fails or not. The fix checks the status of ms_read_extra_data() and returns with an error code upon its failure. Sign