Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-06 Thread Stephen Hemminger
s ; > > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > > p...@vger.kernel.org > > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > > buffer > > > > On Tue, 8 Nov 2016 14:04:38 -0800 > > Long Li wro

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Long Li
gt; p...@vger.kernel.org > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > buffer > > On Tue, 8 Nov 2016 14:04:38 -0800 > Long Li wrote: > > > + spin_lock_irqsave(&hbus->retarget_msi_interrupt_lock, flags); > > + > > + para

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Long Li
> -Original Message- > From: KY Srinivasan > Sent: Monday, December 5, 2016 1:23 PM > To: Cathy Avery ; Bjorn Helgaas > ; Long Li > Cc: de...@linuxdriverproject.org > Subject: RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > buffer > >

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Cathy Avery > Sent: Monday, December 5, 2016 4:54 AM > To: Bjorn Helgaas ; Long Li > Cc: de...@linuxdriverproject.org > Subject: Re: [PATCH] pci-hyperv: us

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Stephen Hemminger
On Tue, 8 Nov 2016 14:04:38 -0800 Long Li wrote: > + spin_lock_irqsave(&hbus->retarget_msi_interrupt_lock, flags); > + > + params = &hbus->retarget_msi_interrupt_params; > + memset(params, 0, sizeof(*params)); > + params->partition_id = HV_PARTITION_ID_SELF; > + params->sourc

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Cathy Avery
Hi, Is the double semicolon a typo? Thanks, Cathy diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 763ff87..ca553df 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -378,6 +378,8 @@ struct hv_pcibus_device { struct msi_do

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-29 Thread Bjorn Helgaas
On Tue, Nov 08, 2016 at 02:04:38PM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically > continuous buffer. Buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Change to use kmalloc to allocate this buffer. > > T

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-23 Thread KY Srinivasan
vger.kernel.org; Long Li > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > buffer > > On Tue, Nov 08, 2016 at 02:04:38PM -0800, Long Li wrote: > > From: Long Li > > > > hv_do_hypercall assumes that we pass a segment from a physically > &

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-23 Thread Bjorn Helgaas
On Tue, Nov 08, 2016 at 02:04:38PM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically > continuous buffer. Buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Change to use kmalloc to allocate this buffer. > > T

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread Long Li
Bjorn Helgaas ; > de...@linuxdriverproject.org > Subject: RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall > params buffer > > This sender failed our fraud detection checks and may not be who they > appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing >

[PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread Long Li
From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Change to use kmalloc to allocate this buffer. The v2 patch adds locking to access the pre-allocated buffer. Signed-off-by

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread KY Srinivasan
Haiyang Zhang > > ; Bjorn Helgaas ; > > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > > p...@vger.kernel.org > > Subject: Re: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall > > params buffer > > > > On Tue, Nov 08, 2

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread Long Li
ger.kernel.org > Subject: Re: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall > params buffer > > On Tue, Nov 08, 2016 at 12:14:14AM -0800, Long Li wrote: > > From: Long Li > > > > hv_do_hypercall assumes that we pass a segment from a physically >

Re: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-07 Thread Greg KH
On Tue, Nov 08, 2016 at 12:14:14AM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically continuous > buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is > set. Use kmalloc to allocate this buffer. Please wrap your c

[Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-07 Thread Long Li
From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Use kmalloc to allocate this buffer. Signed-off-by: Long Li Reported-by: Haiyang Zhang --- drivers/pci/host/pci-hyperv.