Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Maxime Rossi Bellom
On Fri, Jan 27, 2017 at 05:43:47PM +0300, Dan Carpenter wrote: > Heh. I would just leave this one alone for now. > > Everyone hates all the potential changes more than we hate going over > 80 characters. > > regards, > dan carpenter > Understood. Thanks Maxime _

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Dan Carpenter
Heh. I would just leave this one alone for now. Everyone hates all the potential changes more than we hate going over 80 characters. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mai

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Maxime Rossi Bellom
On Fri, Jan 27, 2017 at 05:13:01PM +0300, Dan Carpenter wrote: > I guess I'm not a fan of really long prefixes... I've complained before > to other people so don't feel special. Prefixes are something that > people add without thinking as if they always make the code better and > I do blame JAVA

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Dan Carpenter
I guess I'm not a fan of really long prefixes... I've complained before to other people so don't feel special. Prefixes are something that people add without thinking as if they always make the code better and I do blame JAVA influence for this... The "_interface" really doesn't add anything bec

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Johan Hovold
On Fri, Jan 27, 2017 at 04:24:47PM +0300, Dan Carpenter wrote: > On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote: > > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > > > The name sucks is what I'm saying. Please fix it eventually. > > > > I disagree. The name uses a

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Dan Carpenter
On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote: > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > > The name sucks is what I'm saying. Please fix it eventually. > > I disagree. The name uses a common prefix that reflects the object it is > working on. This should no

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Johan Hovold
On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote: > The name sucks is what I'm saying. Please fix it eventually. I disagree. The name uses a common prefix that reflects the object it is working on. This should not be changed. As it is currently named, the function is also self-docume

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Dan Carpenter
The name sucks is what I'm saying. Please fix it eventually. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Johan Hovold
On Fri, Jan 27, 2017 at 03:29:30PM +0300, Dan Carpenter wrote: > On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > > From: Maxime Rossi Bellom > > > > Split line before funtion argument. > > > > Error was reported by checkpatch.pl as > > WARNING: line over 80 characters >

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Dan Carpenter
On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > From: Maxime Rossi Bellom > > Split line before funtion argument. > > Error was reported by checkpatch.pl as > WARNING: line over 80 characters > > Signed-off-by: Maxime Rossi Bellom > --- > drivers/staging/greybus/fw-m

Re: [PATCH] greybus: Fix coding stye error

2017-01-27 Thread Greg KH
On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote: > From: Maxime Rossi Bellom > > Split line before funtion argument. > > Error was reported by checkpatch.pl as > WARNING: line over 80 characters > > Signed-off-by: Maxime Rossi Bellom > --- > drivers/staging/greybus/fw-m

[PATCH] greybus: Fix coding stye error

2017-01-27 Thread mrossibellom
From: Maxime Rossi Bellom Split line before funtion argument. Error was reported by checkpatch.pl as WARNING: line over 80 characters Signed-off-by: Maxime Rossi Bellom --- drivers/staging/greybus/fw-management.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/st