Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Kees Cook
On Thu, Apr 6, 2017 at 1:48 AM, Jani Nikula wrote: > On Thu, 06 Apr 2017, Kees Cook wrote: >> While examining output from trial builds with -Wformat-security enabled, >> many strings were found that should be defined as "const", or as a char >> array instead of char pointer. This makes some stati

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Jani Nikula
On Thu, 06 Apr 2017, Kees Cook wrote: > While examining output from trial builds with -Wformat-security enabled, > many strings were found that should be defined as "const", or as a char > array instead of char pointer. This makes some static analysis easier, > by producing fewer false positives.

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 02:47:11PM -0700, Kees Cook wrote: > While examining output from trial builds with -Wformat-security enabled, > many strings were found that should be defined as "const", or as a char > array instead of char pointer. This makes some static analysis easier, > by producing few

[PATCH] format-security: move static strings to const

2017-04-05 Thread Kees Cook
While examining output from trial builds with -Wformat-security enabled, many strings were found that should be defined as "const", or as a char array instead of char pointer. This makes some static analysis easier, by producing fewer false positives. As these are all trivial changes, it seemed be