Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

2014-06-02 Thread Dan Carpenter
On Mon, Jun 02, 2014 at 07:05:01PM +0200, Federico Di Pierro wrote: > - else { > + } else { > ret = -EINVAL; > break; > } > > > Signed-off-by: Federico Di Pierro This goes after the changelog and before the diff.

Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

2014-06-02 Thread Jonathan Cameron
On 02/06/14 18:05, Federico Di Pierro wrote: Hi! This is my latest task of the eudyptula challenge. Just a very small patch! It fixes 3 little coding style problems. I'm using linux-next. Fair enough, but you need to spend a little time working on the 'how' of your patch submission. See Document

Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

2014-06-02 Thread Joe Perches
On Mon, 2014-06-02 at 19:05 +0200, Federico Di Pierro wrote: > Hi! Hello Federico. > This is my latest task of the eudyptula challenge. Your patch subject should be something like: [PATCH] staging: iio: kernel style neatening > Just a very small patch! It fixes 3 little coding style problems.

Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

2014-06-02 Thread Jianyu Zhan
On Tue, Jun 3, 2014 at 1:05 AM, Federico Di Pierro wrote: > Hi! > This is my latest task of the eudyptula challenge. > Just a very small patch! It fixes 3 little coding style problems. > I'm using linux-next. Hi, Federico, It's awesome you taking part in eudyptula challenge program. That is a go

[PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c

2014-06-02 Thread Federico Di Pierro
Hi! This is my latest task of the eudyptula challenge. Just a very small patch! It fixes 3 little coding style problems. I'm using linux-next. --- linux/drivers/staging/iio/frequency/ad9832.c.orig 2014-06-02 17:26:12.929978122 +0200 +++ linux/drivers/staging/iio/frequency/ad9832.c2014-0