Re: [PATCH] comedi: me_daq: Fix coding style - use BIT macro

2015-11-09 Thread Dan Carpenter
On Mon, Nov 09, 2015 at 10:43:56PM +0530, Ranjith wrote: > +#define ADC_GAIN_2 (BIT(5) & (~BIT(4))) It looks really weird to write it this way... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driver

RE: [PATCH] comedi: me_daq: Fix coding style - use BIT macro

2015-11-09 Thread Hartley Sweeten
On Monday, November 09, 2015 10:14 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith This has already been fixed. Please base your patches on linux-next or Greg Kroah-Hartman's staging-next tree. Also,

[PATCH] comedi: me_daq: Fix coding style - use BIT macro

2015-11-09 Thread Ranjith
BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith --- drivers/staging/comedi/drivers/me_daq.c | 134 +++ 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/drivers/staging/comedi/drivers/