Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Todd Kjos
On Wed, Oct 9, 2019 at 3:40 AM Christian Brauner wrote: > > On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote: > > On Tue, Oct 08, 2019 at 03:01:59PM +0200, Christian Brauner wrote: [...] > > > > One more thought, this can be made dependent on CONFIG_BINDERFS since > > regular > >

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Joel Fernandes
On Wed, Oct 09, 2019 at 05:10:45PM +0200, Christian Brauner wrote: > On Wed, Oct 09, 2019 at 10:55:58AM -0400, Joel Fernandes wrote: > > On Wed, Oct 09, 2019 at 04:29:11PM +0200, Christian Brauner wrote: > > > On Wed, Oct 09, 2019 at 10:21:29AM -0400, Joel Fernandes wrote: > > > > On Wed, Oct 09, 2

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Christian Brauner
On Wed, Oct 09, 2019 at 10:55:58AM -0400, Joel Fernandes wrote: > On Wed, Oct 09, 2019 at 04:29:11PM +0200, Christian Brauner wrote: > > On Wed, Oct 09, 2019 at 10:21:29AM -0400, Joel Fernandes wrote: > > > On Wed, Oct 09, 2019 at 12:40:12PM +0200, Christian Brauner wrote: > > > > On Tue, Oct 08, 2

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Joel Fernandes
On Wed, Oct 09, 2019 at 04:29:11PM +0200, Christian Brauner wrote: > On Wed, Oct 09, 2019 at 10:21:29AM -0400, Joel Fernandes wrote: > > On Wed, Oct 09, 2019 at 12:40:12PM +0200, Christian Brauner wrote: > > > On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote: > > > > On Tue, Oct 08, 2

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Christian Brauner
On Wed, Oct 09, 2019 at 10:21:29AM -0400, Joel Fernandes wrote: > On Wed, Oct 09, 2019 at 12:40:12PM +0200, Christian Brauner wrote: > > On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote: > > > On Tue, Oct 08, 2019 at 03:01:59PM +0200, Christian Brauner wrote: > > > > When a binder tra

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Joel Fernandes
On Wed, Oct 09, 2019 at 12:40:12PM +0200, Christian Brauner wrote: > On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote: > > On Tue, Oct 08, 2019 at 03:01:59PM +0200, Christian Brauner wrote: > > > When a binder transaction is initiated on a binder device coming from a > > > binderfs in

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-09 Thread Christian Brauner
On Tue, Oct 08, 2019 at 02:05:16PM -0400, Joel Fernandes wrote: > On Tue, Oct 08, 2019 at 03:01:59PM +0200, Christian Brauner wrote: > > When a binder transaction is initiated on a binder device coming from a > > binderfs instance, a pointer to the name of the binder device is stashed > > in the bi

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-08 Thread Joel Fernandes
On Tue, Oct 08, 2019 at 03:01:59PM +0200, Christian Brauner wrote: > When a binder transaction is initiated on a binder device coming from a > binderfs instance, a pointer to the name of the binder device is stashed > in the binder_transaction_log_entry's context_name member. Later on it > is used

[PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-08 Thread Christian Brauner
When a binder transaction is initiated on a binder device coming from a binderfs instance, a pointer to the name of the binder device is stashed in the binder_transaction_log_entry's context_name member. Later on it is used to print the name in print_binder_transaction_log_entry(). By the time prin