Re: [PATCH] binder: fix null deref of proc->context

2020-06-23 Thread Dan Carpenter
On Tue, Jun 23, 2020 at 11:04:04AM +0200, Christian Brauner wrote: > On Tue, Jun 23, 2020 at 11:50:21AM +0300, Dan Carpenter wrote: > > On Mon, Jun 22, 2020 at 01:07:15PM -0700, Todd Kjos wrote: > > > The binder driver makes the assumption proc->context pointer is invariant > > > after > > > initi

Re: [PATCH] binder: fix null deref of proc->context

2020-06-23 Thread Christian Brauner
On Tue, Jun 23, 2020 at 11:50:21AM +0300, Dan Carpenter wrote: > On Mon, Jun 22, 2020 at 01:07:15PM -0700, Todd Kjos wrote: > > The binder driver makes the assumption proc->context pointer is invariant > > after > > initialization (as documented in the kerneldoc header for struct proc). > > Howeve

Re: [PATCH] binder: fix null deref of proc->context

2020-06-23 Thread Dan Carpenter
On Mon, Jun 22, 2020 at 01:07:15PM -0700, Todd Kjos wrote: > The binder driver makes the assumption proc->context pointer is invariant > after > initialization (as documented in the kerneldoc header for struct proc). > However, in commit f0fe2c0f050d ("binder: prevent UAF for binderfs devices > I

Re: [PATCH] binder: fix null deref of proc->context

2020-06-22 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2020 at 01:59:04PM -0700, Todd Kjos wrote: > On Mon, Jun 22, 2020 at 1:18 PM Todd Kjos wrote: > > > > On Mon, Jun 22, 2020 at 1:09 PM Christian Brauner > > wrote: > > > > > > On Mon, Jun 22, 2020 at 01:07:15PM -0700, Todd Kjos wrote: > > > > The binder driver makes the assumption

Re: [PATCH] binder: fix null deref of proc->context

2020-06-22 Thread Christian Brauner
On Mon, Jun 22, 2020 at 01:07:15PM -0700, Todd Kjos wrote: > The binder driver makes the assumption proc->context pointer is invariant > after > initialization (as documented in the kerneldoc header for struct proc). > However, in commit f0fe2c0f050d ("binder: prevent UAF for binderfs devices > I