Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Sohny Thomas
On Wednesday 01 July 2015 02:45 PM, Sudip Mukherjee wrote: > On Wed, Jul 01, 2015 at 02:04:48PM +0530, Sohny Thomas wrote: >> On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote: >>> On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote: >> > >> This is from linux-stable branch and

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Julia Lawall
On Wed, 1 Jul 2015, Sohny Thomas wrote: > i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE, > &scsi.wwnn, NULL); > -if (i) { > +if (i) > return 1; > -} > -retu

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Sohny Thomas
i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE, &scsi.wwnn, NULL); - if (i) { + if (i) return 1; - } - return 0; + else + return 0; >>> No, now this will introduce a new checkpatch warni

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Sudip Mukherjee
On Wed, Jul 01, 2015 at 02:04:48PM +0530, Sohny Thomas wrote: > On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote: > > On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote: > > This is from linux-stable branch and I updated it just yesterday, so looks > like the folders still th

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Sohny Thomas
On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote: > On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote: > >>> No, now this will introduce a new checkpatch warning that "else is not >>> required after return". why did you introduce this "else"? >> I did this so that the code is

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Sudip Mukherjee
On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote: > >No, now this will introduce a new checkpatch warning that "else is not > >required after return". why did you introduce this "else"? > I did this so that the code is more readable and understandable, I > checked and checkpatch didn't

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Julia Lawall
On Wed, 1 Jul 2015, Sohny Thomas wrote: > Thanks for review, my answers inline > > On 01-07-2015 12:27, Sudip Mukherjee wrote: > > On Wed, Jul 01, 2015 at 03:05:45AM +0530, Sohny Thomas wrote: > > > > > > FIX 2 unnecessary braces found by checkpatch.pl > > > > > > Signed-off-by: Sohny Thomas >

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-07-01 Thread Sohny Thomas
Thanks for review, my answers inline On 01-07-2015 12:27, Sudip Mukherjee wrote: On Wed, Jul 01, 2015 at 03:05:45AM +0530, Sohny Thomas wrote: FIX 2 unnecessary braces found by checkpatch.pl Signed-off-by: Sohny Thomas --- drivers/staging/unisys/virtpci/virtpci.c | 11 ++- 1 file

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-06-30 Thread Sudip Mukherjee
On Wed, Jul 01, 2015 at 03:05:45AM +0530, Sohny Thomas wrote: > > FIX 2 unnecessary braces found by checkpatch.pl > > Signed-off-by: Sohny Thomas > --- > drivers/staging/unisys/virtpci/virtpci.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/stagin

[PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

2015-06-30 Thread Sohny Thomas
FIX 2 unnecessary braces found by checkpatch.pl Signed-off-by: Sohny Thomas --- drivers/staging/unisys/virtpci/virtpci.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c index d5a