Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-18 Thread Greg KH
On Wed, Oct 04, 2017 at 07:21:10PM +0200, Srinivasan Shanmugam wrote: > Removed all the unnecessary extern from rtl8723bs That's not what this patch does :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 13:28 +0200, Srinivasan Shanmugam wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Subject and commit message don't match > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c > b/drivers/staging/rtl8723bs/core/rtw_recv.c [] > @@ -1227,7 +

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-05 Thread Srinivasan Shanmugam
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Srinivasan Shanmugam --- drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/cor

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Joe Perches
On Wed, 2017-10-04 at 19:24 +0200, Srinivasan Shanmugam wrote: > Removed warning from > 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after > running checkpatch.pl > > Signed-off-by: Srinivasan Shanmugam > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++- > 1 file

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Srinivasan Shanmugam
Removed warning from 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after running checkpatch.pl Signed-off-by: Srinivasan Shanmugam --- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723b

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Srinivasan Shanmugam
Removed all the unnecessary extern from rtl8723bs Signed-off-by: Srinivasan Shanmugam --- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index c

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Srinivasan Shanmugam
This patch fixes all the following checkpatch.pl warning in rtl8723bs WARNING: externs should be avoided in .c files Signed-off-by: Srinivasan Shanmugam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Joe Perches
On Wed, 2017-10-04 at 13:53 +0200, srinivasan wrote: > Hi Joe, > > Thanks for your responses. I have already compiled and the below is the > logs for the same > > Please let me know if am I missing/doing wrong Your commit message is incomplete. checkpatch is a guide, but it's not what you shoul

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Joe Perches
On Wed, 2017-10-04 at 11:00 +0200, Srinivasan Shanmugam wrote: > This patch fixes the following checkpatch.pl warning. > WARNING: externs should be avoided in .c files Nope. > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c > b/drivers/staging/rtl8723bs/core/rtw_ap.c [] > @@ -17,12 +17,6 @@

[PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

2017-10-04 Thread Srinivasan Shanmugam
This patch fixes the following checkpatch.pl warning. WARNING: externs should be avoided in .c files Signed-off-by: Srinivasan Shanmugam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging