Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > On 09/08/2017 11:59 AM, Julia Lawall wrote: > > > > > > On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > > > >> On 09/08/2017 11:32 AM, Jonathan Cameron wrote: > >>> On Fri, 8 Sep 2017 07:29:06 +0100 > >>> Jonathan Cameron wrote: > >>> > On 8

Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Lars-Peter Clausen
On 09/08/2017 11:59 AM, Julia Lawall wrote: > > > On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > >> On 09/08/2017 11:32 AM, Jonathan Cameron wrote: >>> On Fri, 8 Sep 2017 07:29:06 +0100 >>> Jonathan Cameron wrote: >>> On 8 September 2017 05:47:52 BST, Himanshi Jain wrote: > Add

Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Julia Lawall
On Fri, 8 Sep 2017, Lars-Peter Clausen wrote: > On 09/08/2017 11:32 AM, Jonathan Cameron wrote: > > On Fri, 8 Sep 2017 07:29:06 +0100 > > Jonathan Cameron wrote: > > > >> On 8 September 2017 05:47:52 BST, Himanshi Jain > >> wrote: > >>> Added space around(one on each side of) binary > >>> ope

Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Jonathan Cameron
On Fri, 8 Sep 2017 11:37:56 +0200 Lars-Peter Clausen wrote: > On 09/08/2017 11:32 AM, Jonathan Cameron wrote: > > On Fri, 8 Sep 2017 07:29:06 +0100 > > Jonathan Cameron wrote: > > > >> On 8 September 2017 05:47:52 BST, Himanshi Jain > >> wrote: > >>> Added space around(one on each side of

Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Jonathan Cameron
On Fri, 8 Sep 2017 07:29:06 +0100 Jonathan Cameron wrote: > On 8 September 2017 05:47:52 BST, Himanshi Jain > wrote: > >Added space around(one on each side of) binary > >operator(-) as preferred according to kernel > >coding style. > > > >Signed-off-by: Himanshi Jain > > Take a closer look

Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-08 Thread Lars-Peter Clausen
On 09/08/2017 11:32 AM, Jonathan Cameron wrote: > On Fri, 8 Sep 2017 07:29:06 +0100 > Jonathan Cameron wrote: > >> On 8 September 2017 05:47:52 BST, Himanshi Jain >> wrote: >>> Added space around(one on each side of) binary >>> operator(-) as preferred according to kernel >>> coding style. >>>

Re: [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-07 Thread Jonathan Cameron
On 8 September 2017 05:47:52 BST, Himanshi Jain wrote: >Added space around(one on each side of) binary >operator(-) as preferred according to kernel >coding style. > >Signed-off-by: Himanshi Jain Take a closer look at that macro. It isn't doing what you think... To give a hint, changing this

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-07 Thread Julia Lawall
On Fri, 8 Sep 2017, Himanshi Jain wrote: > Added space around(one on each side of) binary I think that just around would be clear enough. In the previous patches on this file, found with git log --oneline, a subject line of staging: iio: ad7192: seems to be more popular when the patch affects

[PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-07 Thread Himanshi Jain
Added space around(one on each side of) binary operator(-) as preferred according to kernel coding style. Signed-off-by: Himanshi Jain --- drivers/staging/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/a