On Mon, 7 Jan 2019 23:27:48 +0530
Himanshu Jha wrote:
> On Wed, Jan 02, 2019 at 01:25:27PM -0800, Matt Ranostay wrote:
> >
> > > On Dec 24, 2018, at 01:58, Himanshu Jha
> > > wrote:
> > >
> > >> On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote:
> > >> Replaced bool in
On Wed, Jan 02, 2019 at 01:25:27PM -0800, Matt Ranostay wrote:
>
> > On Dec 24, 2018, at 01:58, Himanshu Jha wrote:
> >
> >> On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote:
> >> Replaced bool in struct with unsigned int bitfield to conserve space and
> >> more clearly defi
On Sat, 22 Dec 2018 21:58:25 -0500
indigo omega wrote:
> Hello Jonathan,
>
> I'd be happy to help cleanup this driver, and I'd greatly appreciate some
> direction as to what needs to be done.
>
> Thank you,
>
> Amir Ghorbanian
Sure, I'll give the current state a quick review...
Major items
> On Dec 24, 2018, at 01:58, Himanshu Jha wrote:
>
>> On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote:
>> Replaced bool in struct with unsigned int bitfield to conserve space and
>> more clearly define size of varibales
Important thing to note is depending on padding, alig
On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote:
> Replaced bool in struct with unsigned int bitfield to conserve space and
> more clearly define size of varibales
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/iio/adc/ad7192.h | 14 +++---
> 1 fil
On Fri, Dec 21, 2018 at 03:26:26PM -0800, Amir Mahdi Ghorbanian wrote:
> Replaced bool in struct with unsigned int bitfield to conserve space and
> more clearly define size of varibales
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
There was some discussion on this at Outreachy list:
https://gr
On Fri, 21 Dec 2018 15:26:26 -0800
Amir Mahdi Ghorbanian wrote:
> Replaced bool in struct with unsigned int bitfield to conserve space and
> more clearly define size of varibales
>
> Signed-off-by: Amir Mahdi Ghorbanian
Hi Amir,
I'm a bit in two minds on this one. It's not a size critical str
Replaced bool in struct with unsigned int bitfield to conserve space and
more clearly define size of varibales
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/iio/adc/ad7192.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/iio/adc/ad71
