Re: [PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Greg KH
On Sun, Oct 16, 2016 at 06:12:32PM +0530, Siddhi Dave wrote: > Fix checkpatch warning: Macros with flow control statements should be avoided > > Because Macros with flow control statements (goto and return) are > not very nice to read as any flow movement is unexpected. > > Signed-off-by: Siddhi

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Julia Lawall
On Sun, 16 Oct 2016, Siddhi Dave wrote: > Fix checkpatch warning: Macros with flow control statements should be avoided > > Because Macros with flow control statements (goto and return) are > not very nice to read as any flow movement is unexpected. > > Signed-off-by: Siddhi Dave > --- > drive

[PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Siddhi Dave
Fix checkpatch warning: Macros with flow control statements should be avoided Because Macros with flow control statements (goto and return) are not very nice to read as any flow movement is unexpected. Signed-off-by: Siddhi Dave --- drivers/staging/dgnc/dgnc_sysfs.c | 20 ++-- 1

[PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Siddhi Dave
Fix checkpatch warning: Macros with flow control statements should be avoided Because Macros with flow control statements (goto and return) are not very nice to read as any flow movement is unexpected. Signed-off-by: Siddhi Dave --- drivers/staging/dgnc/dgnc_sysfs.c | 20 ++-- 1

[PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Siddhi Dave
Fix checkpatch warning: Macros with flow control statements should be avoided Because Macros with flow control statements (goto and return) are not very nice to read as any flow movement is unexpected. Signed-off-by: Siddhi Dave --- drivers/staging/dgnc/dgnc_sysfs.c | 20 ++-- 1