Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-17 Thread Gary Rookard
On Mon, 17 Mar 2014, Greg KH wrote: On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; from out of a switch/case statement. And also, removed useless duplicate UINT uiSearchRuleIndex = 0; and a variant UINT uiSe

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-17 Thread Greg KH
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: > I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; > from out of a switch/case statement. And also, removed useless duplicate > UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. > > Signed-off-by

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-16 Thread Gary Rookard
Hi Mark, Yes, in fact it does if not for the shear fact that a declaration is not a statement. This file as well as the rest of bcm is in working draft state a real wart hog so to speak, and contained w/in it are developer tricks to mask over would be compiler errors that would crop up during th

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-16 Thread Mark Einon
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: > I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; > from out of a switch/case statement. And also, removed useless duplicate > UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. Hi, This looks l

[PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-15 Thread Gary Rookard
I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; from out of a switch/case statement. And also, removed useless duplicate UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/Cm