Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-18 Thread Gary Rookard
On Tue, 18 Mar 2014, Greg KH wrote: On Mon, Mar 17, 2014 at 08:21:34PM -0400, Gary Rookard wrote: Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppress

[PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-18 Thread Gary Rookard
Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing added to the case labels. They aid during construction time, but ar

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-18 Thread Greg KH
On Mon, Mar 17, 2014 at 08:21:34PM -0400, Gary Rookard wrote: > Firstly, some background is needed to confirm the validity of > this patch as error fixing. It seems the developer when writing > this driver from scratch, used what are known to me as error > suppressors in the form of extra tmp braci

[PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-17 Thread Gary Rookard
Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing added to the case labels. They aid during construction time, but ar

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-17 Thread Gary Rookard
On Mon, 17 Mar 2014, Greg KH wrote: On Mon, Mar 17, 2014 at 06:01:24PM -0400, Gary Rookard wrote: Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppress

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-17 Thread Greg KH
On Mon, Mar 17, 2014 at 06:01:24PM -0400, Gary Rookard wrote: > Firstly, some background is needed to confirm the validity of > this patch as error fixing. It seems the developer when writing > this driver from scratch, used what are known to me as error > suppressors in the form of extra tmp brac

[PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

2014-03-17 Thread Gary Rookard
Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing added to the case labels. They aid during construction time, but a

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-17 Thread Gary Rookard
On Mon, 17 Mar 2014, Greg KH wrote: On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; from out of a switch/case statement. And also, removed useless duplicate UINT uiSearchRuleIndex = 0; and a variant UINT uiSe

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-17 Thread Greg KH
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: > I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; > from out of a switch/case statement. And also, removed useless duplicate > UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. > > Signed-off-by

[PATCH] Staging: bcm: CmHost: moved and removed declarations

2014-03-17 Thread Gary Rookard
Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing added to the case labels. They aid during construction time, but a

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-16 Thread Gary Rookard
Hi Mark, Yes, in fact it does if not for the shear fact that a declaration is not a statement. This file as well as the rest of bcm is in working draft state a real wart hog so to speak, and contained w/in it are developer tricks to mask over would be compiler errors that would crop up during th

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-16 Thread Mark Einon
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote: > I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; > from out of a switch/case statement. And also, removed useless duplicate > UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. Hi, This looks l

[PATCH] Staging: bcm: CmHost: moved and removed declarations in switch/case.

2014-03-15 Thread Gary Rookard
I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID; from out of a switch/case statement. And also, removed useless duplicate UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/Cm