Re: [PATCH] Skein:move macros into appropriate header files

2016-05-01 Thread Greg Kroah-Hartman
On Tue, Mar 22, 2016 at 08:17:07PM +0800, Ming Li wrote: > hi, i move macros into appropriate header files. Why? What other code needs these macros to require them being moved to a .h file? confused, greg k-h ___ devel mailing list de...@linuxdriver

Re: [PATCH] Skein:move macros into appropriate header files

2016-03-29 Thread Greg Kroah-Hartman
On Wed, Mar 30, 2016 at 08:51:42AM +0800, Ming Li wrote: > hi, i move macros into header files. > > > regards, > > > Signed-off-by: Ming Li That's a very strange changelog comment, can you please expand on what you are doing this for? You need to explain _why_ you are doing something, not

[PATCH] Skein:move macros into appropriate header files

2016-03-29 Thread Ming Li
hi, i move macros into header files. regards, Signed-off-by: Ming Li --- drivers/staging/skein/skein_block.c | 322 drivers/staging/skein/skein_block.h | 322 +++- 2 files changed, 321 insertions(+), 323 deletions(-) diff -

[PATCH] Skein:move macros into appropriate header files

2016-03-22 Thread Ming Li
hi, i move macros into appropriate header files. regards, Signed-off-by: Ming Li --- drivers/staging/skein/skein_block.c | 322 drivers/staging/skein/skein_block.h | 322 +++- 2 files changed, 321 insertions(+), 323 delet

Re: [patch] Skein:move macros into appropriate header files

2016-03-21 Thread Greg Kroah-Hartman
On Mon, Mar 21, 2016 at 06:44:04PM +0800, Ming Li wrote: > hi, in drivers/staging/skein/, i move macros into appropriate header > files. > > > Regards, > > > Signed-off-by: Ming Li Please use scripts/checkpatch.pl to find the errors in your patch before sending. Also, don't send html ema