Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Julia Lawall
On Mon, 10 Oct 2016, Larry Finger wrote: > On 10/10/2016 11:56 AM, Johannes Berg wrote: > > On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: > > > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > > > > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and > > > rtl

Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Larry Finger
On 10/10/2016 11:56 AM, Johannes Berg wrote: On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, the Coccinelle script missed the fact that the code changes th

Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Johannes Berg
On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote: > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and > rtl8821ae, > the Coccinelle script missed the fact that the code changes the > firmware > name. When that happens

[PATCH] Revert "rtlwifi: rtl818x: constify local structures"

2016-10-10 Thread Larry Finger
This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, the Coccinelle script missed the fact that the code changes the firmware name. When that happens, the kernel issues a BUG splat because it is unable to overwrite the