Hi
The approximately 5,000 errors were not only null pointers, but
uninitialized variables, etc. also a mixture of error and warnings.
Same I did not consider a reall error. Then a bunch of warnings for
printf("%d", unsigned int) and vice versa, which I have not even
bothered to check even.
Rega
On Sun, May 18, 2014 at 05:49:52PM +0200, Rickard Strandqvist wrote:
> Hi
>
> When I run cppcheck find the about 5,000 errors, of these, I selected
> the 100 most serious and has made patches. But my ability to immerse
> myself in each failure has been limited unfortunately.
>
I am familiar with
Hi
When I run cppcheck find the about 5,000 errors, of these, I selected
the 100 most serious and has made patches. But my ability to immerse
myself in each failure has been limited unfortunately.
Okay, I send it through the scripts instead.
Best regards
Rickard Strandqvist
2014-05-17 20:56 G
On Sat, May 17, 2014 at 03:21:56PM +0200, Rickard Strandqvist wrote:
> Okay, everyone agrees with Dan..?
>
You can audit it yourself, there are only 4 callers. The
node_allocate() is total garbage so the second delete_node() is a bit
complicated to read but it's not that hard.
> I have made a n
Okay, everyone agrees with Dan..?
I have made a new patch, which does not check if hnode is NULL.
Best regards
Rickard Strandqvist
2014-05-16 0:43 GMT+02:00 Dan Carpenter :
> On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null p
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
None of the callers pass in a NULL hnode so there isn't actually a NULL
dereference here. You could just remove the check.
regards,
dan carpenter
_
Hi all, and Greg!
Good idea!
I will do it in all the other mail.
Best regards
Rickard Strandqvist
2014-05-16 0:08 GMT+02:00 Greg Kroah-Hartman :
> On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was
On Thu, May 15, 2014 at 11:53:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/staging/tidspbridge/rmgr
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/tidspbridge/rmgr/node.c |4 ++--
1 fil ändrad, 2 tillägg(+), 2 borttagningar(-)
diff --git a/d
