Re: [PATCH][next] staging: media: atomisp: fix memory leak of object flash

2020-09-03 Thread Dan Carpenter
On Wed, Sep 02, 2020 at 05:58:52PM +0100, Colin King wrote: > From: Colin Ian King > > In the case where the call to lm3554_platform_data_func returns an > error there is a memory leak on the error return path of object > flash. Fix this by adding an error return path that will free > flash and

Re: [PATCH][next] staging: media: atomisp: fix memory leak of object flash

2020-09-03 Thread Mauro Carvalho Chehab
Em Wed, 2 Sep 2020 21:15:31 +0300 Andy Shevchenko escreveu: > On Wed, Sep 2, 2020 at 8:02 PM Colin King wrote: > > > > From: Colin Ian King > > > > In the case where the call to lm3554_platform_data_func returns an > > error there is a memory leak on the error return path of object > > flash.

Re: [PATCH][next] staging: media: atomisp: fix memory leak of object flash

2020-09-02 Thread Andy Shevchenko
On Wed, Sep 2, 2020 at 8:02 PM Colin King wrote: > > From: Colin Ian King > > In the case where the call to lm3554_platform_data_func returns an > error there is a memory leak on the error return path of object > flash. Fix this by adding an error return path that will free > flash and rename la

[PATCH][next] staging: media: atomisp: fix memory leak of object flash

2020-09-02 Thread Colin King
From: Colin Ian King In the case where the call to lm3554_platform_data_func returns an error there is a memory leak on the error return path of object flash. Fix this by adding an error return path that will free flash and rename labels fail2 to fail3 and fail1 to fail2. Fixes: 9289cdf39992 ("