Re: [PATCH][next] staging: ks7010: fix null pointer dereference on priv on error exit

2018-04-12 Thread Colin Ian King
On 12/04/18 16:12, Dan Carpenter wrote: > This isn't right. It introduces a leak. Yup, and I see Gustavo is working on a correct fix, I'll leave that to him. > > regards, > dan carpenter > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a messa

Re: [PATCH][next] staging: ks7010: fix null pointer dereference on priv on error exit

2018-04-12 Thread Dan Carpenter
This isn't right. It introduces a leak. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH][next] staging: ks7010: fix null pointer dereference on priv on error exit

2018-04-12 Thread Colin King
From: Colin Ian King In the case where the call to dev_alloc_name fails the current exit path is via err_free_netdev and this calls free_netdev on a null priv pointer, hence causing a null pointer dereference. Fix this by instead exiting via err_release_irq. Detected by CoverityScan, CID#146784