Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-05 Thread Laurent Pinchart
Hi Geert, On Sunday 05 April 2015 11:00:56 Geert Uytterhoeven wrote: > On Sat, Apr 4, 2015 at 2:46 PM, Laurent Pinchart wrote: > >> + for (i = 0; i < dev->ngpios; i++) > >> + gpio_request_one(dev->gpios[i].gpio, dev->gpios[i].flags, > >> + pdev->name);

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-05 Thread Geert Uytterhoeven
Hi Laurent, On Sat, Apr 4, 2015 at 2:46 PM, Laurent Pinchart wrote: >> + for (i = 0; i < dev->ngpios; i++) >> + gpio_request_one(dev->gpios[i].gpio, dev->gpios[i].flags, >> + pdev->name); > > Aren't GPIO numbers dynamic too in DT-based systems ? Beside

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-05 Thread Geert Uytterhoeven
Hi Russell, On Fri, Apr 3, 2015 at 7:04 PM, Russell King - ARM Linux wrote: > On Fri, Apr 03, 2015 at 03:57:27PM +0300, Dan Carpenter wrote: >> On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote: >> > +int __init board_staging_register_clock(const struct board_staging_clk >> > *b

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-04 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Friday 03 April 2015 14:42:02 Geert Uytterhoeven wrote: > Add support for easy registering of one ore more platform devices that > may: > - need clocks that are described in DT, > - need pin control configuration, > - rely on a configured GPIO, > - be

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Russell King - ARM Linux
On Fri, Apr 03, 2015 at 03:57:27PM +0300, Dan Carpenter wrote: > On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote: > > +int __init board_staging_register_clock(const struct board_staging_clk > > *bsc) > > +{ > > + struct clk *clk; > > + int error; > > + > > + pr_debug("Regi

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Russell King - ARM Linux
On Fri, Apr 03, 2015 at 03:27:40PM +0200, Geert Uytterhoeven wrote: > On Fri, Apr 3, 2015 at 2:57 PM, Dan Carpenter > wrote: > >> + error = clk_register_clkdev(clk, bsc->con_id, bsc->dev_id); > >> + if (error) > >> + pr_err("Failed to register clock %s (%d)\n", bsc->clk, > >>

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Geert Uytterhoeven
On Fri, Apr 3, 2015 at 2:57 PM, Dan Carpenter wrote: >> + error = clk_register_clkdev(clk, bsc->con_id, bsc->dev_id); >> + if (error) >> + pr_err("Failed to register clock %s (%d)\n", bsc->clk, error); >> + return error; > > Missing curly braces. Also it's weird th

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Dan Carpenter
On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote: > +int __init board_staging_register_clock(const struct board_staging_clk *bsc) > +{ > + struct clk *clk; > + int error; > + > + pr_debug("Registering clock %s for con_id %s dev_id %s\n", bsc->clk, > + bsc-

[PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Geert Uytterhoeven
Add support for easy registering of one ore more platform devices that may: - need clocks that are described in DT, - need pin control configuration, - rely on a configured GPIO, - be part of a PM Domain. All these dependencies are optional. Signed-off-by: Geert Uytterhoeven --- drivers