[PATCH] vme: remove unneeded break

2020-10-19 Thread trix
From: Tom Rix A break is not needed if it is preceded by a return or goto Signed-off-by: Tom Rix --- drivers/vme/bridges/vme_tsi148.c | 7 --- drivers/vme/vme.c| 9 - 2 files changed, 16 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridg

[RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread trix
From: Tom Rix This is a upcoming change to clean up a new warning treewide. I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks. clang has a number of useful, new warnings see https://clang.llv

[PATCH] staging: wfx: simplify virt_addr_valid call

2020-09-12 Thread trix
From: Tom Rix Reviewing sram_write_dma_safe(), there are two identical calls to virt_addr_valid(). The second call can be simplified by a comparison of variables set from the first call. Signed-off-by: Tom Rix --- drivers/staging/wfx/fwio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-