On Wed, Jun 10, 2015 at 5:48 PM, Greg Kroah-Hartman
wrote:
>
> Are you sure all of these are correct? The kernel/user api for lustre
> is a complex beast, and just casting away the pointer types isn't
> usually the proper thing to do in order to resolve the issues here.
>
> thanks,
>
> greg k-h
In dir.c and llite_lib.c, sparse reports multiple warnings messages
due to different address spaces. This patch resolves these warnings
by adding the tag __user for username addresses.
Signed-off-by: Tolga Ceylan
---
drivers/staging/lustre/lustre/llite/dir.c | 78
: Tolga Ceylan
---
drivers/staging/lustre/lustre/obdclass/llog_cat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/llog_cat.c
b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
index c8f6ab0..280e861 100644
--- a/drivers/staging
The second patch is better (it also keeps the lock locked shorter.) Do
I need to resend?
On Tue, Jun 2, 2015 at 11:42 PM, Sudip Mukherjee
wrote:
> On Tue, Jun 02, 2015 at 12:57:20PM -0700, Tolga Ceylan wrote:
>> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
&
In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
warning due its inability to detect the noreturn attribute in
lbug_with_lock() function inside LBUG macro. Adding a never reached
return statement suppresses this warning.
Signed-off-by: Tolga Ceylan
---
drivers/staging
as cpu order.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e8b12
I appreciate the suggestions.
I simply grepped this piece of code by chance while looking at an
actual sparse warning somewhere else. There's no
symptoms and I'm not sure under what conditions this debug statement
is printed nor why/when. But this is an obviously buggy
code only impacting debug/tr
On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
visorchipset_file_init() and visorchipset_file_cleanup() functions
do not seem to be used from anywhere else and now are declared
as static. Sparse emitted "not declared" warnings for these two
functions.
Signed-off-by: Tolga Ceylan
---
On 05/12/2015 08:55 PM, Tolga Ceylan wrote:
Error code returned from auth_parse() should in cpu byte order.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
visorchipset_file_init() and visorchipset_file_cleanup() functions
do not seem to be used from anywhere else and now are declared
as static. Sparse emitted "not declared" warnings for these two
functions.
Signed-off-by: Tolga Ceylan
---
drivers/staging/unisys/visorbus/visorchipset.c |
In ni_ai_cmd() bitwise or construction of ai_trig in case of TRIG_NOW
is faulty. Register address is accidentally in the expression,
but this has no effect. This is an accidental left-over code
that used to call a function with register address as one of
the arguments.
Signed-off-by: Tolga Ceylan
Error code returned from auth_parse() should in cpu byte order.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/staging
Error code returned from auth_parse() should in cpu byte order. Issue
caught by sparse warning: cast from restricted __le16.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e
To fix sparse warning of incorrect type when calling vfree()
(different address space), added annotation __force.
Signed-off-by: Tolga Ceylan
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers
To fix sparse warning of incorrect type in assignment
(different address space), added annotation __iomem to
vmem8 and modified direct reads with ioread8().
Signed-off-by: Tolga Ceylan
---
drivers/staging/fbtft/fbtft-bus.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
On Sun, Mar 1, 2015 at 5:18 PM, Greg Kroah-Hartman
wrote:
> On Fri, Feb 27, 2015 at 09:44:42PM -0800, Tolga Ceylan wrote:
>> Replaced C99 '//' comments with C89 '/**/'
>>
>> Signed-off-by: Tolga Ceylan
>> ---
>> drivers/staging/fbtft/fb_ssd
Replaced C99 '//' comments with C89 '/**/'
Signed-off-by: Tolga Ceylan
---
drivers/staging/fbtft/fb_ssd1331.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c
b/drivers/staging/fbtf
On Fri, Feb 27, 2015 at 9:37 PM, Tolga Ceylan wrote:
> Replaced C99 '//' comments with C89 '/**/'
>
> Signed-off-by: Tolga Ceylan
> ---
> drivers/staging/fbtft/fb_ssd1331.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletio
Replaced C99 '//' comments with C89 '/**/'
Signed-off-by: Tolga Ceylan
---
drivers/staging/fbtft/fb_ssd1331.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c
b/drivers/staging/fbtf
Removed space before ','
Signed-off-by: Tolga Ceylan
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 37dcf7e..ac4287f 100644
--- a/drivers/sta
1) Removed commented out include header statement
2) Removed unnecessary author/date comment
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r8192U_wx.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.h
b/drivers/staging
Removed a commented out header include
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index
Replaced C99 comments with C89 while maintaining less than 80 char lines.
Removed commented out struct member: DLRecord.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers
Added parenthesis to RESET_CIE_WATCHDOG macro to resolve checkpatch
error.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h
b/drivers/staging/rtl8192u
On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan wrote:
> On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches wrote:
>>
>> Might as well remove the unnecessary cast too:
>>
>> memcpy(skb->cb, &dev, sizeof(dev));
>>
>> but it might b
On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches wrote:
>
> Might as well remove the unnecessary cast too:
>
> memcpy(skb->cb, &dev, sizeof(dev));
>
> but it might be better to avoid the memcpy and use an assign
>
> *(struct net_device *)skb->cb = dev;
>
I'll submit another p
Resolved space required after that ',' errors reported by checkpatch.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r819xU_firmware.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drive
Removed commented out variable
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r819xU_firmware.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index c230be2..9d0067e 100644
--- a/drivers
Removed an assert that was commented out. The comment provides
no documentation value as rt_status is properly handled.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r819xU_firmware.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b
Replaced C99 comments with C89.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r819xU_firmware.c | 33 +++---
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u
1) Spaces prohibited after that '&'
2) No space is necessary after a cast
Signed-off-by: Tolga Ceylan
---
drivers/staging/i2o/i2o_block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/i2o/i2o_block.c b/drivers/staging/i2o/i2o_block.c
"u32 ** mptr" should be "u32 **mptr"
Signed-off-by: Tolga Ceylan
---
drivers/staging/i2o/i2o_block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i2o/i2o_block.c b/drivers/staging/i2o/i2o_block.c
index 0a13c64..9164569 100644
--- a
Removed assignment in if condition
Signed-off-by: Tolga Ceylan
---
drivers/staging/i2o/i2o_scsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/i2o/i2o_scsi.c b/drivers/staging/i2o/i2o_scsi.c
index 1b11dcb..f320366 100644
--- a/drivers/staging/i2o
Code reformatting based on checkpatch.pl with --strict:
Comparison to NULL rewritten as !indio_dev
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/meter/ade7854-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c
b/drivers
Code reformatting based on checkpatch.pl with --strict:
Lines over 80 characters were fixed
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c
b/drivers/staging
Code reformatting based on checkpatch.pl with --strict:
Alignment should match open paranthesis cases corrected
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/meter/ade7854-i2c.c | 34 -
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers
In memory allocation (kzalloc, kmalloc) arguments
sizeof(struct foo) rewritten as sizeof(*foo_obj).
Signed-off-by: Tolga Ceylan
---
drivers/staging/gdm724x/gdm_mux.c | 8
drivers/staging/gdm724x/gdm_tty.c | 2 +-
drivers/staging/gdm724x/gdm_usb.c | 10 +-
3 files changed, 10
Comparisons such as if (x == NULL) rewritten as if (!x)
Signed-off-by: Tolga Ceylan
---
drivers/staging/gdm724x/gdm_lte.c | 6 +++---
drivers/staging/gdm724x/gdm_mux.c | 4 ++--
drivers/staging/gdm724x/gdm_tty.c | 2 +-
drivers/staging/gdm724x/gdm_usb.c | 14 +++---
4 files changed
Alignment should match open paranthesis cases corrected
Signed-off-by: Tolga Ceylan
---
drivers/staging/gdm724x/gdm_lte.c | 32
drivers/staging/gdm724x/gdm_lte.h | 14 +++---
drivers/staging/gdm724x/gdm_mux.c | 5 +++--
drivers/staging/gdm724x
Unnecessary blank lines removed
Signed-off-by: Tolga Ceylan
---
drivers/staging/gdm724x/gdm_endian.c | 1 -
drivers/staging/gdm724x/gdm_mux.c| 5 -
drivers/staging/gdm724x/gdm_tty.c| 1 -
drivers/staging/gdm724x/gdm_tty.h| 1 -
drivers/staging/gdm724x/hci_packet.h | 1 -
5 files
Corrections based on checkpatch.pl with --strict.
Added missing spaces between operators.
Signed-off-by: Tolga Ceylan
---
drivers/staging/gdm724x/gdm_lte.c | 6 +++---
drivers/staging/gdm724x/gdm_mux.c | 4 ++--
drivers/staging/gdm724x/gdm_mux.h | 4 ++--
drivers/staging/gdm724x
d macros
> cpu_to_be16()/le16() and back for these.
>
> regards,
> dan carpenter
Thanks, I'll skip this one.
Regards,
Tolga Ceylan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Feb 13, 2015 at 12:27 AM, Sudip Mukherjee
wrote:
>
> you are doing three different types of changes here. one patch should have
> only one type of change.
>
> regards
> sudip
Thank you, I'll split this up and resubmit.
Regards,
Tolga
___
devel
lines removed
7) in mem alloc arguments sizeof(struct foo) rewritten as sizeof(*foo_obj)
Signed-off-by: Tolga Ceylan
---
drivers/staging/gdm724x/gdm_endian.c | 9 +++
drivers/staging/gdm724x/gdm_endian.h | 4 +--
drivers/staging/gdm724x/gdm_lte.c| 42 ++---
drivers
On 02/12/2015 10:20 PM, Joe Perches wrote:
On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote:
On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote:
That looks kind of uglier than before. Please run your patch throught
scripts/checkpatch.pl --strict.
[]
Running with --strict helped, but
Code reformatting based on checkpatch.pl with --strict:
1) Lines over 80 characters were fixed
2) Alignment should match open paranthesis cases corrected
3) Comparison to NULL rewritten as !indio_dev
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/meter/ade7854-i2c.c | 39
On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote:
> That looks kind of uglier than before. Please run your patch throught
> scripts/checkpatch.pl --strict.
>
> regards,
> dan carpenter
>
Running with --strict helped, but now I'm also getting warnings for
camel case usage. If I try to fix cam
statement in
dgnc_tty_ioctl() at case TCLFLSH to reduce nesting.
Signed-off-by: Tolga Ceylan
---
drivers/staging/dgnc/dgnc_tty.c | 266 +---
1 file changed, 168 insertions(+), 98 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
Lines over 80 were corrected
RT_TRACE format strings should specify unsigned instead of signed int
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 244 ++-
1 file changed, 174 insertions(+), 70 deletions(-)
diff --git a/drivers/staging
Thank you, I'll resubmit this with additional corrections to format strings.
On Sun, Feb 8, 2015 at 1:54 AM, Joe Perches wrote:
> On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote:
>> Lines over 80 were corrected
> []
>> diff --git a/drivers/staging/rtl8192u/r8190_
Lines over 80 were corrected
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 244 ++-
1 file changed, 174 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
Indentation corrections in struct initializations and
one line over 80 characters split into two lines
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/magnetometer/hmc5843_i2c.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging
Line over 80 characters corrected
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c
b/drivers/staging/iio/meter/ade7854-i2c.c
index 5b33c7f..5d0671a 100644
--- a
Misspelled comment corrected
Signed-off-by: tolga ceylan
---
drivers/staging/netlogic/xlr_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/netlogic/xlr_net.c
b/drivers/staging/netlogic/xlr_net.c
index 5ecb3e6..e8aae09 100644
--- a/drivers/staging
54 matches
Mail list logo
