Re: [PATCH] staging: iio: cdc: ad7746: Fix unnecessary check andassignment in ad7746_probe()

2021-05-18 Thread tangbin
Hi Dan: On 2021/5/18 15:52, Dan Carpenter wrote: On Mon, May 17, 2021 at 11:00:06PM +0800, Tang Bin wrote: @@ -730,11 +730,7 @@ static int ad7746_probe(struct i2c_client *client, if (ret < 0) return ret; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_de

Re: [PATCH] staging: iio: cdc: ad7746: Fix unnecessary check andassignment in ad7746_probe()

2021-05-17 Thread tangbin
Hi Marcelo: On 2021/5/18 6:14, Marcelo Schmitt wrote: Hi Tang, The patch looks overall good, though I think it could be split into two pieces: one for simplifying ret declaration and another for removing the check after device register. Despite that, I guess Lucas might already be working on si