about why you have added Greg and staging list instead
of 'linux-...@vger.kernel.org'.
--
Regards
Sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The build of xtensa allmodconfig gives warning of:
In function 'rtw_cfg80211_unlink_bss':
warning: the frame size of 1136 bytes is larger than 1024 bytes
Instead of having 'select_network' structure as a variable use it as a
pointer.
Signed-off-by: Sudip Mukherjee
---
drive
...@lists.freedesktop.org
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/TODO | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO
index f710ab1..aeb2df3 100644
--- a/drivers/staging/sm750fb/TODO
+++ b/drivers/staging
On Wed, Jul 12, 2017 at 08:06:24AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 11, 2017 at 10:03:01PM +0100, Sudip Mukherjee wrote:
> > Hi Greg,
> >
> > On Fri, Jun 30, 2017 at 09:57:43PM +0100, Sudip Mukherjee wrote:
> > > From: Teddy Wang
> > >
&
Hi Greg,
On Fri, Jun 30, 2017 at 09:57:43PM +0100, Sudip Mukherjee wrote:
> From: Teddy Wang
>
> If vesafb is enabled in the config then /dev/fb0 is created by vesa
> and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
> effectively work with xorg.
> So if i
-off-by: Sudip Mukherjee
---
In the previous send, why #ifdef is used was asked.
https://lkml.org/lkml/2017/6/25/57
Answered at: https://lkml.org/lkml/2017/6/25/69
Also pasting here for reference.
'Did a quick research into "why".
The patch d8801e4df91e ("x86/PCI: Set IORESO
On Sun, Jun 25, 2017 at 04:27:23PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote:
> > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote:
> > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote:
&
On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote:
> > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote:
> > > From: Teddy Wang
> > >
> > > If vesafb is en
On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote:
> From: Teddy Wang
>
> If vesafb is enabled in the config then /dev/fb0 is created by vesa
> and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
> effectively work with xorg.
> So if it has been
e...
>
> Agree. It's not a cargo cult.
> If there any real thing behind that #ifdef I would like to hear.
I dont know the real thing behind that. You can hear the real thing if
you send that patch to drm. And that is the only reason I mentioned that.
--
Regards
Sudip
__
w what has
been done there. And since sm750 ultimately has to be converted to a drm
driver to be taken out of staging, so I will prefer to have similar
changes here.
--
Regards
Sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linu
On Mon, Jun 19, 2017 at 11:47:20PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
> wrote:
>
>
> > +#ifdef CONFIG_X86
> > + primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> > +
From: Teddy Wang
If vesafb is enabled in the config then /dev/fb0 is created by vesa
and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
effectively work with xorg.
So if it has been alloted fb1, then try to remove the other fb0.
Signed-off-by: Teddy Wang
Signed-off-by: Sudip
750fb: change default screen resolution")
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8199dbe..aa26280 100644
--- a/drivers/staging/sm750
Update the default screen resolution and also use 24bpp for a better
screen performance.
Tested-by: Teddy Wang
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers
From: Sudip Mukherjee
Modify lirc_parallel driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
Resending after more than one year.
Prevoius patch is at https://patchwork.kernel.org/patch/7883591/
drivers/staging/media/lirc/lirc_parallel.c | 93
On Saturday 26 November 2016 11:02 AM, Greg Kroah-Hartman wrote:
On Sat, Nov 26, 2016 at 09:07:42AM +, Sudip Mukherjee wrote:
The driver was actually released with BSD license. It also gained GPL
when it was submitted to be included in the kernel.
Cc: Teddy Wang
Cc: gzhou1
Signed-off-by
The driver was actually released with BSD license. It also gained GPL
when it was submitted to be included in the kernel.
Cc: Teddy Wang
Cc: gzhou1
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
1 deletion(-)
which tree are you using?
This file has been removed from staging by:
35538d7822e8 ("dma-buf/sw_sync: de-stage SW_SYNC")
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
uspect code indent for conditional statements (16, 32)
>
> Signed-off-by: Louie Lu
> ---
That becomes 3 different changes in a single patch.
You should be doing a single type of change in a patch.
please break them into separate patches.
regards
sudip
__
; ---
Please keep a blank line between your commit message and your
Signed-off-by line.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ging: rtl8723au: hal: Remove pointless test")
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
If the firmware request failed we were just returning but we missed
freeing the memory and releasing the MMC Host.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b
if it is still not claimed then mmc_host->claim_cnt will be 0
and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
condition will become true.
Lets just return the value on allocation failure instead of trying to
release the host before claiming it.
Signe
On Thu, Aug 25, 2016 at 09:59:46PM +0800, Ming-Chia Chung wrote:
> On Tue, Aug 23, 2016 at 12:01:36PM +0530, Sudip Mukherjee wrote:
> > On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote:
> > > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote:
>
On Wed, Aug 24, 2016 at 03:56:32AM +0700, Didik Setiawan wrote:
> Fix checkpatch.pl warning about "Alignment should match open parenthesis".
> ---
you missed the Signed-off-by: line.
regards
sudip
___
devel mailing list
de...@linuxd
If the firmware request failed we were just returning but we missed
freeing the memory and releasing the MMC Host.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b
if it is still not claimed then mmc_host->claim_cnt will be 0
and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
condition will become true.
Lets just return the value on allocation failure instead of trying to
release the host before claiming it.
Signed-off-by: Sudi
00, 10, 100, 1000
> };
This has already been done by:
49c9d6ad68ae ("staging: comedi/drivers: Fixed sparse warnings")
regards
sudip
>
>
>
>
> ___
> devel mailing list
> de.
Its better to use memdup_user which does the same thing which this
code has implemented. Also removed a related warning as we will be
warned if allocation fails.
Suggested-by: Fengguang Wu
Signed-off-by: Sudip Mukherjee
---
v2: removed type change done in v1, and removed a warning.
drivers
On Tue, Aug 23, 2016 at 06:50:30AM -0400, Greg Kroah-Hartman wrote:
> On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote:
> > Its better to use memdup_user which does the same thing which this
> > code has implemented.
> >
> > Suggested-by: Fengguang W
Its better to use memdup_user which does the same thing which this
code has implemented.
Suggested-by: Fengguang Wu
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/i4l/icn
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang
> ---
The subject should have been [Patch v2] not resend.
regards
sudip
___
devel mai
GI_SetCRT1DE(unsigned short ModeIdIndex,
> tempax |= 0x40;
> xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> - data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
> tempax = 0;
> if (tempbx & 0x04)
The patch will not apply. Its mis
lementation
> > This is a little bit restricted to reduce false positives
> >
> > Generated by: scripts/coccinelle/api/memdup_user.cocci
> >
> > CC: Sudip Mukherjee
> > Signed-off-by: Fengguang Wu
> > ---
> >
>
> There's no patch here
On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote:
> On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote:
> > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote:
> > > This patch fixes a minor checkpatch warnings:
> > >
> >
ast) must have a length
The alignment doesnot look correct here. Also in some more places later
in this patch.
regards
Sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 45623fa..fa705db 100644
--- a/drivers/staging/i4l/icn/icn.c
+++ b
Blank lines are not needed after starting brace or before a closing
brace.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 1f72884..45623fa 100644
--- a
No need provide a space after a typecast.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 66 +--
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index
The macro EVAL_PLCI and MAKE_PLCI are not being used. Remove them.
But keep the comment preceding them as it contains information
regarding message format.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/act2000/capi.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers
The macro EVAL_NCCI was only being used in capi.c and the argument
controller was not used. Remove the argument and at the same time
remove the variable which now becomes unused.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/act2000/capi.c | 3 +--
drivers/staging/i4l/act2000/capi.h
-by: Sudip Mukherjee
---
Wrong Signed-off in v1.
drivers/staging/i4l/icn/icn.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 6991259..5e3821b 100644
--- a/drivers/staging
Blank lines are not needed after starting brace or before a closing
brace.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index ff0fb6c6..6991259 100644
--- a
No need provide a space after a typecast.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 70 +--
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index
It is not the kernel coding style to make assignments in the if
statement and checkpatch was warning us about it.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers
-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 6991259..5e3821b 100644
--- a/drivers/staging/i4l/icn/icn.c
+++ b
return is not a function so no need to use the parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 46d957c..c5dd572
Braces are not required in a single statement block.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index abc6599..ff0fb6c6 100644
--- a
On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote:
Em Mon, 25 Jan 2016 22:32:31 +0530
Sudip Mukherjee escreveu:
On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote:
Em Fri, 18 Dec 2015 18:35:29 +0530
Sudip Mukherjee escreveu:
Modify lirc_parallel driver to
checkpatch complains about an extra blank line after an opening brace.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/act2000/act2000_isa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/act2000_isa.c
b/drivers/staging/i4l/act2000/act2000_isa.c
index
It is not the kernel coding style to assign values to some variable in
if statement. Split them up into different statements.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/act2000/act2000_isa.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
It is not kernel coding style to give an extra space after a cast.
We get warned about it by checkpatch.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/act2000/act2000_isa.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/i4l/act2000
checkpatch warns that return is not a function and as such the brace
after it is not required.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/act2000/act2000_isa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/act2000_isa.c
b/drivers
The semaphore was being released twice, once at the beginning of the
thread and then again when the thread is about to close.
The semaphore is acquired immediately after creating the thread so we
should be releasing it when the thread ends.
Signed-off-by: Sudip Mukherjee
---
drivers/staging
These variables were havnig the pointer returned by wiphy_priv() but
they were never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/wilc1000/linux_wlan.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000
ion_device_create() can fail and if it fails then it returns the error
value in ERR_PTR.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/android/ion/ion_dummy_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/ion/ion_dummy_driver.c
b/drivers/staging
The only user of ion_handle_put() is within the file ion.c, so we can
safely make it static. Just to be double sure, checked the function
ion_handle_get() which is static.
So we can make ion_handle_put() static.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/android/ion/ion.c | 2 +-
1 file
While building with W=1 we were getting the warning:
drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16:
warning: old-style function definition
struct lu_env *cl_env_percpu_get()
^
Signed-off-by: Sudip Mukherjee
---
drivers/staging/lustre/lustre/obdclass
The variable unipolar was never used.
Signed-off-by: Sudip Mukherjee
---
There may be a chance that reading from DAS1800_CONTROL_C is necessary
before reading from DAS1800_STATUS. If that is true then please discard
this patch.
drivers/staging/comedi/drivers/das1800.c | 3 ---
1 file changed
te_E() can return -ENOMEM so eprom_r() also can return
-ENOMEM. So if eprom_r() fails then err becomes -12 << (15-i) where i
ranges from 0 to 16.
> + if (err)
> + return err;
And that values is used to decide the error. oops... am i reading it
properly?
bove are not required in the commit log. Please send v2 of
both your patches without these lines.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jan 25, 2016 at 03:12:57PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 25 Jan 2016 22:32:31 +0530
> Sudip Mukherjee escreveu:
>
> > On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote:
> > > Em Fri, 18 Dec 2015 18:35:29 +0530
> &g
with the error:
"Driver 'dgnc' is already registered."
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index 1d1
dgnc_remove_driver_sysfiles() depending on the argument passed to it.
Reported-by: Navy Cheng
Signed-off-by: Sudip Mukherjee
---
Hi Greg,
If you remember this problem was reported by Navy Cheng on the
kernelnewbies list but his report did not contain the call trace. He
just reported that his system hangs after reloading
with the error code.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_driver.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index c32f208..1d1d5c8 100644
--- a/drivers
If pci_enable_device() fails then we can return directly.
Signed-off-by: Sudip Mukherjee
---
I saw there is some pending dgnc patch in outreachy, so this series
might not apply. This series is based on staging-testing.
I will resend v2 if it fails.
drivers/staging/dgnc/dgnc_driver.c | 14
two different PLL registers for two different displays
like this? They will obviously have different clocks.
Am i missing something here?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listi
re changing one use of PANEL_PLL_CTRL to PLL_CTRL while
keeping another use unchanged. Any reason for that?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Feb 09, 2016 at 10:16:12AM -0500, Ben Romer wrote:
> On Mon, 2016-02-08 at 22:39 +0530, Sudip Mukherjee wrote:
> > maybe this is better where you have single exit point and so only one
> > spin_unlock_irqrestore().
>
>
> We discussed this before. I don'
mapping error")
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
dma_dir, timeout);
> + } else
This will introduce new checkpatch warning. If you are giving braces in
the if block then you need to have braces in the else part also.
regards
sudip
___
devel mailing list
de...@linux
On Mon, Feb 08, 2016 at 10:46:57PM +0530, Sudip Mukherjee wrote:
> On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote:
> > > The success path and the error path both are first doing
> >
On Sun, Feb 07, 2016 at 02:14:56PM -0800, Greg Kroah-Hartman wrote:
> On Sun, Nov 22, 2015 at 10:30:55PM +0530, Sudip Mukherjee wrote:
> > We were returning ENOMEM on all types of errors. Lets return the actual
> > error code. At the same time remove the label which became unused
We were returning ENOMEM on all types of errors. Lets return the actual
error code. At the same time remove the label which became unused as a
result of this patch.
Signed-off-by: Sudip Mukherjee
---
v1 failed to apply due to some other changes.
drivers/staging/most/mostcore/core.c | 27
On error we were returning retval, but retval is not having the error
value. We will get the error value using PTR_ERR.
Signed-off-by: Sudip Mukherjee
---
v2: sent after rebasing
drivers/staging/most/aim-cdev/cdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote:
> On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote:
> > The success path and the error path both are first doing
> > spin_unlock_irqrestore() before returning. Use that in the common path
> > a
;device, "%s changing state\n",
__func__);
- spin_unlock_irqrestore(&devdata->priv_lock, flags);
- return -EINVAL;
- } else
- spin_unlock_irqrestore(&devdata->priv_lock, flags);
+ ret
wowlan'
Looking at other drivers wowlan can be only used when CONFIG_PM is
defined.
Fixes: 73584a40d748 ("staging: wilc1000: add ops resuem/suspend/wakeup in
cfg80211")
Cc: Glen Lee
Signed-off-by: Sudip Mukherjee
---
builds of next-20160205.
I think I have seen the same repor
-patch? It will show the files being moved, not being deleted and
> added again, making it much easier to see that nothing is changing
> during the move.
while at it please modify the MAINTAINERS file also.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
patch.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
param(filter, int, 0);
> -MODULE_PARM_DESC(filter,
> - "Selects TV flicker filter type (only for systems with a SiS301 video
> bridge). Possible values 0-7. Default: [no filter]).");
> +MODULE_PARM_DESC(filter, "Selects TV flicker filter type (only for syste
ARNING: storage class should be at the beginning of the declaration
You are doing too many things in one patch. Please break them up into
separate patches. Each patch should do only one type of change.
regards
sudip
___
devel mailing list
de
> Short answer: Never.
The ultimate aim of a driver in staging is to graduate out of staging
area into the main part of the kernel. If it is already known that this
driver can never move out of staging then IMHO its better to remove it.
regards
sudip
___
On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote:
Em Mon, 25 Jan 2016 22:32:31 +0530
Sudip Mukherjee escreveu:
On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote:
Em Fri, 18 Dec 2015 18:35:29 +0530
Sudip Mukherjee escreveu:
Modify lirc_parallel driver to
On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote:
> Em Fri, 18 Dec 2015 18:35:29 +0530
> Sudip Mukherjee escreveu:
>
> > Modify lirc_parallel driver to use the new parallel port device model.
>
> Did you or someone else tested this patch?
Only build
; > I guess we'll never know.
>
> So when isn't usleep_range preferred over udelay?
inside a spin_lock or in some interrupt routine.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jan 25, 2016 at 03:40:41PM +0300, Dan Carpenter wrote:
> On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote:
> > Apart from the mail which Ying Huang sent to me last week for another error
> > (which actually turned out to be this one), i saw the first report by
ean-up?
I think the main part is still pending. using in-kernel wireless stack.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ng a list of errors sent by 0day to check if
they are getting fixed or not.
Or maybe Ying Huang has some mechanism. do you?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Jan 23, 2016 at 02:49:20PM +0530, Sudip Mukherjee wrote:
> This reverts commit ebd43516d3879f882a403836bba8bc5791f26a28.
>
> We should not be sleeping inside spin_lock.
>
> Fixes: ebd43516d387 ("Staging: panel: usleep_range is preferred over udelay")
> Cc: Si
This reverts commit ebd43516d3879f882a403836bba8bc5791f26a28.
We should not be sleeping inside spin_lock.
Fixes: ebd43516d387 ("Staging: panel: usleep_range is preferred over udelay")
Cc: Sirnam Swetha
Signed-off-by: Sudip Mukherjee
---
drivers/staging/panel/pa
checkpatch error was introduced by 1/27 patch of this series. Maybe
it will be better to fix it in that one.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
n_spi.c | 183
> --
linux_wlan_spi.c has been deleted by:
523fc23f1179 ("staging: wilc1000: remove unused files")
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Jan 09, 2016 at 11:23:14AM +0530, Pranjal wrote:
>
>
> On Saturday 09 January 2016 09:58 AM, Sudip Mukherjee wrote:
> >On Sat, Jan 09, 2016 at 12:29:21AM +0530, Pranjal Bhor wrote:
> >>Block comments now end with '*/' on a newline and all lines
&g
l) always has CC to lkml.
Infact, I have setup an alias for that so that i don't have to add lkml
manually everytime.
sm = send-email --cc=linux-ker...@vger.kernel.org
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
is not
applying and git says patch is corrupt.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote:
> On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee
> wrote:
> > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote:
> >> Split comment in order to fit into 80 characters per line.
> &
rial(' ' & 0x0F);
lcd_send_serial((' ' >> 4) & 0x0F);
- usleep_range(40, 100); /* the shortest data takes at least 40
us */
+ /* the shortest data takes at least 40 us */
+ usleep_range(40, 100);
}
bool range.
> ---
Signed-off-by missing.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
1 - 100 of 1045 matches
Mail list logo
