Re: [PATCH v4 3/3] binder: use euid from cred instead of using task

2021-10-12 Thread Stephen Smalley
's 'struct task'. This ensures > > > > > the euid is associated with the security context that > > > > > of the task that opened binder. > > > > > > > > > > Fixes: 457b9a6f09f0 ("Staging: android: add binder driver") &

Re: [PATCH v2] binder: use cred instead of task for selinux checks

2021-10-05 Thread Stephen Smalley
On Tue, Oct 5, 2021 at 12:49 PM Todd Kjos wrote: > > On Tue, Oct 5, 2021 at 8:21 AM Stephen Smalley > wrote: > > > > On Mon, Oct 4, 2021 at 8:27 PM Jann Horn wrote: > > > > > > On Tue, Oct 5, 2021 at 1:38 AM Casey Schaufler > > > wrot

Re: [PATCH v2] binder: use cred instead of task for selinux checks

2021-10-05 Thread Stephen Smalley
On Mon, Oct 4, 2021 at 8:27 PM Jann Horn wrote: > > On Tue, Oct 5, 2021 at 1:38 AM Casey Schaufler wrote: > > On 10/4/2021 3:28 PM, Jann Horn wrote: > > > On Mon, Oct 4, 2021 at 6:19 PM Casey Schaufler > > > wrote: > > >> On 10/1/2021 3:58 PM, Jann Horn wrote: > > >>> On Fri, Oct 1, 2021 at 10:

Re: [GIT PULL] Staging/IIO driver updates for 5.13-rc1

2021-04-26 Thread Stephen Rothwell
151.67fcf...@canb.auug.org.au/ (the scmi tree commit mentioned in the latter is now in the arm-soc tree) Not issues as such, but worth mentioning the conflicts and resolutions. -- Cheers, Stephen Rothwell pgpGUzVR9OafJ.pgp Description: OpenPGP digital

Re: [PATCH v13 4/4] MAINTAINERS: add MT7621 CLOCK maintainer

2021-04-13 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-04-09 22:50:59) > Adding myself as maintainer for mt7621 clock driver. > > Signed-off-by: Sergio Paracuellos > --- Applied to clk-next ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproj

Re: [PATCH v13 3/4] staging: mt7621-dts: use valid vendor 'mediatek' instead of invalid 'mtk'

2021-04-13 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-04-09 22:50:58) > Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml' > contains 'mediatek' as a valid vendor string. Some nodes in the device > tree are using an invalid vendor string vfor 'mtk' instead. Fix all of > them in dts file. Update als

Re: [PATCH v13 2/4] staging: mt7621-dts: make use of new 'mt7621-clk'

2021-04-13 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-04-09 22:50:57) > Clocks for SoC mt7621 have been properly integrated so there is > no need to declare fixed clocks at all in the device tree. Remove > all of them, add new device tree nodes for mt7621-clk and update > the rest of the nodes to use them. > > Acked-b

Re: [PATCH v13 1/4] clk: ralink: add clock driver for mt7621 SoC

2021-04-13 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-04-09 22:50:56) > The documentation for this SOC only talks about two > registers regarding to the clocks: > * SYSC_REG_CPLL_CLKCFG0 - provides some information about > boostrapped refclock. PLL and dividers used for CPU and some > sort of BUS. > * SYSC_REG_CPLL_CLK

Re: [PATCH v10 8/9] dt-bindings: add documentation of xilinx clocking wizard

2021-04-09 Thread Stephen Boyd
Quoting Michal Simek (2021-04-08 03:40:29) > > > On 4/8/21 12:26 PM, Shubhrajyoti Datta wrote: > > On Sun, Mar 7, 2021 at 1:50 AM Rob Herring wrote: > >> > >> On Wed, Feb 24, 2021 at 06:40:40PM +0530, Shubhrajyoti Datta wrote: > >>> Add the devicetree binding for the xilinx clocking wizard. > >>

Re: [PATCH v11 3/6] clk: ralink: add clock driver for mt7621 SoC

2021-04-09 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-04-09 11:34:35) > On Fri, Apr 9, 2021 at 8:14 PM Stephen Boyd wrote: > > > > Quoting Sergio Paracuellos (2021-03-08 21:22:23) > > > diff --git a/drivers/clk/ralink/Makefile b/drivers/clk/ralink/Makefile > > > new file mod

Re: [PATCH v11 0/6] MIPS: ralink: add CPU clock detection and clock driver for MT7621

2021-04-09 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-03-23 01:13:22) > On Tue, Mar 9, 2021 at 6:22 AM Sergio Paracuellos > wrote: > > > > Changes in v11: > > - Collect Rob's Reviewed-by in bindings documentation patch. > > - Fix MAINTAINERS patch using file 'mediatek,mt7621-sysc.yaml' > >for documentation bindi

Re: [PATCH v11 2/6] dt: bindings: add mt7621-sysc device tree binding documentation

2021-04-09 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-03-08 21:22:22) > Adds device tree binding documentation for clocks in the > MT7621 SOC. > > Reviewed-by: Rob Herring > Signed-off-by: Sergio Paracuellos > --- Applied to clk-next ___ devel mailing list de...@linuxdriv

Re: [PATCH v11 1/6] dt-bindings: clock: add dt binding header for mt7621 clocks

2021-04-09 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-03-08 21:22:21) > Adds dt binding header for 'mediatek,mt7621-clk' clocks. > > Acked-by: Rob Herring > Signed-off-by: Sergio Paracuellos > --- Applied to clk-next ___ devel mailing list de...@linuxdriverproject.org htt

Re: [PATCH v11 3/6] clk: ralink: add clock driver for mt7621 SoC

2021-04-09 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-03-08 21:22:23) > diff --git a/drivers/clk/ralink/Kconfig b/drivers/clk/ralink/Kconfig > new file mode 100644 > index ..3e3f5cb9ad88 > --- /dev/null > +++ b/drivers/clk/ralink/Kconfig > @@ -0,0 +1,15 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +

Re: [PATCH v5 0/6] MIPS: ralink: add CPU clock detection and clock driver for MT7621

2021-02-11 Thread Stephen Boyd
Quoting Sergio Paracuellos (2021-01-17 06:19:36) > Hi all, > > On Sun, Dec 20, 2020 at 10:37 AM Sergio Paracuellos > wrote: > > > > - Hardcode "xtal" as parent in FIXED macro. > > - Change 'else if' clause into 'if' clause since a return statement was > >being used in 'mt7621_xtal_recalc_ra

Re: [PATCH v8 11/14] spmi: hisi-spmi-controller: move driver from staging

2021-02-08 Thread Stephen Boyd
Quoting Mauro Carvalho Chehab (2021-01-29 11:51:57) > The Hisilicon 6421v600 SPMI driver is ready for mainstream. > > So, move it from staging. > > Signed-off-by: Mauro Carvalho Chehab > --- Acked-by: Stephen Boyd Rob had some comments on the binding that don't look to

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

2021-02-06 Thread Stephen Rothwell
S 0 /* GPIO_P153 on KZM9D */ > #define INT_VBUS 0 /* IRQ for GPIO_P153 */ > -struct gpio_desc *vbus_gpio; > -int vbus_irq; > +extern struct gpio_desc *vbus_gpio; > +extern int vbus_irq; > > /* Board dependence(Wait) */ > > --

Re: [PATCH v4 3/6] clk: ralink: add clock driver for mt7621 SoC

2020-12-17 Thread Stephen Boyd
Quoting Sergio Paracuellos (2020-12-17 01:54:18) > > On Thu, Dec 17, 2020 at 10:09 AM Stephen Boyd wrote: > > > > Quoting Sergio Paracuellos (2020-11-22 01:55:53) > > > diff --git a/drivers/clk/ralink/Makefile b/drivers/clk/ralink/Makefile > > > new file

Re: [PATCH v4 2/6] dt: bindings: add mt7621-clk device tree binding documentation

2020-12-17 Thread Stephen Boyd
Quoting Sergio Paracuellos (2020-12-17 02:01:39) > > On Thu, Dec 17, 2020 at 9:58 AM Stephen Boyd wrote: > > > > Quoting Sergio Paracuellos (2020-11-22 01:55:52) > > > > > diff --git > > > a/Documentation/devicetree/bindings/clock/mediatek,mt7621-

Re: [PATCH v4 3/6] clk: ralink: add clock driver for mt7621 SoC

2020-12-17 Thread Stephen Boyd
Quoting Sergio Paracuellos (2020-11-22 01:55:53) > The documentation for this SOC only talks about two > registers regarding to the clocks: > * SYSC_REG_CPLL_CLKCFG0 - provides some information about > boostrapped refclock. PLL and dividers used for CPU and some > sort of BUS. > * SYSC_REG_CPLL_CLK

Re: [PATCH v4 2/6] dt: bindings: add mt7621-clk device tree binding documentation

2020-12-17 Thread Stephen Boyd
Quoting Sergio Paracuellos (2020-11-22 01:55:52) > Adds device tree binding documentation for clocks in the > MT7621 SOC. > > Signed-off-by: Sergio Paracuellos > --- > .../bindings/clock/mediatek,mt7621-clk.yaml | 67 +++ > 1 file changed, 67 insertions(+) > create mode 100644

Re: [PATCH v7 0/7] clk: clk-wizard: clock-wizard: Driver updates

2020-12-15 Thread Stephen Boyd
Quoting Michal Simek (2020-12-15 01:13:46) > > Can you please take a look at this series? > I did, see https://lore.kernel.org/r/16078386.1580929.1950826106627397...@swboyd.mtv.corp.google.com ___ devel mailing list de...@linuxdriverproject.org ht

Re: [GIT PULL] Staging/IIO driver changes for 5.11-rc1

2020-12-15 Thread Stephen Rothwell
-- Cheers, Stephen Rothwell pgp7wygbVYpNc.pgp Description: OpenPGP digital signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v7 0/7] clk: clk-wizard: clock-wizard: Driver updates

2020-12-12 Thread Stephen Boyd
Quoting Shubhrajyoti Datta (2020-11-04 07:06:40) > > Shubhrajyoti Datta (7): > dt-bindings: add documentation of xilinx clocking wizard Any chance to respond to Robs comments? > clk: clock-wizard: Add the clockwizard to clk directory Is it called 'wizard' anywhere in the documentation? I wo

Re: [PATCH v6 01/11] firmware: raspberrypi: Keep count of all consumers

2020-12-12 Thread Stephen Boyd
uce rpi_firmware_put() > which will permit automatically decrease the reference count upon > unbinding consumer drivers. > > Suggested-by: Uwe Kleine-König > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli > > --- Reviewed-by: Stephen Boyd _

Re: [PATCH v6 03/11] clk: bcm: rpi: Release firmware handle on unbind

2020-12-12 Thread Stephen Boyd
Quoting Nicolas Saenz Julienne (2020-12-11 08:47:52) > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli > ---

Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2020-11-25 06:15:05) > On Tue, Nov 24, 2020 at 04:11:31PM -0800, Stephen Boyd wrote: > > > > Ok so this patch isn't necessary then? > > For this particular build failure - it is not necessary anymore. > > However there might more of s

Re: [RFC 3/3] media: atomisp: do not select COMMON_CLK to fix builds

2020-11-24 Thread Stephen Boyd
was enabled. Now that isn't necessary and any user-selectable options should be moved to depends syntax. Reviewed-by: Stephen Boyd ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-24 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2020-11-17 23:48:12) > On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > > multiple other

Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-17 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > COMMON_CLK even though is a user-selectable symbol, is still selected by > multiple other config options. COMMON_CLK should not be used when > legacy clocks are provided by architecture, so it correctly depends on > !HAVE_LEGACY_CLK. > > However

Re: [PATCH 1/2] MAINTAINERS: fix broken doc refs due to yaml conversion

2020-10-12 Thread Stephen Boyd
Quoting Mauro Carvalho Chehab (2020-10-09 05:15:30) > Several *.txt files got converted to yaml. Update their > references at MAINTAINERS file accordingly. > > Signed-off-by: Mauro Carvalho Chehab > --- Acked-by: Stephen Boyd ___ dev

RE: [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-10-07 Thread Stephen Boyd
Quoting Shubhrajyoti Datta (2020-09-23 23:23:11) > > > -Original Message- > > From: Stephen Boyd > > Sent: Tuesday, September 22, 2020 2:48 AM > > > +} > > > + > > > +static long clk_wzrd_round_

Re: [PATCH v6 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

2020-09-21 Thread Stephen Boyd
Quoting Shubhrajyoti Datta (2020-08-28 06:39:52) > The patch adds support for dynamic reconfiguration of clock output rate. > Output clocks are registered as dividers and set rate callback function > is used for dynamic reconfiguration. > > Based on the initial work from Chirag. > > Signed-off-by

Re: [PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-09-21 Thread Stephen Boyd
Quoting Stephen Boyd (2020-09-21 14:19:59) > Quoting Shubhrajyoti Datta (2020-08-28 06:39:50) > > Add clocking wizard driver to clk. > > > > Signed-off-by: Shubhrajyoti Datta > > --- > > Can this be combined with p

Re: [PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-09-21 Thread Stephen Boyd
Quoting Shubhrajyoti Datta (2020-08-28 06:39:50) > Add clocking wizard driver to clk. > > Signed-off-by: Shubhrajyoti Datta > --- Can this be combined with patch #6? And then use git format-patch -C -M when generating patches? I'm trying to see if anything changed from the file in the staging tr

Re: [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-09-21 Thread Stephen Boyd
Quoting Shubhrajyoti Datta (2020-08-28 06:39:53) > Currently the set rate granularity is to integral divisors. > Add support for the fractional divisors. > Only the first output0 is fractional in the hardware. > > Signed-off-by: Shubhrajyoti Datta Getting closer. > diff --git a/drivers/clk/clk-

Re: [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

2020-07-11 Thread Stephen Boyd
Quoting David Gow (2020-06-29 21:45:17) > The Xilinx Clocking Wizard driver uses the devm_ioremap_resource > function, but does not specify a dependency on IOMEM in Kconfig. This > causes a build failure on architectures without IOMEM, for example, UML > (notably with make allyesconfig). > > Fix t

Re: mmotm 2020-03-28-22-17 uploaded (staging/octeon/)

2020-03-29 Thread Stephen Rothwell
. > > > Looks like it should be this change: > > - skb_reset_tc(skb); > + skb_reset_redirect(skb); I applied the above as a merge resolution patch for the staging tree merge today, as the inline removal was a late change to Linus' tree. -- Cheers, Stephen Roth

Re: [PATCH v3 05/11] media: adv748x: add support for HDMI audio

2020-03-20 Thread Stephen Boyd
Quoting Alex Riesen (2020-03-20 09:12:00) > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c > b/drivers/media/i2c/adv748x/adv748x-dai.c > new file mode 100644 > index ..6fce7d000423 > --- /dev/null > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > @@ -0,0 +1,265 @@ > +// SPDX-Lice

REF

2020-03-17 Thread Stephen Li
more details. Your swift response is highly needed. Sincerely Stephen Li Please response back to me with is my private email below for more details stephli947...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http

REF

2020-03-17 Thread Stephen Li
more details. Your swift response is highly needed. Sincerely Stephen Li Please response back to me with is my private email below for more details stephli947...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH v3 07/10] clk: clock-wizard: Update the fixed factor divisors

2020-01-05 Thread Stephen Boyd
Quoting Shubhrajyoti Datta (2020-01-05 20:17:16) > On Mon, Jan 6, 2020 at 1:30 AM Stephen Boyd wrote: > > > > Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:14) > > > From: Shubhrajyoti Datta > > > > > > Update the fixed factor c

Re: [PATCH v3 07/10] clk: clock-wizard: Update the fixed factor divisors

2020-01-05 Thread Stephen Boyd
Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:14) > From: Shubhrajyoti Datta > > Update the fixed factor clock registration to register the divisors. > > Signed-off-by: Shubhrajyoti Datta > --- > drivers/clk/clk-xlnx-clock-wizard.c | 17 +++-- > 1 file changed, 11 insertio

Re: [PATCH v3 06/10] clk: clock-wizard: Remove the hardcoding of the clock outputs

2020-01-05 Thread Stephen Boyd
Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:13) > diff --git a/drivers/clk/clk-xlnx-clock-wizard.c > b/drivers/clk/clk-xlnx-clock-wizard.c > index bc0354a..4c6155b 100644 > --- a/drivers/clk/clk-xlnx-clock-wizard.c > +++ b/drivers/clk/clk-xlnx-clock-wizard.c > @@ -493,6 +493,7 @@ static

Re: [PATCH v3 04/10] clk: clock-wizard: Add support for dynamic reconfiguration

2020-01-05 Thread Stephen Boyd
Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:11) > From: Shubhrajyoti Datta > > The patch adds support for dynamic reconfiguration of clock output rate. > Output clocks are registered as dividers and set rate callback function > is used for dynamic reconfiguration. > > Based on the ini

Re: [PATCH v3 03/10] clk: clock-wizard: Fix kernel-doc warning

2020-01-05 Thread Stephen Boyd
Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:10) > From: Shubhrajyoti Datta > > Update description for the clocking wizard structure > > Signed-off-by: Shubhrajyoti Datta > --- Reviewed-by: Stephen Boyd ___ dev

Re: [PATCH v3 10/10] clk: clock-wizard: Fix the compilation failure

2020-01-05 Thread Stephen Boyd
Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:17) > From: Shubhrajyoti Datta > > After 90b6c5c73 (clk: Remove CLK_IS_BASIC clk flag) > The CLK_IS_BASIC is deleted. Adapt the driver for the same. I don't see any CLK_IS_BASIC in the tree right now, so did it get reintroduced by this patch

Re: [PATCH v3 09/10] staging: clocking-wizard: Delete the driver from the staging

2020-01-05 Thread Stephen Boyd
Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:16) > From: Shubhrajyoti Datta > > Delete the driver from the staging as it is in drivers/clk. > > Signed-off-by: Shubhrajyoti Datta Can all these patches in this series apply to the staging paths and be picked up by Greg? Then when the dr

[PATCH v2] staging: rtl8192u: Fix indentation

2019-08-27 Thread Stephen Brennan
Checkpatch reports WARNING:SUSPECT_CODE_INDENT in several places. Fix this by aligning code properly with tabs. Signed-off-by: Stephen Brennan --- Changes in v2: rebase on next-20190827, fixing conflict with spacing fixes. .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +- .../staging

[PATCH] staging: rtl8192u: remove code under TO_DO_LIST

2019-08-23 Thread Stephen Brennan
Several blocks of code are guarded by #ifdef TO_DO_LIST. If this is defined, compilation fails. No machinery exists to define this, and no documenation on the in-progress feature exists. Since this code is dead, let's delete it. Signed-off-by: Stephen Brennan --- Sorry, I know you'r

rtl8192u - meaning of TO_DO_LIST?

2019-08-22 Thread stephen
is. Does anybody know what this is there for? If not, does it make sense to just go ahead and remove the code there? Stephen ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192u: Fix indentation

2019-08-22 Thread Stephen Brennan
Checkpatch reports WARNING:SUSPECT_CODE_INDENT in several places. Fix this by aligning code properly with tabs. Signed-off-by: Stephen Brennan --- .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +- .../staging/rtl8192u/ieee80211/ieee80211_rx.c | 112 +- .../staging/rtl8192u

Re: Added Realtek rtl8192u driver to staging - static analysis report.

2019-08-21 Thread stephen
> > Either way, it's not clear to me and I think the code needs cleaning > > up. > > Any ideas? > > 10+ year old code, yeah!!! > > Just guess, who knows, no one seems to care :( I'm at least interested in helping with cleaning the code and learning about the driver, maybe fixing up logical err

[PATCH v2 2/3] staging: rtl8192u: fix macro alignment in ieee80211

2019-08-21 Thread Stephen Brennan
Several macros display unaligned, due to mixes of tabs and spaces. These can be fixed by making spacing consistent, do this. Signed-off-by: Stephen Brennan --- .../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++- .../staging/rtl8192u/ieee80211/rtl819x_HT.h | 8 ++--- 2

[PATCH v2 0/3] staging: rtl8192u: coding style fixes in ieee80211

2019-08-21 Thread Stephen Brennan
Addressed some spacing, brace placement, and macro alignment in this driver. I do not have the relevant hardware, but I verified that the drivers/staging/rtl8192u module built between each patch. This time I've included proper patch descriptions, my apologies for the previous series. St

[PATCH v2 3/3] staging: rtl8192u: fix spacing in ieee80211

2019-08-21 Thread Stephen Brennan
Checkpatch emits several errors, warnings, and checks about spacing. Apply checkpatch's suggested spacing rules. Signed-off-by: Stephen Brennan --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++-- .../staging/rtl8192u/ieee80211/ieee80211.h| 4 +- .../rtl8192u/ieee

[PATCH v2 1/3] staging: rtl8192u: fix OPEN_BRACE errors in ieee80211

2019-08-21 Thread Stephen Brennan
Checkpatch emits several errors regarding braces being on the incorrect line. These can be fixed by moving the brace, do this. In a few cases, some comments were moved to facilitate this. Signed-off-by: Stephen Brennan --- .../staging/rtl8192u/ieee80211/ieee80211.h| 3 +- .../staging

[PATCH 2/3] staging: rtl8192u: fix macro alignment in ieee80211

2019-08-20 Thread Stephen Brennan
Signed-off-by: Stephen Brennan --- .../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++- .../staging/rtl8192u/ieee80211/rtl819x_HT.h | 8 ++--- 2 files changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging

[PATCH 1/3] staging: rtl8192u: fix OPEN_BRACE errors in ieee80211

2019-08-20 Thread Stephen Brennan
Signed-off-by: Stephen Brennan --- .../staging/rtl8192u/ieee80211/ieee80211.h| 3 +- .../staging/rtl8192u/ieee80211/ieee80211_rx.c | 116 ++ .../staging/rtl8192u/ieee80211/ieee80211_tx.c | 81 +--- .../staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 +- .../staging

[PATCH 0/3] staging: rtl8192u: coding style fixes in ieee80211

2019-08-20 Thread Stephen Brennan
Addressed some spacing, brace placement, and macro alignment in this driver. I do not have the relevent hardware, but I verified that the drivers/staging/rtl8192u module built between each patch. Stephen Brennan (3): staging: rtl8192u: fix OPEN_BRACE errors in ieee80211 staging: rtl8192u: fix

[PATCH 3/3] staging: rtl8192u: fix spacing in ieee80211

2019-08-20 Thread Stephen Brennan
Signed-off-by: Stephen Brennan --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++-- .../staging/rtl8192u/ieee80211/ieee80211.h| 4 +- .../rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22 .../rtl8192u/ieee80211

[PATCH] staging: rtl8192u: fix spacing errors

2019-08-11 Thread Stephen Brennan
Used checkpatch's --fix-inplace option for types SPACING, OPEN_BRACE, ELSE_AFTER_BRACE. Manually edited the resulting changes to correct for mistaken fixes and complete fixes that were only partially applied. Signed-off-by: Stephen Brennan --- To prevent this patch from getting even longe

Re: [PATCH RFC] erofs: move erofs out of staging

2019-08-06 Thread Stephen Rothwell
Hi Gao, On Wed, 7 Aug 2019 01:02:58 +0800 Gao Xiang wrote: > > On Wed, Aug 07, 2019 at 01:34:23AM +1000, Stephen Rothwell wrote: > > > > One small suggestion: just remove the file names from the comments at > > the top of the files rather than change them to reflect

Re: [PATCH RFC] erofs: move erofs out of staging

2019-08-06 Thread Stephen Rothwell
Hi Gao, One small suggestion: just remove the file names from the comments at the top of the files rather than change them to reflect that they have moved. We can usually tell the name of a file by its name :-) -- Cheers, Stephen Rothwell pgpeto9QVOyjN.pgp Description: OpenPGP digital

Re: [PATCH] isdn: hysdn: fix code style error from checkpatch

2019-08-02 Thread Stephen Hemminger
On Fri, 2 Aug 2019 19:50:17 + Ricardo Bruno Lopes da Silva wrote: > Fix error bellow from checkpatch. > > WARNING: Block comments use * on subsequent lines > +/*** > + > > Signed-off-by: Ricardo Bruno Lopes da Silva Read the TODO, t

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

2019-08-02 Thread Stephen Hemminger
On Fri, 2 Aug 2019 19:56:02 + Jose Carlos Cazarin Filho wrote: > Fix checkpath error: > CHECK: spaces preferred around that '*' (ctx:WxV) > +extern hysdn_card *card_root;/* pointer to first card */ > > Signed-off-by: Jose Carlos Cazarin Filho Read the TODO, these drivers are sche

[PATCH v6 42/57] staging: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Stephen Boyd
Kroah-Hartman Cc: de...@driverdev.osuosl.org Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/staging/emxx_udc/emxx_udc.c | 4 +--- drivers/staging/goldfish/goldfish_audio.c| 4 +--- drivers/staging/media/alleg

Re: [PATCH 3/5] dt: bindings: add mt7621-pll dt binding documentation

2019-07-22 Thread Stephen Boyd
Quoting Chuanhong Guo (2019-07-09 11:20:16) > This commit adds device tree binding documentation for MT7621 > PLL controller. > > Signed-off-by: Chuanhong Guo > --- > .../bindings/clock/mediatek,mt7621-pll.txt| 19 +++ > 1 file changed, 19 insertions(+) > create mode 100644

Re: [PATCH 2/5] MIPS: ralink: fix cpu clock of mt7621 and add dt clk devices

2019-07-22 Thread Stephen Boyd
Quoting Chuanhong Guo (2019-07-09 11:20:15) > For a long time the mt7621 uses a fixed cpu clock which causes a problem > if the cpu frequency is not 880MHz. > > This patch fixes the cpu clock calculation and adds the cpu/bus clkdev > which will be used in dts. > > Ported from OpenWrt: > c7ca22429

Re: [PATCH 1/5] MIPS: ralink: add dt binding header for mt7621-pll

2019-07-22 Thread Stephen Boyd
The subject of this patch is confusing. Not sure what it has to do with "MIPS:" so maybe remove that and prefix it "dt-bindings: clock:" instead. Quoting Chuanhong Guo (2019-07-09 11:20:14) > This patch adds dt binding header for mediatek,mt7621-pll > > Signed-off-by: Weijie Gao > Signed-off-by:

Re: [PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Stephen Rothwell
r: GPL-2.0 OR Apache-2.0 */ I think the preferred tag is now GPL-2.0-only (assuming that is what is intended). -- Cheers, Stephen Rothwell pgpGO1xuMQjKg.pgp Description: OpenPGP digital signature ___ devel mailing list de...@lin

Re: [PATCH 0/3] pci-hyperv: fix memory leak and add pci_destroy_slot()

2019-03-05 Thread Stephen Hemminger
/pci/controller/pci-hyperv.c | 23 +++ > 1 file changed, 23 insertions(+) Thanks for fixing this. Reviewed-by: Stephen Hemminger ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH V3 1/10] X86/Hyper-V: Add parameter offset for hyperv_fill_flush_guest_mapping_list()

2019-02-22 Thread Stephen Hemminger
int hyperv_fill_flush_guest_mapping_list( struct hv_guest_mapping_flush_list *flush, - u64 start_gfn, u64 pages) + int offset, u64 start_gfn, u64 pages) { u64 cur = start_gfn; u64 additional_pages; - int gpa_n = 0; + int gpa_n

staging: rtl8188eu: fix bad indentation for conditional statement

2019-02-18 Thread Stephen Martin
Fixed else block indentation Signed-off-by: Stephen Martin --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c index 3b1ccd138c3f..1723a47a96b4

Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-14 Thread Stephen Hemminger
On Thu, 14 Feb 2019 01:11:03 -0500 Kimberly Brown wrote: > On Mon, Feb 11, 2019 at 10:02:47AM -0800, Stephen Hemminger wrote: > > On Mon, 11 Feb 2019 02:01:18 -0500 > > Kimberly Brown wrote: > > > > > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger

Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-11 Thread Stephen Hemminger
On Mon, 11 Feb 2019 02:01:18 -0500 Kimberly Brown wrote: > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote: > > On Fri, 8 Feb 2019 05:01:12 -0500 > > Kimberly Brown wrote: > > > > You are right, the current behavior is broken. > > It woul

Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-08 Thread Stephen Hemminger
On Fri, 8 Feb 2019 05:01:12 -0500 Kimberly Brown wrote: You are right, the current behavior is broken. It would be good to add a description of under what conditions monitor is not used. Is this some part of a project emulating Hyper-V? > + > + if (!hv_dev->channel->offermsg.monitor_allocat

Re: [PATCH 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0

2019-02-08 Thread Stephen Hemminger
vmbus_connection.monitor_pages[0])); > } > static DEVICE_ATTR_RO(server_monitor_pending); Looks good. I wonder if ever gets used though since it returned incorrect data... Acked-by: Stephen Hemminger ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] PCI: hv: Add hv_pci_remove_slots() when we unload the driver

2019-02-07 Thread Stephen Hemminger
("PCI: hv: support reporting serial number as slot > information") > Signed-off-by: Dexuan Cui > Cc: sta...@vger.kernel.org > Cc: Stephen Hemminger Acked-by: Stephen Hemminger ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference

2019-01-24 Thread Stephen Boyd
Quoting Jonathan Cameron (2018-12-16 02:07:41) > Rob, Clk experts, questions for you below. > > Jonathan > > > On Thu, 13 Dec 2018 17:39:22 -0800 > Stephen Boyd wrote: > > > Quoting Jonathan Cameron (2018-12-08 07:29:54) > > > On Thu, 6 Dec 2018 11:1

[PATCH] staging: rtw_ieee80211: fix constant comparison warning

2019-01-23 Thread Stephen Martin
Fixed comparison on right side of test warnings. Signed-off-by: Stephen Martin --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/core

Re: [PATCH v3] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-17 Thread Stephen Hemminger
> +static ssize_t channel_intr_in_full_show(const struct vmbus_channel > *channel, > + char *buf) > +{ > + return sprintf(buf, "%llu\n", channel->intr_in_full); > +} intr_in_full is u64, which is not the same as unsigned long long. to be correct you nee

Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

2018-12-17 Thread Stephen Hemminger
On Mon, 17 Dec 2018 18:44:12 + Dexuan Cui wrote: > > From: devel On Behalf Of > > Dexuan Cui > > Sent: Monday, December 17, 2018 10:31 AM > > > From: Stephen Hemminger > > > > > > The old code was risky because it would silently return

Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

2018-12-17 Thread Stephen Hemminger
On Mon, 17 Dec 2018 18:00:29 + Dexuan Cui wrote: > > From: Stephen Hemminger > > On Thu, 13 Dec 2018 16:35:43 + > > Dexuan Cui wrote: > > > > > Before 98f4c651762c, we returned zeros for unopened channels. > > > With 98f4c651762c, w

Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

2018-12-17 Thread Stephen Hemminger
ringbuffer bus attributes to dev_groups") > Cc: sta...@vger.kernel.org > Cc: K. Y. Srinivasan > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Signed-off-by: Dexuan Cui The concept looks fine, but maybe it would be simpler to move it into hv_ringbuffer_get_debuginfo and have it ret

Re: [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference

2018-12-13 Thread Stephen Boyd
Quoting Jonathan Cameron (2018-12-08 07:29:54) > On Thu, 6 Dec 2018 11:10:51 +0200 > Mircea Caprioru wrote: > > > This patch adds a clock to the state structure of ad7192 for getting the > > external clock frequency. This modifications is in accordance with clock > > framework dt bindings documen

[PATCH] uio_hv_generic: set callbacks on open

2018-12-10 Thread Stephen Hemminger
eported-by: Mohammed Gamal Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index c2493d011225..3c5169eb23f5 100644 --- a/drivers/uio/uio_hv_gener

[PATCH] vmbus: fix subchannel removal

2018-12-07 Thread Stephen Hemminger
nd is processed. Fixes: ae6935ed7d42 ("vmbus: split ring buffer allocation from open") Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index fe00b12e441

[PATCH] hyperv: replace mutex_is_locked with lockdep

2018-12-07 Thread Stephen Hemminger
lockdep_assert_held is better at checking for locking requirements since it doesn't get confused if someone else is holding the mutex. Inspired by changes in network drivers by Lance Roy. Signed-off-by: Stephen Hemminger --- drivers/hv/channel_mgmt.c | 2 +- drivers/hv/connection.c | 2

Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2018-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2018 15:32:35 + Michael Kelley wrote: > From Olaf Hering Sent: Thursday, October 18, 2018 8:20 AM > > > > > This extends existing vmbus related sysfs structure to provide per-channel > > > state information. This is useful when diagnosing issues with multiple > > > queues in

Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2018-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2018 17:19:53 +0200 Olaf Hering wrote: > Am Sun, 17 Sep 2017 20:54:18 -0700 > schrieb k...@exchange.microsoft.com: > > > This extends existing vmbus related sysfs structure to provide per-channel > > state information. This is useful when diagnosing issues with multiple > > queues

Re: [PATCH net-next, v3] hv_netvsc: fix vf serial matching with pci slot info

2018-10-15 Thread Stephen Hemminger
paired with synthetic > NIC. > > Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number") > Reported-by: Vitaly Kuznetsov > Signed-off-by: Haiyang Zhang Reviewed-by: Stephen Hemminger ___ devel mailing list de...@linuxdriv

Re: [PATCH net-next, v2] hv_netvsc: fix vf serial matching with pci slot info

2018-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2018 20:55:15 + Haiyang Zhang wrote: Thanks for fixing this. > + if (kstrtou32(kobject_name(&pdev->slot->kobj), 10, &serial)) { > + netdev_notice(vf_netdev, "Invalid vf serial:%s\n", > + pdev->slot->kobj.name); > + retur

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

2018-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2018 10:57:05 +0200 Mohammed Gamal wrote: > On Wed, 2018-09-26 at 17:13 +, Haiyang Zhang wrote: > > > -Original Message- > > > From: Mohammed Gamal > > > Sent: Wednesday, September 26, 2018 12:34 PM > > > To: Stephen Hemminger ;

Re: [PATCH net-next] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2018 18:25:10 +0800 YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_

Re: leaking path in android binder: set_nice

2018-09-25 Thread Stephen Smalley
On 09/25/2018 01:27 PM, Tong Zhang wrote: Kernel Version: 4.18.5 Problem Description: When setting nice value, it is checked by LSM function security_task_setnice(). see kernel/sched/core.c:3972 SYSCALL_DEFINE1(nice, int, increment) We discovered a leaking path in android binder which allows u

Re: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Stephen Hemminger
On Fri, 21 Sep 2018 18:51:54 + Haiyang Zhang wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, September 21, 2018 2:37 PM > > To: Haiyang Zhang > > Cc: Haiyang Zhang ; da...@davemloft.net; > > net...@vger.k

Re: [PATCH net-next, v2, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-21 Thread Stephen Hemminger
On Fri, 21 Sep 2018 18:20:35 + Haiyang Zhang wrote: Overall, this looks good. Some minor suggestions. > +struct nvsc_rsc { > + const struct ndis_pkt_8021q_info *vlan; > + const struct ndis_tcp_ip_checksum_info *csum_info; > + u8 is_last; /* last RNDIS msg in a vmtransfer_page */

Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2018 20:56:46 + Haiyang Zhang wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, September 20, 2018 4:48 PM > > To: Haiyang Zhang > > Cc: Haiyang Zhang ; da...@davemloft.net; > > net...@vger.k

Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch

2018-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2018 17:06:59 + Haiyang Zhang wrote: > +static inline void rsc_add_data > + (struct netvsc_channel *nvchan, > + const struct ndis_pkt_8021q_info *vlan, > + const struct ndis_tcp_ip_checksum_info *csum_info, > + void *data, u32 len) > +{ Could this be changed

  1   2   3   4   5   6   7   8   >