Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-06-03 Thread pmarzo
On mar, 2015-06-02 at 22:40 +0900, Greg KH wrote: > On Tue, Jun 02, 2015 at 03:35:05PM +0200, pmarzo wrote: > > Ok, I will download your staging tree and regenerate patches 1/3 and 2/3 > > with that git tree. That would be v5 1/2 and 2/2 new patches. > > Just one (probably

Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-06-02 Thread pmarzo
On mar, 2015-06-02 at 17:25 +0900, Greg KH wrote: > On Tue, Jun 02, 2015 at 10:08:19AM +0200, pmarzo wrote: > > On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote: > > > On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote: > > > > On Sun, 2015-05-31 at 10:39 +0900, G

Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-06-02 Thread pmarzo
On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote: > On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote: > > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote: > > > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote: > > > > Remove two lin

Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-06-01 Thread pmarzo
On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote: > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote: > > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as > > errors. > > The first one because it has a C99 comment style and the second one because > > it is a

Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init

2015-05-20 Thread pmarzo
On miƩ, 2015-05-20 at 00:46 +0300, Dan Carpenter wrote: > I was planning to leave this one for Greg but since you asked me to > comment... > > This patch is ok as one patch. The subject is "clean up > prism2_wep_init()" and that's one thing. Breaking it up into tiny > patches would probably make

Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init

2015-05-19 Thread pmarzo
On Tue, 2015-05-19 at 11:04 +0530, Sudip Mukherjee wrote: > On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote: > > Merge two pr_debug lines with literal strings splitted across several lines > > into one single line, simplifying prism2_wep_init error check code. > > I would have sp

Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread pmarzo
On Tue, 2015-05-19 at 00:06 +0300, Dan Carpenter wrote: > On Mon, May 18, 2015 at 11:56:08PM +0200, pmarzo wrote: > > On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote: > > > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > > > Merge t

Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread pmarzo
On Mon, 2015-05-18 at 13:04 -0700, Joe Perches wrote: > On Mon, 2015-05-18 at 23:56 +0200, pmarzo wrote: > > On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote: > > > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > > > Merge two pr_de

Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread pmarzo
On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote: > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > Merge two pr_debug lines with literal strings splitted across several lines > > into one single line, simplifying prism2_wep_init error check code. > > Openning braces sh

Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread pmarzo
On Mon, 2015-05-18 at 21:53 +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > Merge two pr_debug lines with literal strings splitted across several lines > > into one single line, simplifying prism2_wep_init error check code. > > Openning braces

Re: [PATCH] Fixed coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread pmarzo
On Mon, 2015-05-18 at 11:33 +0300, Dan Carpenter wrote: > Also the use a subsystem prefix in the subject: > > [PATCH] Staging: rtl8192u: whatever... > > > regards, > dan carpenter > Thanku for your comments, I will send an v2 patch version regards, Pedro __