Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-18 Thread Nicolas Dufresne
plitely > > > > setting this control, then perhaps this should be part of the standard > > > > HEVC API. > > > > Non-hantro drivers that do not need this can just skip it. > > > > > > Even if I put this parameter in decode_params structure that

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-06 Thread Nicolas Dufresne
Le jeudi 06 mai 2021 à 14:11 +0100, John Cox a écrit : > > On 05/05/2021 17:20, Benjamin Gaignard wrote: > > > > > > Le 05/05/2021 à 16:55, Hans Verkuil a écrit : > > > > On 20/04/2021 14:10, Benjamin Gaignard wrote: > > > > > The HEVC HANTRO driver needs to know the number of bits to skip at > >

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

2021-05-05 Thread Nicolas Dufresne
n aligned with how it works inside the codec, without having to do a translation dance, and then properly implement CAPTURE TRY_FMT base on that. To make an analogy with stateful codec, this replaces the queuing of a frame that contains codec headers. We skip the SRC_CH events, since this is no long

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-05 Thread Nicolas Dufresne
Le mercredi 05 mai 2021 à 16:18 +0100, John Cox a écrit : > > The HEVC HANTRO driver needs to know the number of bits to skip at > > the beginning of the slice header. > > That is a hardware specific requirement so create a dedicated control > > for this purpose. > > > > Signed-off-by: Benjamin Ga

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-29 Thread Nicolas Dufresne
Le jeudi 29 avril 2021 à 11:23 +0200, Hans Verkuil a écrit : > On 27/04/2021 01:34, Ezequiel Garcia wrote: > > On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne wrote: > > > > > > Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : > > > > Hi Andrzej,

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-26 Thread Nicolas Dufresne
Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : > Hi Andrzej, > > Thank you for working on this! > > On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: > > Dear All, > > > > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is > > based on https://lkml.org/lkml/

Re: [PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-15 Thread Nicolas Saenz Julienne
Hi Uwe, On Fri, 2021-03-12 at 21:12 +0100, Uwe Kleine-König wrote: > Hello Nicolas, > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright 2020 Nicolas Saenz Julienne > > 2021? Yes. > > + * For more information on Raspberry Pi's PoE hat se

[PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-12 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v7: - Remove unwarranted RPI_PWM_DE

[PATCH v8 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2021-03-12 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v4: - Rename compatible string to be more explicit with the bus' limitations Changes s

[PATCH v8 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2021-03-12 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm

[PATCH v8 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2021-03-12 Thread Nicolas Saenz Julienne
There is no use for the firmware interface after getting the touch buffer address, so release it. Signed-off-by: Nicolas Saenz Julienne Acked-by: Dmitry Torokhov Reviewed-by: Florian Fainelli --- Changes since v5: - Correct commit message Changes since v3: - Release firmware handle in

[PATCH v8 07/11] staging: vchiq: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Greg Kroah-Hartman --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1

[PATCH v8 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v8 05/11] reset: raspberrypi: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/reset/reset-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v8 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Bartosz Golaszewski --- drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file changed, 1 insertion(

[PATCH v8 03/11] clk: bcm: rpi: Release firmware handle on unbind

2021-03-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Stephen Boyd drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v8 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2021-03-12 Thread Nicolas Saenz Julienne
It'll simplify the firmware handling for most consumers. Suggested-by: Bartosz Golaszewski Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Bartosz Golaszewski --- Changes since v4: - Rearrange function calls for clarity, same functionality Changes sin

[PATCH v8 00/11] Raspberry Pi PoE HAT fan support

2021-03-12 Thread Nicolas Saenz Julienne
e PoE HAT Changes since v3: - Split first patch, #1 introduces refcount, then #2 the devm function - Fix touchscreen function - Use kref Changes since v2: - Introduce devm_rpi_firmware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix binding, now

[PATCH v8 01/11] firmware: raspberrypi: Keep count of all consumers

2021-03-12 Thread Nicolas Saenz Julienne
upon unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Stephen Boyd Reviewed-by: Bartosz Golaszewski --- Changes since v5: - Add comment to avoid people blindly switching the memory allocation to the

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-11 Thread Nicolas Saenz Julienne
On Thu, 2021-03-11 at 14:18 +0100, Uwe Kleine-König wrote: > Hello Nicolas, > > On Thu, Mar 11, 2021 at 02:01:00PM +0100, Nicolas Saenz Julienne wrote: > > On Wed, 2021-03-10 at 12:50 +0100, Uwe Kleine-König wrote: > > > On Mon, Jan 18, 2021 at 01:32:44PM +0100, Nico

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-11 Thread Nicolas Saenz Julienne
Hi Uwe, thanks for taking the time to look into this. :) On Wed, 2021-03-10 at 12:50 +0100, Uwe Kleine-König wrote: > Hello Nicolas, > > On Mon, Jan 18, 2021 at 01:32:44PM +0100, Nicolas Saenz Julienne wrote: [...] > > + /* > > +* This sets the default duty cycl

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-09 Thread Nicolas Saenz Julienne
On Mon, 2021-01-18 at 13:32 +0100, Nicolas Saenz Julienne wrote: > Adds support to control the PWM bus available in official Raspberry Pi > PoE HAT. Only RPi's co-processor has access to it, so commands have to > be sent through RPi's firmware mailbox interface. > > Sig

Re: [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-02-08 Thread Nicolas Saenz Julienne
On Mon, 2021-01-18 at 13:32 +0100, Nicolas Saenz Julienne wrote: > Adds support to control the PWM bus available in official Raspberry Pi > PoE HAT. Only RPi's co-processor has access to it, so commands have to > be sent through RPi's firmware mailbox interface. > > Sig

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 202

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > Hi Xin, > > Thanks for the patch. > > On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > > > Enable DSI EOTP feature for fixing some panel screen constance > > shift issue. > > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > > I

[PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-01-18 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v6: - Use %pe - Round divisions prop

[PATCH v7 07/11] staging: vchiq: Release firmware handle on unbind

2021-01-18 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v7 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2021-01-18 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v4: - Rename compatible string to be more explicit with the bus' limitations Changes s

[PATCH v7 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2021-01-18 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v7 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2021-01-18 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm

[PATCH v7 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2021-01-18 Thread Nicolas Saenz Julienne
There is no use for the firmware interface after getting the touch buffer address, so release it. Signed-off-by: Nicolas Saenz Julienne Acked-by: Dmitry Torokhov Reviewed-by: Florian Fainelli --- Changes since v5: - Correct commit message Changes since v3: - Release firmware handle in

[PATCH v7 05/11] reset: raspberrypi: Release firmware handle on unbind

2021-01-18 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/reset/reset-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v7 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2021-01-18 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Bartosz Golaszewski --- drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file changed, 1 insertion(

[PATCH v7 00/11] Raspberry Pi PoE HAT fan support

2021-01-18 Thread Nicolas Saenz Julienne
refcount, then #2 the devm function - Fix touchscreen function - Use kref Changes since v2: - Introduce devm_rpi_firmware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix binding, now with 2 cells Nicolas Saenz Julienne (11): firmware: raspberrypi: Keep

[PATCH v7 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2021-01-18 Thread Nicolas Saenz Julienne
It'll simplify the firmware handling for most consumers. Suggested-by: Bartosz Golaszewski Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Bartosz Golaszewski --- Changes since v4: - Rearrange function calls for clarity, same functionality Changes sin

[PATCH v7 03/11] clk: bcm: rpi: Release firmware handle on unbind

2021-01-18 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Stephen Boyd drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v7 01/11] firmware: raspberrypi: Keep count of all consumers

2021-01-18 Thread Nicolas Saenz Julienne
upon unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Reviewed-by: Stephen Boyd Reviewed-by: Bartosz Golaszewski --- Changes since v5: - Add comment to avoid people blindly switching the memory allocation to the

Re: [PATCH v6 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-01-14 Thread Nicolas Saenz Julienne
uty cycle: %d\n", > > ret); > > + return ret; > > + } > > + > > + rpipwm->duty_cycle = duty_cycle; > > Please use tabs for indention. (The general hint is to use checkpatch > which (I hope) tells you about problems like this.) S

Re: [PATCH v6 00/11] Raspberry Pi PoE HAT fan support

2021-01-11 Thread Nicolas Saenz Julienne
On Fri, 2020-12-11 at 17:47 +0100, Nicolas Saenz Julienne wrote: > The aim of this series is to add support to the fan found on RPi's PoE > HAT. Some commentary on the design can be found below. But the imporant > part to the people CC'd here not involved with PWM is that, in

Re: [PATCH v2 0/3] A trio of vchiq bulk transfer fixes

2021-01-11 Thread Nicolas Saenz Julienne
to the TODO > >  drivers/staging/vc04_services/interface/TODO| 4 >  .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 -- >  2 files changed, 8 insertions(+), 2 deletions(-) > Reviewed-by: Nicolas Saenz Julienne Regards,

Re: [PATCH v6 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-12-16 Thread Nicolas Saenz Julienne
On Wed, 2020-12-16 at 11:35 +0100, Bartosz Golaszewski wrote: > On Fri, Dec 11, 2020 at 5:48 PM Nicolas Saenz Julienne > wrote: > > > > It'll simplify the firmware handling for most consumers. > > > > Suggested-by: Bartosz Golaszewski > > Signed-off-by

[PATCH v6 07/11] staging: vchiq: Release firmware handle on unbind

2020-12-11 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v6 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2020-12-11 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v4: - Rename compatible string to be more explicit with the bus' limitations Changes s

[PATCH v6 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2020-12-11 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm

[PATCH v6 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-12-11 Thread Nicolas Saenz Julienne
There is no use for the firmware interface after getting the touch buffer address, so release it. Signed-off-by: Nicolas Saenz Julienne Acked-by: Dmitry Torokhov --- Changes since v5: - Correct commit message Changes since v3: - Release firmware handle in probe function Changes since v2

[PATCH v6 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2020-12-11 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v6 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2020-12-11 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Rename compatible string

[PATCH v6 03/11] clk: bcm: rpi: Release firmware handle on unbind

2020-12-11 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v6 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-12-11 Thread Nicolas Saenz Julienne
It'll simplify the firmware handling for most consumers. Suggested-by: Bartosz Golaszewski Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- Changes since v4: - Rearrange function calls for clarity, same functionality Changes since v2: - Create devm_rpi_firmwar

[PATCH v6 05/11] reset: raspberrypi: Release firmware handle on unbind

2020-12-11 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- drivers/reset/reset-raspberrypi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v6 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-12-11 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli Acked-by: Bartosz Golaszewski --- drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file changed, 1 insertion(

[PATCH v6 00/11] Raspberry Pi PoE HAT fan support

2020-12-11 Thread Nicolas Saenz Julienne
unction - Use kref Changes since v2: - Introduce devm_rpi_firmware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix binding, now with 2 cells Nicolas Saenz Julienne (11): firmware: raspberrypi: Keep count of all consumers firmware: raspberrypi: I

[PATCH v6 01/11] firmware: raspberrypi: Keep count of all consumers

2020-12-11 Thread Nicolas Saenz Julienne
upon unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli --- Changes since v5: - Add comment to avoid people blindly switching the memory allocation to the devm variant. - Fix function documentation as per Flor

Re: [PATCH v5 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2020-12-09 Thread Nicolas Saenz Julienne
Hi All, On Mon, 2020-11-23 at 19:38 +0100, Nicolas Saenz Julienne wrote: > Adds support to control the PWM bus available in official Raspberry Pi > PoE HAT. Only RPi's co-processor has access to it, so commands have to > be sent through RPi's firmware mailbox interface.

Re: [PATCH v5 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-12-03 Thread Nicolas Saenz Julienne
On Tue, 2020-12-01 at 22:03 -0800, Dmitry Torokhov wrote: > Hi Nicolas, > > On Mon, Nov 23, 2020 at 07:38:29PM +0100, Nicolas Saenz Julienne wrote: > > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > > interface when unbinding the device.

Re: [PATCH v5 01/11] firmware: raspberrypi: Keep count of all consumers

2020-12-03 Thread Nicolas Saenz Julienne
On Thu, 2020-12-03 at 09:05 +0100, Bartosz Golaszewski wrote: > On Mon, Nov 23, 2020 at 7:38 PM Nicolas Saenz Julienne > wrote: > > > > When unbinding the firmware device we need to make sure it has no > > consumers left. Otherwise we'd leave them with a firmware

[PATCH v5 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-11-23 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Release firmware handle in probe function Changes since v2: - Use devm_rpi_firmware_get(), instead of remove fun

[PATCH v5 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-11-23 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Acked-by: Bartosz Golaszewski --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/gpio/gpio-raspbe

[PATCH v5 05/11] reset: raspberrypi: Release firmware handle on unbind

2020-11-23 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/reset/reset-raspberrypi.c | 2 +- 1 file chang

[PATCH v5 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2020-11-23 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Rename compatible string

[PATCH v5 03/11] clk: bcm: rpi: Release firmware handle on unbind

2020-11-23 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file chang

[PATCH v5 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2020-11-23 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Update patch to use 2 pwm cells arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --

[PATCH v5 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2020-11-23 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v4: - Rename compatible string to be more explicit with the bus' limitations C

[PATCH v5 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2020-11-23 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file chang

[PATCH v5 01/11] firmware: raspberrypi: Keep count of all consumers

2020-11-23 Thread Nicolas Saenz Julienne
upon unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Use kref instead of waiting on refcount drivers/firmware/raspberrypi.c | 37 +++--- include/soc/bcm2835/raspberrypi-firmware.h | 2 ++ 2

[PATCH v5 07/11] staging: vchiq: Release firmware handle on unbind

2020-11-23 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/staging/vc04_services/interface/vchiq_arm/vchiq_

[PATCH v5 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-23 Thread Nicolas Saenz Julienne
It'll simplify the firmware handling for most consumers. Suggested-by: Bartosz Golaszewski Signed-off-by: Nicolas Saenz Julienne --- Changes since v4: - Rearrange function calls for clarity, same functionality Changes since v2: - Create devm_rpi_firmware_get() drivers/fir

[PATCH v5 00/11] Raspberry Pi PoE HAT fan support

2020-11-23 Thread Nicolas Saenz Julienne
mware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix binding, now with 2 cells Nicolas Saenz Julienne (11): firmware: raspberrypi: Keep count of all consumers firmware: raspberrypi: Introduce devm_rpi_firmware_get() clk: bcm: rpi: Release firmwar

Re: [PATCH v4 01/11] firmware: raspberrypi: Keep count of all consumers

2020-11-23 Thread Nicolas Saenz Julienne
On Thu, 2020-11-12 at 23:26 -0800, Dmitry Torokhov wrote: > On Thu, Nov 12, 2020 at 07:52:14PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 12, 2020 at 6:40 PM Nicolas Saenz Julienne > > wrote: > > > > > > When unbinding the firmware device we need to make su

Re: [PATCH v4 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-13 Thread Nicolas Saenz Julienne
On Thu, 2020-11-12 at 18:25 +0100, Bartosz Golaszewski wrote: > On Thu, Nov 12, 2020 at 5:44 PM Nicolas Saenz Julienne > wrote: > > Itroduce devm_rpi_firmware_get(), it'll simplify the firmware handling > > for most consumers. > > > > Suggested-by: Bartosz Gola

[PATCH v4 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2020-11-12 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v3: - Fix example Changes since v1: - Update bindings to use 2 #pwm-cells .../arm/bcm/r

[PATCH v4 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2020-11-12 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get()

[PATCH v4 07/11] staging: vchiq: Release firmware handle on unbind

2020-11-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/staging/vc04_services/interface/vchiq_arm/vchiq_

[PATCH v4 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-12 Thread Nicolas Saenz Julienne
Itroduce devm_rpi_firmware_get(), it'll simplify the firmware handling for most consumers. Suggested-by: Bartosz Golaszewski Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Introduce devm_rpi_firmware_get() drivers/firmware/raspberrypi.c

[PATCH v4 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2020-11-12 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Update patch to use 2 pwm cells arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --

[PATCH v4 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-11-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne Acked-by: Bartosz Golaszewski --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/gpio/gpio-raspbe

[PATCH v4 05/11] reset: raspberrypi: Release firmware handle on unbind

2020-11-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/reset/reset-raspberrypi.c | 2 +- 1 file chang

[PATCH v4 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2020-11-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file chang

[PATCH v4 03/11] clk: bcm: rpi: Release firmware handle on unbind

2020-11-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file chang

[PATCH v4 01/11] firmware: raspberrypi: Keep count of all consumers

2020-11-12 Thread Nicolas Saenz Julienne
upon unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Use kref instead of waiting on refcount drivers/firmware/raspberrypi.c | 37 +++--- include/soc/bcm2835/raspberrypi-firmware.h | 2 ++ 2

[PATCH v4 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-11-12 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Release firmware handle in probe function Changes since v2: - Use devm_rpi_firmware_get(), instead of remove fun

[PATCH v4 00/11] Raspberry Pi PoE HAT fan support

2020-11-12 Thread Nicolas Saenz Julienne
hernet-poe-hat/ --- Changes since v3: - Split first patch, #1 introduces refcount, then #2 the devm function - Fix touchscreen function - Use kref Changes since v2: - Introduce devm_rpi_firmware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix bindin

Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-11-12 Thread Nicolas Saenz Julienne
On Wed, 2020-11-11 at 17:45 -0800, Dmitry Torokhov wrote: > Hi Nicolas, > > On Wed, Nov 04, 2020 at 11:39:33AM +0100, Nicolas Saenz Julienne wrote: > > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > > interface when unbinding the device. >

Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-10 Thread Nicolas Saenz Julienne
Hi Bartosz, thanks for the feedback. On Thu, 2020-11-05 at 10:42 +0100, Bartosz Golaszewski wrote: > On Thu, Nov 5, 2020 at 10:28 AM Nicolas Saenz Julienne > wrote: > > Hi Bartosz, thanks for the review. > > > > On Thu, 2020-11-05 at 10:13 +0100, B

Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-05 Thread Nicolas Saenz Julienne
vers which want to schedule some more > unusual tasks at driver detach. Any reason for designing it this way? Yes, see patch #8 where I get rid of rpi_firmware_get() altogether after converting all users to devres. Since there is no use for the vanilla version of the function anymore, I figured i

Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2020-11-04 Thread Nicolas Saenz Julienne
On Wed, 2020-11-04 at 13:06 -0600, Rob Herring wrote: > On Wed, 04 Nov 2020 11:39:35 +0100, Nicolas Saenz Julienne wrote: > > The PWM bus controlling the fan in RPi's official PoE hat can only be > > controlled by the board's co-processor. > > > >

[PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-04 Thread Nicolas Saenz Julienne
upon unbinding consumer drivers. Suggested-by: Uwe Kleine-König Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Create devm_rpi_firmware_get() drivers/firmware/raspberrypi.c | 46 ++ include/soc/bcm2835/raspberrypi-firmware.h | 8 2 files ch

[PATCH v3 06/11] staging: vchiq: Release firmware handle on unbind

2020-11-04 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/staging/vc04_services/interface/vchiq_arm/vchiq_

[PATCH v3 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2020-11-04 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get()

[PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus

2020-11-04 Thread Nicolas Saenz Julienne
The PWM bus controlling the fan in RPi's official PoE hat can only be controlled by the board's co-processor. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Changes since v1: - Update bindings to use 2 #pwm-cells .../arm/bcm/raspberrypi,bcm2835-firmware

[PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-11-04 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/input/touchscreen/raspberrypi-ts.c | 2 +- 1

[PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware_get()

2020-11-04 Thread Nicolas Saenz Julienne
There a no users left to the function as they all converted to devm_rpi_firmware_get(). Just get rid of it. Signed-off-by: Nicolas Saenz Julienne --- drivers/firmware/raspberrypi.c | 17 - include/soc/bcm2835/raspberrypi-firmware.h | 6 -- 2 files changed, 23

[PATCH v3 04/11] reset: raspberrypi: Release firmware handle on unbind

2020-11-04 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/reset/reset-raspberrypi.c | 2 +- 1 file chang

[PATCH v3 03/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-11-04 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file chang

[PATCH v3 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support

2020-11-04 Thread Nicolas Saenz Julienne
This is an example on how to enable the fan on top of RPi's official PoE hat. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Update patch to use 2 pwm cells arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 54 +++ 1 file changed, 54 insertions(+) diff --

[PATCH v3 05/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2020-11-04 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file chang

[PATCH v3 02/11] clk: bcm: rpi: Release firmware handle on unbind

2020-11-04 Thread Nicolas Saenz Julienne
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/clk/bcm/clk-raspberrypi.c | 2 +- 1 file chang

[PATCH v3 00/11] Raspberry Pi PoE HAT fan support

2020-11-04 Thread Nicolas Saenz Julienne
-hat/ --- Changes since v2: - Introduce devm_rpi_firmware_get() - Small cleanups in PWM driver Changes since v1: - Address PWM driver changes - Fix binding, now with 2 cells - Add reference count to rpi_firmware_get() Nicolas Saenz Julienne (11): firmware: raspberrypi: Introduce devm_rpi_

Re: [PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put()

2020-10-26 Thread Nicolas Saenz Julienne
On Thu, 2020-10-22 at 21:46 +0300, Andy Shevchenko wrote: > On Thu, Oct 22, 2020 at 9:06 PM Nicolas Saenz Julienne > wrote: > > When unbinding the firmware device we need to make sure it has no > > consumers left. Otherwise we'd leave them with a firmware handle >

Re: [PATCH v2 03/10] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-10-26 Thread Nicolas Saenz Julienne
On Mon, 2020-10-26 at 15:40 +0100, Bartosz Golaszewski wrote: > On Thu, Oct 22, 2020 at 5:59 PM Nicolas Saenz Julienne > wrote: > > Upon unbinding the device make sure we release RPi's firmware interface. > > > > Signed-off-by: Nicolas Saenz Julienne > > ---

  1   2   3   4   5   6   >