hink we should just add `break`s for those.
--
Thanks,
~Nick Desaulniers
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
rg/onlinedocs/gcc/Zero-Length.html). I wonder if
-Wtautological-pointer-compare applies to Flexible Array Members or
not (Richard, do you know)? In general, you'd be setting
param->u.wpa_ie to the return value of a dynamic memory allocation,
no
gt; cell.platform_data = NULL;
> @@ -321,6 +323,8 @@ static int create_dma_engine_core(struct kp2000_device
> *pcard, size_t engine_re
> cell.name = KP_DRIVER_NAME_DMA_CONTROLLER;
> cell.num_resources = 2;
>
> +memset(&resources, 0, sizeof(resources));
> +
Bo
On Wed, Jan 9, 2019 at 11:01 PM Greg KH wrote:
>
> On Wed, Jan 09, 2019 at 04:19:30PM -0800, Nick Desaulniers wrote:
> > Digging up an old thread to point out I was wrong:
> >
> > On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers
> > wrote:
> > > > Th
On Wed, Sep 26, 2018 at 11:39 AM Greg KH wrote:
>
> On Wed, Sep 26, 2018 at 11:28:46AM -0700, Nick Desaulniers wrote:
> > On Wed, Sep 26, 2018 at 10:55 AM Nick Desaulniers
> > wrote:
> > >
> > > On Wed, Sep 26, 2018 at 12:41 AM Nathan Chancellor
> > >
On Wed, Sep 26, 2018 at 10:55 AM Nick Desaulniers
wrote:
>
> On Wed, Sep 26, 2018 at 12:41 AM Nathan Chancellor
> wrote:
> >
> > On Wed, Sep 26, 2018 at 09:13:59AM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Sep 26, 2018 at 12:02:09AM -0700, Nathan Chancellor
uation
by adding a v2 in the changelog area? Various beginner guides I've been
reading suggested I do this when a patch requires revisions.
Thanks,
Nick
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailm
v2: Undo the renaming of the dft_eps_id variable in hci_pdn_table_ind
to resolve a compiler error.
Signed-off-by: Nick Fox
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x
Rename dftEpsId variable to dft_eps_ID to be consistent with other
variables in the source file.
Signed-off-by: Nick Fox
---
drivers/staging/gdm724x/hci_packet.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging
Change argument to kmalloc() to fix style issue, reported by checkpatch
Signed-off-by: Nick Fox
---
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/staging/android/ion
Remove extra blank line (reported by checkpatch.pl)
Signed-off-by: Nick Fox
---
drivers/staging/android/ion/ion_cma_heap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc0dcf4..b06f4cee9c7c
over
kmalloc(sizeof(struct sg_table)...)
total: 0 errors, 0 warnings, 2 checks, 128 lines checked
Signed-off-by: Nick Fox
---
drivers/staging/android/ion/ion_cma_heap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/st
Running checkpath on card.c shows two locations where
multiple assignments are used.
This patch modifies the assignments into single assignments.
Signed-off-by: Nick Rosbrook
---
drivers/staging/vt6655/card.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers
Running checkpatch on ks7010_sdio.c shows two locations where
multiple assignment statements are used.
This patch modifies the assignments into single assignments.
Signed-off-by: Nick Rosbrook
---
drivers/staging/ks7010/ks7010_sdio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions
This patch corrects the spelling of 'initialize' in ks7010_sdio.c.
The issue was found by checkpatch.
Signed-off-by: Nick Rosbrook
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
Added spaces around a '*' in ks7010_sdio.c. Issue found by checkpatch.
Signed-off-by: Nick Rosbrook
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010/ks7010_sd
Greetings Greg and others,
I am sending a two part patch fix to prove to Greg I have changed.
Below this message are the patches for a bug fix in the gma500 driver
code. Unfortunately I haven't gotten a maintainer acknowledge and
therefore it's not in the merge for the 4.1 release.
Ni
-to-pointer-cast]
((void __user *)sg[j].addr_bus, sg_list[j].virt,
^
Nick
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2015-05-06 03:09 PM, Greg KH wrote:
> On Wed, May 06, 2015 at 10:05:55AM -0400, nick wrote:
>> On 2015-05-06 05:10 AM, Ian Abbott wrote:
>>> On 06/05/15 01:22, nick wrote:
>>>> Greetings All,
>>>> I am wondering if in the function,ni_stc_dma_channel_s
On 2015-05-06 05:10 AM, Ian Abbott wrote:
> On 06/05/15 01:22, nick wrote:
>> Greetings All,
>> I am wondering if in the function,ni_stc_dma_channel_select_bitfield the
>> line:
>> return 1 << channel;
>> is guaranteed to be below the threshold tha
Greetings All,
I am wondering if in the function,ni_stc_dma_channel_select_bitfield the line:
return 1 << channel;
is guaranteed to be below the threshold that guarantees us to not overflow on
a unsigned 32 integer due to bit wise shifting to the left.
Thank
olite "ping" requesting status.
>
> There really no other option as no other feedback
> mechanism exists and things can and do get lost in
> high-volume process.
>
>
That's fine, I will wait then for a reply from Greg.
Nick
nstant 0x8000 is so big
it is unsigned long
...
Signed-off-by: Nick Meier
---
drivers/hv/hyperv_vmbus.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
index e54825c..d152967 100644
--- a/drivers/hv/hyperv_vmbus.h
+++ b/d
Yes - the function should have been static. This change correctly corrects the
oversight.
thanks,
-Nick
-Original Message-
From: kbuild test robot [mailto:fengguang...@intel.com]
Sent: Sunday, March 1, 2015 8:49 PM
To: Tomas Winkler
Cc: kbuild-...@01.org; Greg Kroah-Hartman; Nick
I will correct this constant definition and resubmit.
-Nick Meier
-Original Message-
From: kbuild test robot [mailto:fengguang...@intel.com]
Sent: Sunday, March 1, 2015 8:49 PM
To: Nick Meier
Cc: kbuild-...@01.org; Greg Kroah-Hartman; KY Srinivasan; Haiyang Zhang;
de
is:
http://download.microsoft.com/download/A/B/4/AB43A34E-BDD0-4FA6-BDEF-79EEF16E880B/Hypervisor
Top Level Functional Specification v4.0.docx
Signed-off-by: Nick Meier
---
drivers/hv/hyperv_vmbus.h | 11 +++
drivers/hv/vmbus_drv.c| 36
2 files
ue, sizeof(value),
> NULL, NULL);
> }
> 1.9.1
>
This version is the correct version of my patch. The other one was not check
patched and please forget about it.
Nick
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
virtual_address,
>
> write_nic_byte(dev, TPPoll, TPPoll_CQ);
>
> - return rt_status;
> + return true;
> }
>
> static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
> --
> 1.9.1
>
Sorry about the three versions, other people wanted to make the
return !rt_status;
>> memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
>> tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
>> tcb_desc->queue_index = TXCMD_QUEUE;
>>
Thanks Randy for checking this I am going to resend as a v2 patch.
Regards Nick
On Mon, Aug 11, 2014 at 3:40 PM, Randy Dunlap wrote:
> On 08/11/14 12:18, Nick Krause wrote:
>>
>> Thanks Randy for your help otherwise is my patch good? Please let me
>> known if there
On Mon, Aug 11, 2014 at 3:04 PM, Randy Dunlap wrote:
> On 08/11/14 11:55, Nick Krause wrote:
>> On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote:
>>> On 08/11/14 11:26, Nick Krause wrote:
>>>> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap
>>>> w
On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote:
> On 08/11/14 11:26, Nick Krause wrote:
>> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote:
>>> On 08/11/14 11:04, Nick Krause wrote:
>>>> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause
>>>&
On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote:
> On 08/11/14 11:04, Nick Krause wrote:
>> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause wrote:
>>> I am fixing the bug entry ,
>>> https://bugzilla.kernel.org/show_bug.cgi?id=60461.
>>> This entry sta
DESC_PACKET_TYPE_INIT;
> + tcb_desc->bLastIniPkt = bLastIniPkt;
> + }
> seg_ptr = skb->data;
> for (i = 0; i < frag_length; i += 4) {
> *seg_ptr++ = ((i+0) < frag_length) ?
> --
On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang wrote:
>
>
> On 07/25/2014 11:30 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote:
>>>
>>>
>>> On 07/25/2014 11:13 AM, Nick Krause wrote:
>>>> On Thu, Jul 24, 2014 at 11:
On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote:
>
>
> On 07/25/2014 11:13 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote:
>>>
>>>
>>> On 07/25/2014 10:53 AM, Nick Krause wrote:
>>>> On Thu, Jul 24, 2014 at 10:
On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote:
>
>
> On 07/25/2014 10:53 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote:
>>>
>>>
>>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>>> On Thu, Jul 24, 2014 at 10:1
On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote:
>
>
> On 07/25/2014 10:20 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote:
>>>
>>> Excuse me, I did not see the patch details, but I guess it is about
>>> whether welcome
most of gmail members in open source, love programming).
>
> - Do I still love programming if I am discouraged by any members?
>
> - Do I still love open source kernel if discouraged by any members?
>
>
I have most of these skills other then developing real projects in C wit
On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote:
> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger
> wrote:
>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote:
>>> Steve,
>>> I have programming a lot in other areas just not the kernel.
>>> You a
On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger
wrote:
> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote:
>> Steve,
>> I have programming a lot in other areas just not the kernel.
>> You are right through I need to test my code better through.
>
> Nick,
>
&
On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt wrote:
> On Thu, 24 Jul 2014 10:30:51 -0700
> Harvey Harrison wrote:
>
>> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote:
>> > On Thu, 24 Jul 2014 12:50:31 -0400
>> > Nick Krause wrote:
>>
>>
On Thu, Jul 24, 2014 at 12:47 PM, Måns Rullgård wrote:
> Nick Krause writes:
>
>> On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote:
>>> Nick Krause writes:
>>>
>>>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote:
>>>>> Steve
On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote:
> Nick Krause writes:
>
>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote:
>>> Steven Rostedt writes:
>>>
>>>> On Thu, 24 Jul 2014 10:47:25 -0400
>>>> Steven Rostedt wrote:
>
Oh well, you get my point anyway.
>
> I have some doubts about the last bit.
>
> --
> Måns Rullgård
> m...@mansr.com
I am have this discussion with other kernel developers and just
because I send out
one patch as a newbie like this doesn't mean I don't known C.
Cheers Nick
On Wed, Jul 23, 2014 at 4:10 PM, Colin Cross wrote:
> On Wed, Jul 23, 2014 at 1:04 PM, Nick Krause wrote:
>> Hey Greg and others.
>> Sorry for another email but it seems the function,
>> ion_carveout_heap_unmap_dma is
>> just returning and not doing anything useful. F
other to avoid some rather serious bugs without a proper dma unmapping
function for this driver :).
Nick
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
tiny race in this function.
>> >
>> > Signed-off-by: Nicholas Krause
>>
>> Is this a guess work patch or have you tested it?
>
> Nevermind. This patch doesn't even compile.
>
> regards,
> dan carpenter
>
I am new so how do I compile test
Is this patch being merged or is this not an issue. I am confused
did I make a mistake in my patch or is there being a different
patch being merged.
Thank Nick
On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote:
> On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote:
>> Thanks for the
Thanks for the feedback I will resend the patch fixed.
Otherwise please use Larry's idea.
Cheers Nick
On Fri, Jun 20, 2014 at 4:08 PM, Joe Perches wrote:
> On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote:
>> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
This patch is old I thought I fixed it and resent.
Cheers Nick
On Thu, Jun 19, 2014 at 5:25 PM, Joe Perches wrote:
> On Thu, 2014-06-19 at 15:29 -0400, Nicholas Krause wrote:
>
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
>> b/drivers/staging
Our you Guys just removing me from your emails I have checked this patch
and it seems right. If you don't want to accept it , the less you can
do is give me a reply.
Nick
On Thu, Jun 19, 2014 at 10:12 PM, Nick Krause wrote:
> If anyone able to check this patch it would be great.
>
If anyone able to check this patch it would be great.
Thanks Nick
On Thu, Jun 19, 2014 at 5:18 PM, Nicholas Krause wrote:
> Checks for Null return from dev_skb_alloc if it returns Null,
> fw_download returns false. Otherwise it returns true.Also
> removed rt_status due to returning true
Thanks Joe,
I need to read my patches more carefully.
Nick :)
On Thu, Jun 19, 2014 at 4:53 PM, Joe Perches wrote:
> On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote:
>> Hey Guys,
>> So Sorry about wasting your time with bad patchs.
>> I feel bad about that. I hope this
Hey Guys,
So Sorry about wasting your time with bad patchs.
I feel bad about that. I hope this patch is O.K.
now. :(
Nicholas Krause
On Thu, Jun 19, 2014 at 4:18 PM, Nicholas Krause wrote:
> Checks for Null return from dev_skb_alloc if it returns Null,
> fw_download returns false. Otherwise it re
Hey guys,
Sorry about no reply,
my power supply died last night,
have to get a new one. I will be RMAing
the old old in order to get a packup in
case this PSU dies.
Cheers Nick
On Thu, Jun 19, 2014 at 1:29 AM, Dan Carpenter wrote:
> On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Kra
So sorry Greg,
I pulled the git in this morning for kernel-3.16-r2 ,I will resend the
patch from the clean tree.
I will also fix the tabs.'
Sorry :( Nick
On Wed, Jun 18, 2014 at 2:14 PM, Greg KH wrote:
> On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote:
>> Signed-of
Signed-off-by: Nicholas Krause
---
drivers/vme/bridges/vme_ca91cx42.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vme/bridges/vme_ca91cx42.h
b/drivers/vme/bridges/vme_ca91cx42.h
index 02a7c79..57e942f 100644
--- a/drivers/vme/bridges/vme_ca91cx42.h
+++ b/drivers/
Here is the fixed patch. Having issues with using Thunderbird
so just used Evolution for now.
Nick
--- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939
-0400
+++ drivers/vme/bridges/vme_ca91cx42.h 2014-06-11 23:15:36.027685173 -0400
Fixes bug issues with wrong bus width
M (5<<16)
-#define CA91CX42_LM_CTL_AS_A16 0
+#define CA91CX42_LM_CTL_AS_A16 (3<<16)
#define CA91CX42_LM_CTL_AS_A24 (1<<16)
#define CA91CX42_LM_CTL_AS_A32 (1<<17)
Signed-off-by: Nicholas Krause
Nick
Fixed coding style warnings in ni_tio.h which had an extra space
after the function pointer name.
Signed-off-by: Nick Davies
---
drivers/staging/comedi/drivers/ni_tio.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_tio.h
b/drivers
Fixed coding style warnings in comedidev.h which had an extra space
after the function pointer name.
Signed-off-by: Nick Davies
---
drivers/staging/comedi/comedidev.h | 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging
62 matches
Mail list logo
