Re: [PATCH -next v2] staging: kpc2000: Remove set but not used variable ‘status’

2019-05-27 Thread maowenan
please ignore v2 version. I will send v3 later according to Sven Van Asbroeck 's comments. On 2019/5/25 16:13, Mao Wenan wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function > ‘kp_spi_transfer_one_message’: > drivers/staging/kpc2000

Re: [PATCH net] staging: Remove set but not used variable ‘status’

2019-05-26 Thread maowenan
On 2019/5/25 20:59, Sven Van Asbroeck wrote: > On Sat, May 25, 2019 at 12:20 AM Mao Wenan wrote: >> >> The variable 'status' is not used any more, remve it. > >> /* do the transfers for this message */ >> list_for_each_entry(transfer, &m->transfers, transfer_list) { >> if (t

Re: [PATCH net] staging: Remove set but not used variable ‘status’

2019-05-24 Thread maowenan
On 2019/5/25 13:01, Greg KH wrote: > On Sat, May 25, 2019 at 12:26:42PM +0800, Mao Wenan wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function >> ‘kp_spi_transfer_one_message’: >> drivers/staging/kpc2000/kpc_spi/spi_driver.c:282:9

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-18 Thread maowenan
On 2019/3/17 19:26, Greg KH wrote: > On Sat, Mar 09, 2019 at 11:26:00AM +0800, Mao Wenan wrote: >> Using is_zero_ether_addr() instead of directly use >> memcmp() to determine if the ethernet address is all >> zeros. >> >> Signed-off-by: Mao Wenan >> --- >> drivers/staging/rtl8188eu/core/rtw_ml

Re: [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-15 Thread maowenan
Ping... Thank you. On 2019/3/11 22:35, Dan Carpenter wrote: > Thanks! > > Reviewed-by: Dan Carpenter > > regards, > dan carpenter > > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/dr

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-11 Thread maowenan
On 2019/3/12 14:35, Joe Perches wrote: > On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote: >> ping... >> >> On 2019/3/9 11:26, Mao Wenan wrote: >>> Using is_zero_ether_addr() instead of directly use >>> memcmp() to determine if the ethernet address

Re: [PATCH net] staging: rtl8188eu: use is_zero_ether_addr() instead of memcmp()

2019-03-11 Thread maowenan
ping... On 2019/3/9 11:26, Mao Wenan wrote: > Using is_zero_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is all > zeros. > > Signed-off-by: Mao Wenan > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(

Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread maowenan
On 2019/3/11 22:07, Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote: >> There is no need to have the 'T *v' variable static >> since new value always be assigned before use it. >> >> Signed-off-by: Mao Wenan >> --- >> drivers/staging/media/davinci_vpfe/dm365_re

Re: [PATCH] staging: rtl8712: assign initial value to a static variable in r8712_efuse_pg_packet_write()

2019-02-28 Thread maowenan
On 2019/2/28 16:04, Greg KH wrote: > On Wed, Feb 27, 2019 at 11:33:22AM +0800, Mao Wenan wrote: >> repeat_times is a static variable, but each time when it enters >> r8712_efuse_pg_packet_write(), it is set to zero, >> this value is not consistent with last calling, so next behavior >> is not ou