[PATCH v3] staging: fsl-mc: move bus driver out of staging

2017-11-28 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-27 Thread laurentiu.tudor
From: Laurentiu Tudor Fix this warning triggering on a powerpc build: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/stag

[PATCH 10/10] staging: fsl-mc: use device_type instead of strcmp()

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor Replace strcmp() based device type checks with the standard device model type. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 4 ++-- drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 20 ++-- drivers/staging/fsl-mc/bus/f

[PATCH 06/10] staging: fsl-mc/dpio: change to use EXPORT_SYMBOL_GPL()

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor No need to use EXPORT_SYMBOL() so switch to the GPL variant. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-s

[PATCH 07/10] staging: fsl-mc: remove some superfluous WARN_ONs

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor These WARN_ONs shouldn't trigger unless something went very wrong. Since the driver is in a stable state let's remove these debug WARN_ONs. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 8 drivers/staging/fsl-mc/bus/f

[PATCH 09/10] staging: fsl-mc: add support for device type

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor The MC bus has different types of devices and this is supported by device model. This patch adds initial support for device types (defines them, adds helpers and sets the device type). Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 67 +++

[PATCH 05/10] staging: fsl-mc: consistently use EXPORT_SYMBOL_GPL()

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor The bus driver is mixing EXPORT_SYMBOL()/EXPORT_SYMBOL_GPL() usage. Change it to consistently use EXPORT_SYMBOL_GPL(). Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpbp.c | 16 drivers/staging/fsl-mc/bus/dpcon.c | 14 +++--- dr

[PATCH 08/10] staging: fsl-mc: remove debug WARN_ONs doubling error checks

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor A lot of error checks are doubled by debug WARN_ONs. Given that the driver was thoroughly debugged and is in a stable state, it's time to drop them. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 20 ++--- drivers/staging/fsl-mc/bu

[PATCH 04/10] staging: fsl-mc/dpio: remove couple of unused functions

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor These couple of functions are not yet used so lets remove them for now and add them back when/if needed. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 58 -- drivers/staging/fsl-mc/include/dpaa2-io.h | 4

[PATCH 03/10] staging: fsl-mc/dpio: drop EXPORT_SYMBOL() for a few functions

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor These functions are only used within this driver so no need for EXPORT_SYMBOL(). Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c b/drive

[PATCH 02/10] staging: fsl-mc/dpio: remove incomplete refcount implementation

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor There's an unfinished implementation of reference counting for dpaa2_io structure using atomics. Since it's unused lets remove it for now and, if needed at a later time, make use of krefs instead of rolling our own refcounting. Signed-off-by: Laurentiu Tudor --- drivers/s

[PATCH 01/10] staging: fsl-mc: drop unused dpcon APIs

2017-11-17 Thread laurentiu.tudor
From: Laurentiu Tudor Couple of API functions are not used so lets drop them together with the associated structures and defines. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpcon-cmd.h | 6 --- drivers/staging/fsl-mc/bus/dpcon.c | 69 --

[PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-08-28 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[RESEND PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

2017-08-23 Thread laurentiu.tudor
From: Laurentiu Tudor Throughout the driver we use == 0 / != 0 to check strcmp() returns except this place, so fix it. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dprc

[PATCH] staging: fsl-mc: move bus driver out of staging

2017-08-19 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

2017-08-17 Thread laurentiu.tudor
From: Laurentiu Tudor Throughout the driver we use == 0 / != 0 to check strcmp() returns except this place, so fix it. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dprc

[PATCH] staging: fsl-mc: add explicit dependencies for compile-tested arches

2017-07-31 Thread laurentiu.tudor
From: Laurentiu Tudor The driver makes use of GENERIC_MSI_IRQ_DOMAIN which requires arch support so, on architectures that don't have it, the kernel will fail to build. Add explicit dependency on architectures that were compile-tested, thus fixing compilation for the ones that don't implement GEN

[PATCH v3 8/8] staging: fsl-mc: allow the driver compile multi-arch

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Add an alternate dependency on COMPILE_TEST, thus leaving this driver compile on other architectures. Also, other drivers depending on the bus are updated to depend on ARCH_LAYERSCAPE until they'll also be made multi-arch. This was compiled tested on: - booke powerpc (coren

[PATCH v3 6/8] staging: fsl-mc: don't use raw device io functions

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor As raw device io functions are not portable and don't handle byte-order (triggering suspicion that endianness isn't handled well) switch to using the standard api. Since MC expects LE byte-order and the upper layers already take care of that, we need to trick the device io a

[PATCH v3 4/8] staging: fsl-mc: fix compilation with non-generic msi domain ops

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor The bus driver relies on generic msi domain ops. Fix compilation for architectures that don't provide it (e.g. x86_64). Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes -v2 -no changes drivers/staging/fsl-mc/bus/fsl-m

[PATCH v3 7/8] staging: fsl-mc: make the driver compile on 32-bit

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Since there's no real constrain in MC to do only atomic 64-bit we can enable this driver on 32-bit platforms too. Include linux/io-64-nonatomic-hi-lo.h to make quad device io apis used in the driver available on 32-bit platforms. Signed-off-by: Laurentiu Tudor Acked-by: Ar

[PATCH v3 5/8] staging: fsl-mc: fix formating of phys_addr_t on 32 bits

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Use correct format specifier for phys_addr_t variables (%pa) instead of %llx. This fixes these warnings on 32 bit targets: "format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]" Signed-off-by: Laurentiu Tudor

[PATCH v3 1/8] staging: fsl-mc: add missing fsl_mc comment in struct msi_desc

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor The mc-bus specific field, fsl_mc in struct msi_desc is missing its comment so add it. Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes -v2 -no changes include/linux/msi.h | 1 + 1 file changed, 1 insertion(+) diff -

[PATCH v3 0/8] staging: fsl-mc: make the driver compile on other architectures

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Apart from a small change (first patch) which adds a missing comment, this series make the bus driver compile on other architectures, as per GregKH comment [1]. Compiled tested on: - booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2] - x86 (i386_defconfig

[PATCH v3 3/8] staging: fsl-mc: drop useless gic v3 related #include

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be safely dropped. Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes -v2 -no changes drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 - dr

[PATCH v3 2/8] staging: fsl-mc: use generic memory barriers

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor No need to use arch-specific memory barriers; switch to using generic ones. The rmb()s were useless so drop them. Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes -v2 -no changes drivers/staging/fsl-mc/bus/mc-sys.c |

[PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64), thus leaving this driver compile on other architectures. Also, other drivers depending on the bus are updated to depend on ARCH_LAYERSCAPE until they'll also be made multi-arch. This was compiled tested on:

[PATCH v2 2/8] staging: fsl-mc: use generic memory barriers

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor No need to use arch-specific memory barriers; switch to using generic ones. The rmb()s were useless so drop them. Signed-off-by: Laurentiu Tudor --- Notes: -v2 -no changes drivers/staging/fsl-mc/bus/mc-sys.c | 6 ++ 1 file changed, 2 insertions(+), 4 deleti

[PATCH v2 3/8] staging: fsl-mc: drop useless gic v3 related #include

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be safely dropped. Signed-off-by: Laurentiu Tudor --- Notes: -v2 -no changes drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 - drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.

[PATCH v2 7/8] staging: fsl-mc: make the driver compile on 32-bit

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor Since there's no real constrain in MC to do only atomic 64-bit we can enable this driver on 32-bit platforms too. Include linux/io-64-nonatomic-hi-lo.h to make quad device io apis used in the driver available on 32-bit platforms. Signed-off-by: Laurentiu Tudor --- Notes:

[PATCH v2 4/8] staging: fsl-mc: fix compilation with non-generic msi domain ops

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor The bus driver relies on generic msi domain ops. Fix compilation for architectures that don't provide it (e.g. x86_64). Signed-off-by: Laurentiu Tudor --- Notes: -v2 -no changes drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 4 drivers/staging/fs

[PATCH v2 6/8] staging: fsl-mc: don't use raw device io functions

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor As raw device io functions are not portable and don't handle byte-order (triggering suspicion that endianness isn't handled well) switch to using the standard api. Since MC expects LE byte-order and the upper layers already take care of that, we need to trick the device io a

[PATCH v2 5/8] staging: fsl-mc: fix formating of phys_addr_t on 32 bits

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor Use correct format specifier for phys_addr_t variables (%pa) instead of %llx. This fixes these warnings on 32 bit targets: "format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]" Signed-off-by: Laurentiu Tudor

[PATCH v2 1/8] staging: fsl-mc: add missing fsl_mc comment in struct msi_desc

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor The mc-bus specific field, fsl_mc in struct msi_desc is missing its comment so add it. Signed-off-by: Laurentiu Tudor --- Notes: -v2 -no changes include/linux/msi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/msi.h b/include/linux/msi.h in

[PATCH v2 0/7] staging: fsl-mc: make the driver compile on other architectures

2017-07-18 Thread laurentiu.tudor
From: Laurentiu Tudor Apart from a small change (first patch) which adds a missing comment, this series make the bus driver compile on other architectures, as per GregKH comment [1]. Compiled tested on: - booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2] - x86 (i386_defconfig

[PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64), thus leaving this driver compile on other architectures. Also, other drivers depending on the bus are updated to depend on ARCH_LAYERSCAPE until they'll also be made multi-arch. This was compiled tested on:

[PATCH 4/7] staging: fsl-mc: fix compilation with non-generic msi domain ops

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor The bus driver relies on generic msi domain ops. Fix compilation for architectures that don't provide it (e.g. x86_64). Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 4 drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi

[PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor Split the 64-bit accesses in 32-bit accesses because there's no real constrain in MC to do only atomic 64-bit. There's only one place where ordering is important: when writing the MC command header the first 32-bit part of the header must be written last. We do this switch i

[PATCH 5/7] staging: fsl-mc: fix formating of phys_addr_t on 32 bits

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor Use correct format specifier for phys_addr_t variables (%pa) instead of %llx. This fixes these warnings on 32 bit targets: "format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]" Signed-off-by: Laurentiu Tudor

[PATCH 3/7] staging: fsl-mc: drop useless gic v3 related #include

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be safely dropped. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 - drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 - 2 files changed, 2 deleti

[PATCH 1/7] staging: fsl-mc: add missing fsl_mc comment in struct msi_desc

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor The mc-bus specific field, fsl_mc in struct msi_desc is missing its comment so add it. Signed-off-by: Laurentiu Tudor --- include/linux/msi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/msi.h b/include/linux/msi.h index df6d592..80e3b56 100644 --- a/

[PATCH 0/7] staging: fsl-mc: make the driver compile on other architectures

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor Apart from a small change (first patch) which adds a missing comment, this series make the bus driver compile on other architectures, as per GregKH comment [1]. Compiled tested on: - booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2] - x86 (i386_defconfig

[PATCH 2/7] staging: fsl-mc: use generic memory barriers

2017-07-17 Thread laurentiu.tudor
From: Laurentiu Tudor No need to use arch-specific memory barriers; switch to using generic ones. The rmb()s were useless so drop them. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/mc-sys.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stagi

[PATCH v2 12/15] staging: fsl-mc: fix a few implicit includes

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor Few files using byte order macros but did not explicitly included the required kernel header, so add it. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dpbp.c | 1 + drivers/staging/fsl-mc/bus/dpcon.c | 1 + drivers/staging/fsl-m

[PATCH v2 10/15] staging: fsl-mc: move rest of mc-bus.h to private header

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor All the mc-bus.h contents is only used privately in the bus driver so move everything to the private header and get rid of the mc-bus.h header file. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dprc-driver.c | 1 - drivers/st

[PATCH v2 15/15] staging: fsl-mc: make dprc.h header private

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor dprc.h is only used in the mc bus driver so move it together with the sources thus making it private. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dprc.c | 2 +- drivers/staging/fsl-mc/{include => bus}/dprc.h | 0 drivers/s

[PATCH v2 14/15] staging: fsl-mc: move mc-cmd.h contents in the public header

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor mc-cmd.h contains some low level functions used to encode and decode commands to the MC. They are used by the drivers so move them to the public headers and get rid of the mc-cmd.h header. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-dpaa2/eth

[PATCH v2 11/15] staging: fsl-mc: remove dpmng API files

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor dpmng.h & dpmng.c files expose an API of just one function which is only used by the bus driver. Move that single API in the bus source as static and remove the two files. Signed-off-by: Laurentiu Tudor --- v2: - fix compile error by removing dpmng.c from Makefile drive

[PATCH v2 09/15] staging: fsl-mc: move couple of definitions to public header

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor Define dev_is_fsl_mc() and the bus type definition (fsl_mc_bus_type) are used externally so move them to the public header. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 9 - drivers/staging/fsl-mc/include/mc.h

[PATCH v2 13/15] staging: fsl-mc: move mc-sys.h contents in the public header

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor mc-sys.h contains the API to send commands to the MC and is used by drivers. Move it to the public headers and get rid of the mc-sys.h header. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 - drivers/staging/fsl-

[PATCH v2 07/15] staging: fsl-mc: turn several exported functions static

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor They are never used outside the source they are implemented in and very likely never will, so it's safe to make them static. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dprc-driver.c | 8 +++- drivers/staging/fsl-mc/bus/fsl-mc-bus.

[PATCH v2 06/15] staging: fsl-mc: delete prototype of unimplemented function

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor The function fsl_mc_bus_exists() has a prototype but is never implemented so delete it from the header file. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/

[PATCH v2 08/15] staging: fsl-mc: move irq domain creation prototype to public header

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor fsl_mc_msi_create_irq_domain() will is used from the irqchip glue code so it needs to be in the public headers. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 7 --- drivers/staging/fsl-mc/include/mc.h | 7 +++

[PATCH v2 05/15] staging: fsl-mc: delete duplicated function prototypes

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor These functions already have their prototypes in fsl-mc-private.h header file so delete them from mc-bus.h. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/sta

[PATCH v2 04/15] staging: fsl-mc: decouple the mc-bus public headers from dprc.h

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor In its current form, the public headers of the mc-bus depend only on a structure "dprc_obj_desc" defined in dprc.h. Move it to the bus public header together with its associated defines and, in order to keep the naming prefixes consistent rename it to "fsl_mc_obj_desc". This

[PATCH v2 03/15] staging: fsl-mc: drop useless #includes

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor These couple of header files are not needed in the source so remove them. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c

[PATCH v2 02/15] staging: fsl-mc: be consistent when checking strcmp() return

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor Stick to one way of checking the return code of strcmp(): use '!'. This was suggested in a review comment. Signed-off-by: Laurentiu Tudor --- v2: - new patch drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v2 00/15] staging: fsl-mc: clean up header files

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor This patch series contain mainly clean-ups of the mc-bus header files with the final goal of reorganizing them in just 2 files: a public and a private one, as per GregKH suggestion [1]. Here's a summary of the header reorganizing: - existing mc.h used as public header (cont

[PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call

2017-06-27 Thread laurentiu.tudor
From: Laurentiu Tudor Move comparison before the strcmp() in this if statement, and slightly increase efficiency by not making the strcmp() each time the if gets evaluated but only when the comparison is true. This was suggested in a review comment. Signed-off-by: Laurentiu Tudor --- v2: - new

[PATCH 14/14] staging: fsl-mc: make dprc.h header private

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor dprc.h is only used in the mc bus driver so move it together with the sources thus making it private. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc.c | 2 +- drivers/staging/fsl-mc/{include => bus}/dprc.h | 0 drivers/staging/fsl-mc/bus/f

[PATCH 13/14] staging: fsl-mc: move mc-cmd.h contents in the public header

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor mc-cmd.h contains some low level functions used to encode and decode commands to the MC. They are used by the drivers so move them to the public headers and get rid of the mc-cmd.h header. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-dpaa2/ethernet/dpni.c | 1

[PATCH 12/14] staging: fsl-mc: move mc-sys.h contents in the public header

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor mc-sys.h contains the API to send commands to the MC and is used by drivers. Move it to the public headers and get rid of the mc-sys.h header. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 - drivers/staging/fsl-dpaa2/ethernet/dpni

[PATCH 05/14] staging: fsl-mc: delete prototype of unimplemented function

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor The function fsl_mc_bus_exists() has a prototype but is never implemented so delete it from the header file. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/mc-bus.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fsl-mc/include/mc-b

[PATCH 11/14] staging: fsl-mc: fix a few implicit includes

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor Few files using byte order macros but did not explicitly included the required kernel header, so add it. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpbp.c | 1 + drivers/staging/fsl-mc/bus/dpcon.c | 1 + drivers/staging/fsl-mc/bus/dpio/dpio.c |

[PATCH 10/14] staging: fsl-mc: remove dpmng API files

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor dpmng.h & dpmng.c files expose an API of just one function which is only used by the bus driver. Move that single API in the bus source as static and remove the two files. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dpmng.c | 74

[PATCH 09/14] staging: fsl-mc: move rest of mc-bus.h to private header

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor All the mc-bus.h contents is only used privately in the bus driver so move everything to the private header and get rid of the mc-bus.h header file. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 1 - drivers/staging/fsl-mc/bus/fs

[PATCH 07/14] staging: fsl-mc: move irq domain creation prototype to public header

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor fsl_mc_msi_create_irq_domain() will is used from the irqchip glue code so it needs to be in the public headers. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/mc-bus.h | 7 --- drivers/staging/fsl-mc/include/mc.h | 7 +++ 2 files changed, 7

[PATCH 08/14] staging: fsl-mc: move couple of definitions to public header

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor Define dev_is_fsl_mc() and the bus type definition (fsl_mc_bus_type) are used externally so move them to the public header. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/mc-bus.h | 9 - drivers/staging/fsl-mc/include/mc.h | 9 + 2 f

[PATCH 03/14] staging: fsl-mc: decouple the mc-bus public headers from dprc.h

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor In its current form, the public headers of the mc-bus depend only on a structure "dprc_obj_desc" defined in dprc.h. Move it to the bus public header together with its associated defines and, in order to keep the naming prefixes consistent rename it to "fsl_mc_obj_desc". This

[PATCH 06/14] staging: fsl-mc: turn several exported functions static

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor They are never used outside the source they are implemented in and very likely never will, so it's safe to make them static. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 8 +++- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 5 ++--- drive

[PATCH 04/14] staging: fsl-mc: delete duplicated function prototypes

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor These functions already have their prototypes in fsl-mc-private.h header file so delete them from mc-bus.h. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/mc-bus.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/fsl-mc/include

[PATCH 02/14] staging: fsl-mc: drop useless #includes

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor These couple of header files are not needed in the source so remove them. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging

[PATCH 01/14] staging: fsl-mc: drop macros with possible side effects

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros were triggering this checkpatch.pl warning: "Macro argument reuse '$arg' - possible side-effects?" Fix the warning by turning them into real functions. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 15 +--

[PATCH 00/14] staging: fsl-mc: clean up header files

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor This patch series contain mainly clean-ups of the mc-bus header files with the final goal of reorganizing them in just 2 files: a public and a private one, as per GregKH suggestion [1]. Here's a summary of the header reorganizing: - existing mc.h used as public header (cont

[PATCH] staging: fsl-dpaa2/eth: fix a couple of implicit includes

2017-06-22 Thread laurentiu.tudor
From: Laurentiu Tudor dpni.c is using byte order macros and error codes but does not explicitly include the required kernel header, so add it. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fsl-

[PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging

2017-06-08 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[PATCH v7 07/10] staging: fsl-mc: add binding path to MAINTAINERS

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor The mc bus device tree binding is maintained but not mentioned in the MAINTAINERS file. This patch adds it. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -rewrapped commit message -v2 -added commit description MAINTAINERS | 1 + 1 file changed, 1 ins

[PATCH v7 06/10] staging: fsl-mc: drop unused forward declaration

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor This forward declaration of "struct fsl_mc_resource" is of no use so drop it. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -rewrapped commit message drivers/staging/fsl-mc/include/mc-sys.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl

[PATCH v7 05/10] staging: fsl-mc: remove extra blank line

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Remove extra blank line reported by checkpatch.pl. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -no changes drivers/staging/fsl-mc/include/dprc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/dprc.h b/drivers/staging/fsl-m

[PATCH v7 09/10] staging: fsl-mc: add reference to mc-bus DT binding

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Update README to reference the mc-bus device tree node binding. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -rewrapped commit message drivers/staging/fsl-mc/README.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fsl-mc/README.txt b

[PATCH v7 08/10] staging: fsl-mc: drop reference to restool

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Drop reference to user space restool utility from the README. It will be added back together with the actual support in the bus driver. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -no changes drivers/staging/fsl-mc/README.txt | 4 +--- 1 file changed, 1 inse

[PATCH v7 04/10] staging: fsl-mc: drop a few useless #includes

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Some #includes were needlessly done from header files. Drop them from there and update the only .c file that implicitly needed one of those #includes. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -rewrapped commit message drivers/staging/fsl-mc/bus/fsl-mc-msi

[PATCH v7 02/10] staging: fsl-mc: fix macros with possible side effects

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros were triggering this checkpatch.pl warning: "Macro argument reuse '$arg' - possible side-effects?" Fix the warning by avoiding multiple macro argument use. Signed-off-by: Laurentiu Tudor --- Notes: -v7 -no changes drivers/staging/fsl-mc/bus/dp

[PATCH v7 03/10] staging: fsl-mc: simplify couple of deallocations

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Simplify a couple of deallocations code paths. This also fixes these checkpatch.pl false positives: "WARNING: kfree(NULL) is safe and this check is probably not required" Signed-off-by: Laurentiu Tudor --- Notes: -v7 -rewrapped commit message drivers/staging/

[PATCH v7 01/10] staging: fsl-mc: enclose macro params in parens

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros didn't had macro params enclosed in parens. Fix them to avoid precedence issues. Found with checkpatch.pl who was issuing this message: "Macro argument 'id' may be better as '(id)' to avoid precedence issues" Signed-off-by: Laurentiu Tudor --- Note

[PATCH v7 00/10] staging: fsl-mc: move bus driver out of staging

2017-06-08 Thread laurentiu.tudor
From: Laurentiu Tudor Now that there is a functional ethernet driver probed on the mc bus this patch series requests that the fsl-mc bus driver be moved out of staging. The proposed destination for the bus driver is drivers/bus. Proposed location for global header files for fsl-mc and dpaa2 is t

[PATCH v2 07/10] staging: fsl-mc: add binding path to MAINTAINERS

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor The mc bus device tree binding is maintained but not mentioned in the MAINTAINERS file. This patch adds it. Signed-off-by: Laurentiu Tudor --- Notes: -v2 -added commit description MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[PATCH 09/10] staging: fsl-mc: add reference to mc-bus DT binding

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Update README to reference the mc-bus device tree node binding. Signed-off-by: Laurentiu Tudor --- Notes: -no changes drivers/staging/fsl-mc/README.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fsl-mc/README.txt b/drivers/staging/fsl-mc/RE

[PATCH 08/10] staging: fsl-mc: drop reference to restool

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Drop reference to user space restool utility from the README. It will be added back together with the actual support in the bus driver. Signed-off-by: Laurentiu Tudor --- Notes: -no changes drivers/staging/fsl-mc/README.txt | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 05/10] staging: fsl-mc: remove extra blank line

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Remove extra blank line reported by checkpatch.pl. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/dprc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/dprc.h b/drivers/staging/fsl-mc/include/dprc.h index 8498a5e..2f4

[PATCH 06/10] staging: fsl-mc: drop unused forward declaration

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor This forward declaration of "struct fsl_mc_resource" is of no use so drop it. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/mc-sys.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/mc-sys.h b/drivers/staging/fsl-mc/in

[PATCH 03/10] staging: fsl-mc: simplify couple of deallocations

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Simplify a couple of deallocations code paths. This also fixes these checkpatch.pl false positives: "WARNING: kfree(NULL) is safe and this check is probably not required" Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 12 +++- 1

[PATCH 02/10] staging: fsl-mc: fix macros with possible side effects

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros were triggering this checkpatch.pl warning: "Macro argument reuse '$arg' - possible side-effects?" Fix the warning by avoiding multiple macro argument use. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 10 +++--- d

[PATCH 04/10] staging: fsl-mc: drop a few useless #includes

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Some #includes were needlessly done from header files. Drop them from there and update the only .c file that implicitly needed one of those #includes. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c | 1 + drivers/staging/fsl-mc/bus/fsl-mc-p

[PATCH 01/10] staging: fsl-mc: enclose macro params in parens

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros didn't had macro params enclosed in parens. Fix them to avoid precedence issues. Found with checkpatch.pl who was issuing this message: "Macro argument 'id' may be better as '(id)' to avoid precedence issues" Signed-off-by: Laurentiu Tudor --- drivers

[PATCH v6 00/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Now that there is a functional ethernet driver probed on the mc bus this patch series requests that the fsl-mc bus driver be moved out of staging. The proposed destination for the bus driver is drivers/bus. Proposed location for global header files for fsl-mc and dpaa2 is t

[PATCH 5/5][v5] staging: fsl-mc: move bus driver out of staging

2017-05-22 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings

2017-05-22 Thread laurentiu.tudor
From: Laurentiu Tudor Remove several unneeded #includes, forward declarations and fix several issues reported by checkpatch.pl --strict, such as: - kfree(NULL) is safe and check is not required - macro argument reuse may cause possible side effects - enclose macro params in parens to avoid pre

[PATCH 4/5] staging: fsl-mc: add reference to mc-bus DT binding

2017-05-22 Thread laurentiu.tudor
From: Laurentiu Tudor Update README to reference the mc-bus device tree node binding. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/README.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fsl-mc/README.txt b/drivers/staging/fsl-mc/README.txt index d7cd70a.

  1   2   >