Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

2017-09-18 Thread Himanshi Jain
> On Wed, 13 Sep 2017 14:14:07 +0530 >>>> Himanshi Jain wrote: >>>> >>>>> Add __ATTR_NAMED macro similar to __ATTR but taking name as a >>>>> string instead of implicit conversion of argument to string using >>>>> the macro _stringify(_

Re: [PATCH 2/2] iio: Use __ATTR_NAMED to allow passing name as string to IIO_DEVICE_ATTR_NAMED and change usage to pass string

2017-09-13 Thread himanshi
On Wed, Sep 13, 2017 at 11:12:21AM +0300, Dan Carpenter wrote: > On Wed, Sep 13, 2017 at 01:26:27PM +0530, Himanshi Jain wrote: > > Add IIO_ATTR_NAMED macro to use __ATTR_NAMED to allow passing name as > > string to IIO_DEVICE_ATTR_NAMED. Change current usage of > > IIO_DEVI

[PATCH v2 2/2] iio: Change to __ATTR_NAMED()

2017-09-13 Thread Himanshi Jain
Add IIO_ATTR_NAMED macro to use __ATTR_NAMED to allow passing name as string to IIO_DEVICE_ATTR_NAMED. Change current usage of IIO_DEVICE_ATTR_NAMED to pass name as string. Signed-off-by: Himanshi Jain --- drivers/iio/adc/ad7793.c | 2 +- drivers/staging/iio/adc/ad7192.c | 2

[PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

2017-09-13 Thread Himanshi Jain
Add __ATTR_NAMED macro similar to __ATTR but taking name as a string instead of implicit conversion of argument to string using the macro _stringify(_name). Signed-off-by: Himanshi Jain --- include/linux/sysfs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/sysfs.h b

[PATCH v2 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string.

2017-09-13 Thread Himanshi Jain
This patchset is to rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string. Himanshi Jain (2): include: linux: sysfs: Add __ATTR_NAMED macro iio: Change to __ATTR_NAMED() drivers/iio/adc/ad7793.c | 2 +- drivers/staging/iio/adc/ad7192.c | 2 +- drivers/staging/iio/adc

[PATCH 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

2017-09-13 Thread Himanshi Jain
Add __ATTR_NAMED macro similar to __ATTR but taking name as a string instead of implicit conversion of argument to string using the macro _stringify(_name). Signed-off-by: Himanshi Jain --- include/linux/sysfs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/sysfs.h b

[PATCH 2/2] iio: Use __ATTR_NAMED to allow passing name as string to IIO_DEVICE_ATTR_NAMED and change usage to pass string

2017-09-13 Thread Himanshi Jain
Add IIO_ATTR_NAMED macro to use __ATTR_NAMED to allow passing name as string to IIO_DEVICE_ATTR_NAMED. Change current usage of IIO_DEVICE_ATTR_NAMED to pass name as string. Signed-off-by: Himanshi Jain --- drivers/iio/adc/ad7793.c | 2 +- drivers/staging/iio/adc/ad7192.c | 2

[PATCH 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string.

2017-09-13 Thread Himanshi Jain
This patchset is to rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string. Himanshi Jain (2): include: linux: sysfs: Add __ATTR_NAMED macro iio: Use __ATTR_NAMED to allow passing name as string to IIO_DEVICE_ATTR_NAMED and change usage to pass string drivers/iio/adc/ad7793.c

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

2017-09-12 Thread himanshi
; > On Tue, 12 Sep 2017, himanshi wrote: > > > >> Thanks for the review Daniel! I will change the imperative mood for the > >> commit > >> message once the other changes are finalised too and as suggested by Julia, > >> would try to make the descript

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

2017-09-12 Thread himanshi
(sysfs file again) would be included in the second patch if I am not wrong. So would it be fine to keep the subsystem as iio for the second patch? On Tue, Sep 12, 2017 at 10:53:26AM +0300, Daniel Baluta wrote: > Hi Himanshi, > > On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain > wrot

[PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

2017-09-11 Thread Himanshi Jain
Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string instead of implicit conversion to string using preprocessors. Added double quotes around names in existing usage of IIO_DEVICE_ATTR_NAMED. Signed-off-by: Himanshi Jain --- drivers/iio/adc/ad7793.c | 2 +- drivers/staging/iio/adc

[PATCH] Staging: iio: adc: Added Space around binary op.

2017-09-07 Thread Himanshi Jain
Added space around(one on each side of) binary operator(-) as preferred according to kernel coding style. Signed-off-by: Himanshi Jain --- drivers/staging/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio