From: Gary Yao
Clean up block comment style issues to follow kernel coding style
and clear checkpatch warnings.
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Gary Yao
---
.../pci/isp/modes/interface/isp_types.h
Remove the temp bracing afixed to case labels.
Properly indent switch/case breaks.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 50 +++-
1 file changed, 7 insertions(+), 43 deletions(-)
diff --git a/drivers
On Thu, 20 Mar 2014, Greg KH wrote:
On Wed, Mar 19, 2014 at 10:29:42PM -0400, Gary Rookard wrote:
On Thu, 20 Mar 2014, Greg KH wrote:
On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote:
I moved the #defines from implementation file DDRInit.c to
the proper specification file
On Thu, 20 Mar 2014, Greg KH wrote:
On Wed, Mar 19, 2014 at 05:30:53PM -0400, Gary Rookard wrote:
I moved the #defines from implementation file DDRInit.c to
the proper specification file DDRInit.h.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c
I moved the #defines from implementation file DDRInit.c to
the proper specification file DDRInit.h.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 15 ---
drivers/staging/bcm/DDRInit.h | 15 +++
2 files changed, 15 insertions
On Tue, 18 Mar 2014, Greg KH wrote:
On Mon, Mar 17, 2014 at 08:21:34PM -0400, Gary Rookard wrote:
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
.
Signed-off-by: Gary Rookard
---
drivers/staging/bcm/CmHost.c | 39 ++-
1 file changed, 10 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index cc82588..632f81a 100644
--- a/drivers/staging/bcm
, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.
Removed temporary bracing from case labels.
Removed new lines as needed.
Properly indented case breaks.
Signed-off-by: Gary Rookard
---
On branch
On Mon, 17 Mar 2014, Greg KH wrote:
On Mon, Mar 17, 2014 at 06:01:24PM -0400, Gary Rookard wrote:
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.
Removed temporary bracing from case labels.
Removed new lines as needed.
Signed-off-by: Gary Rookard
---
On branch staging-next
drivers/staging/bcm
On Mon, 17 Mar 2014, Greg KH wrote:
On Thu, Mar 13, 2014 at 08:58:09PM -0400, Gary Rookard wrote:
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
should be immediately below its function warning fix.
Signed-off-by: Gary Alan Rookard
---
Correct patch, first two breaks
On Mon, 17 Mar 2014, Greg KH wrote:
On Sun, Mar 16, 2014 at 03:59:53PM -0400, Gary Rookard wrote:
I removed some useless extra parenthesis.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On Mon, 17 Mar 2014, Greg KH wrote:
On Sun, Mar 16, 2014 at 01:09:49AM -0400, Gary Rookard wrote:
I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID;
from out of a switch/case statement. And also, removed useless duplicate
UINT uiSearchRuleIndex = 0; and a variant UINT
On Mon, 17 Mar 2014, Greg KH wrote:
On Sun, Mar 16, 2014 at 03:31:18PM -0400, Gary Rookard wrote:
I added a couple of breaks, and a /* FALLTHROUGH */ comment to switch/case
assuming that is the actual desired effect needed by the case label.
Signed-off-by: Gary Alan Rookard
---
On branch
, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions
On Mon, 17 Mar 2014, Mark Einon wrote:
On Sun, Mar 16, 2014 at 10:16:09PM -0400, Gary Rookard wrote:
On Sun, 16 Mar 2014, Gary Rookard wrote:
On Sun, 16 Mar 2014, Mark Einon wrote:
On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
I unline split some quoted strings.
Hi
On Sun, 16 Mar 2014, Gary Rookard wrote:
On Sun, 16 Mar 2014, Mark Einon wrote:
On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
I unline split some quoted strings.
Hi,
Why? What issue does it fix?
--
Hi,
It fixes a checkpatch error/warning "quoted string split a
On Sun, 16 Mar 2014, Mark Einon wrote:
On Sun, Mar 16, 2014 at 02:19:51PM -0400, Gary Rookard wrote:
I unline split some quoted strings.
Hi,
Why? What issue does it fix?
--
Hi,
It fixes a checkpatch error/warning "quoted string split
across lines" or something phrased very s
the construction of. In this scenario the bracing added to the
case lables (witch I also plan to remove) are masking over that very fact,
that it is illegal to put a declaration where only a statement can be put,
so...
Thanks,
-Gary Rookard
On Sun, 16 Mar 2014, Mark Einon wrote:
On Sun, Mar 16
I removed some useless extra parenthesis.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index 9252ef1..41cb3de 100644
I removed some useless extra parenthesis.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index 9252ef1..41cb3de 100644
I added a couple of breaks, and a /* FALLTHROUGH */ comment to switch/case
assuming that is the actual desired effect needed by the case label.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
I unline split some quoted strings.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/CmHost.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm/CmHost.c
index 2d1f94d..4cb59d7
I moved the declarations UINT uiSearchRuleIndex = 0; and ULONG ulSFID;
from out of a switch/case statement. And also, removed useless duplicate
UINT uiSearchRuleIndex = 0; and a variant UINT uiSearchRuleIndex;.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm
On Sat, 15 Mar 2014, Greg KH wrote:
On Sat, Mar 15, 2014 at 02:13:45AM -0400, Gary Rookard wrote:
On Sat, 15 Mar 2014, Greg KH wrote:
On Fri, Mar 14, 2014 at 09:51:30PM -0400, Gary Rookard wrote:
On Sat, 15 Mar 2014, Greg KH wrote:
On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary
On Sat, 15 Mar 2014, Greg KH wrote:
On Fri, Mar 14, 2014 at 09:51:30PM -0400, Gary Rookard wrote:
On Sat, 15 Mar 2014, Greg KH wrote:
On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote:
Hi,
Could this problem be local machine (git-1.9.0-1) or dare I say it,
a tmp server-side
On Sat, 15 Mar 2014, Greg KH wrote:
On Wed, Mar 12, 2014 at 04:10:36PM -0400, Gary Rookard wrote:
Hi,
Could this problem be local machine (git-1.9.0-1) or dare I say it,
a tmp server-side melt-down of sorts?
I've tried everything nothing seams to work.
What have you typed, exactly
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
should be immediately below its function warning fix.
Signed-off-by: Gary Alan Rookard
---
Correct patch, first two breaks build.
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_request.c | 3 +--
1 file changed, 1
I removed the useless parentheses from a return statement for a
warning fix. Return not a function.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
I removed the useless parentheses from a return statement for a
warning fix. Return not a function.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
should be immediately below its function warning fix.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a warning fix.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c
b
Hi,
Could this problem be local machine (git-1.9.0-1) or dare I say it,
a tmp server-side melt-down of sorts?
I've tried everything nothing seams to work.
Thanks for your time,
-Gary Rookard
___
devel mailing list
de...@linuxdriverproject.org
unsplit strings from two lines to one. Changes resulted
in line over 80 characters warning. Leaving the latter
of the two warnings for possible string grepping reasons.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_request.c | 15
fixed up a spacing issue.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c
b/drivers/staging/lustre/lustre/fld/fld_cache.c
unsplit string from two lines to one.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c
b/drivers/staging/lustre/lustre
unsplit strings from two lines to one.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/lustre/lustre/fid/fid_request.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/lustre/lustre/fid/fid_request.c
b
fixed up a couple of indentation issues.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index b4d5e64..f1d7cb8 100644
This coding style error was detected using the checkpatch.pl script
Signed-off-by: Gary Servin
---
drivers/staging/olpc_dcon/olpc_dcon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h
b/drivers/staging/olpc_dcon/olpc_dcon.h
index
I fixed up some operator spacing issues, and other
minor spacing issues.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/rtl8821ae/base.c | 138 +++
1 file changed, 69 insertions(+), 69 deletions(-)
diff --git a/drivers/staging
I fixed up some operator spacing issues.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
I fixed some brace coding style issues.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 107 --
1 file changed, 30 insertions(+), 77 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging
I have deleated some unintelligible comments, and made a
few minor white space corrections.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 149 +-
1 file changed, 74 insertions(+), 75 deletions(-)
diff --git a
removed C99 comments to follow the linux kernel coding style
thus fixing checkpatch errors respectfully.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 271 +-
1 file changed, 136 insertions(+), 135 deletions
removed braces from single statement conditonals.
if, else, while opening brace placement was moved to last
on first line of each, and closing brace moved to first on
new line to follow the linux kernel coding style thus removing
checkpatch errors respectfully.
Signed-off-by: Gary Alan Rookard
replaced C99 style with C89 standard style comments
to follow the linux kernel coding style thus fixing
checkpatch errors respectfully.
also, in some instances changed comments from inline
to side-bar style.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm
Fixed a coding style issue.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 100ddf9..43de518 100644
--- a/drivers
Fixed coding style issues.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 337 +++---
1 file changed, 148 insertions(+), 189 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
Fixed coding style issues.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 53f7191
Fixed coding style issues
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 99 +--
1 file changed, 49 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
Fixed coding style issues
Signed-off-by: Gary Alan Rookard chip_id)
- {
+ switch (Adapter->chip_id) {
case 0xbece3200:
- switch (Adapter->DDRSetting)
- {
+ switch (Adapter->DDRSetting) {
case D
This patchset is an attempt to fix the coding style
issues found in the file DDRInit.c
Gary Rookard (7):
Staging: bcm: DDRinit: fixed indentation coding style issues
Staging: bcm: DDRInit: fixed spacing coding style issues
Staging: bcm: DDRInit: fixed brace coding style issues
Staging
This is the eleventh patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 96afa15..323570f 100644
--- a
This is the third patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 1332 -
1 file changed, 666 insertions(+), 666 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm
This is the tenth patch of a series.
Signed-off-by:Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 231 +-
1 file changed, 116 insertions(+), 115 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DD
This is the fifth patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 270 +-
1 file changed, 135 insertions(+), 135 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm
This is the ninth patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
This is the eighth patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch stanging-next
drivers/staging/bcm/DDRInit.c | 394 +-
1 file changed, 195 insertions(+), 199 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging
This is the seventh patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 163 +++---
1 file changed, 43 insertions(+), 120 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm
This is the sixth patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 174 +++---
1 file changed, 63 insertions(+), 111 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm
This is the fourth patch of a series.
Signed-off-by: Gary Alan Rookard
---
On branch-staging-next
drivers/staging/bcm/DDRInit.c | 86 +--
1 file changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 1332 -
1 file changed, 666 insertions(+), 666 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index e014759..ed4dfe9
This is the first patch of a series.
Signed:off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 398 +-
1 file changed, 199 insertions(+), 199 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm
This is second in a series of patches.
Signed-off-by: Gary Alan Rookard
---
On branch staging-next
drivers/staging/bcm/DDRInit.c | 910 +-
1 file changed, 455 insertions(+), 455 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging
This is the fourth patch of a series.(4)
Replaced spaces in margin w/ 1 tab for lines:
181-185, 187-188
Signed-off-by: Gary Alan Rookard
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging
This is the fifth and final patch for replace spaces w/tab.(5)
Replaced spaces in margin w/ 1 tab for lines:
193-197, 199-200, 202-205, 207, 209-242, 244, 246
Signed-off-by: Gary Alan Rookard
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 96
This is the third patch of a series.(3)
Replaced spaces in margin w/ 1 tab for lines:
121-125, 128-134, 136, 138-171, 173, 175
Signed-off-by: Gary Alan Rookard
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 98 +--
1 file changed, 49
This is the third patch of a series.(3)
Replaced spaces in margin w/ 1 tab for lines:
121-125, 128-134, 136, 138-171, 173, 175
Signed-off-by: Gary Alan Rookard
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 98 +--
1 file changed, 49
This is the third patch of a series.(3)
Replaced spaces in margin w/ 1 tab for lines:
121-125, 128-134, 136, 138-171, 173, 175
Signed-off-by: Gary Alan Rookard
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 98 +--
1 file changed, 49
This is the second patch of a series.(2)
Replaced spaces in margin w/ 1 tab for lines:
69-78, 80-114, 116
Signed-off-by: Gary Alan Rookard
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 92 +--
1 file changed, 46 insertions(+), 46 deletions
This is the first patch of a series.
Replaced spaces in margin w/ 1 tab for lines:
11-15, 17-23, 25-58, 60, 62, 64
On branch staging-next
---
drivers/staging/bcm/DDRInit.c | 98 +--
1 file changed, 49 insertions(+), 49 deletions(-)
diff --git a/drivers/s
71 matches
Mail list logo
