Hello there,
I hope this message finds you in good spirits especially during
this challenging time of coronavirus pandemic. I hope you and
your family are well and keeping safe. Anyway, I am Chris
Pavlides, a broker working with Flippiebecker Wealth. I got your
contact (along with few other
Fix a coding style issue as identified by checkpatch.pl
Signed-off-by: Chris Bloomfield
---
drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/staging/ralink-gdma/ralink-gdma.c
index 655df317d0ee
:52写道：
> > > > >
> > > > > On Wed, Feb 05, 2020 at 01:11:10PM +1300, Chris Packham wrote:
> > > > > > This series re-instates the octeon drivers that were recently
> > > > > > removed and
> > > > > > addresses the
This reverts commit 710d7fbe21ee2ceab121f1f84a20edf68f9f9742.
Re-instate the code so subsequent commits can clean it up and get it
building properly.
Signed-off-by: Chris Packham
---
drivers/staging/Kconfig |2 +
drivers/staging/Makefile |1 +
drivers
This reverts commit 075a1e87d1e2358d0b0301ac8f8e7f25051decf1. Now that
the build issues have been fixed we can resume build testing.
Signed-off-by: Chris Packham
---
drivers/staging/octeon/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/octeon/Kconfig b/drivers
Remove typedef declaration from struct cvmx_wqe and replace its previous
uses with new struct declaration.
Signed-off-by: Chris Packham
---
.../cavium-octeon/executive/cvmx-helper.c | 2 +-
.../include/asm/octeon/cvmx-helper-util.h | 2 +-
arch/mips/include/asm/octeon/cvmx-pko.h
This series re-instates the octeon drivers that were recently removed and
addresses the build issues that lead to that decision.
I've approached Cavium/Marvell about taking a more active interest in getting
the code out of staging and into their proper location. No reply on that (yet).
Remove declaration of union cvmx_helper_link_info as typedef and update
uses to use the union.
Signed-off-by: Chris Packham
---
arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++--
arch/mips/cavium-octeon/executive/cvmx-helper-rgmii.c | 6 +++---
arch/mips/cavium-octeon/executive
Remove the typedef and update usage to use the union.
Signed-off-by: Chris Packham
---
arch/mips/cavium-octeon/executive/cvmx-helper.c | 2 +-
arch/mips/include/asm/octeon/cvmx-pko.h | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/mips/cavium-octeon
On Tue, 2020-02-04 at 07:09 +, gre...@linuxfoundation.org wrote:
> On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote:
> > I'll pipe up on this thread too
> >
> > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote:
> > > On 12/10/1
On Tue, 2020-02-04 at 07:36 +, gre...@linuxfoundation.org wrote:
> On Tue, Feb 04, 2020 at 12:54:26AM +0000, Chris Packham wrote:
> > Hi Greg & All,
> >
> > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 02, 2019 at 09:
I'll pipe up on this thread too
On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote:
> On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote:
> > This driver has been in the tree since 2009 with no real movement to get
> > it out. Now it is starting to cause build issues and other problems for
> > peo
Hi Greg & All,
On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote:
> > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote:
> > > > The code
indicate the disconnection events during
disconnection so the cfg80211_connect can connect to a different
AP without problem.
Signed-off-by: Chris Chiu
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep
rce for
that lying around here somewhere. This is "here there be dragons"
territory. I think the only specification of the format is in the
source code.
-- Chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriv
reproducer do you need here? It's straightforward to
reproduce in casual use, at least with a software synthesizer. I don't
know whether it affects hardware synths.
-- Chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.lin
Improve readability of prism2_add_key:
a) Reduce nesting and removed goto statement by using more return statements.
Signed-off-by: Chris Opperman
---
drivers/staging/wlan-ng/cfg80211.c | 40 +-
1 file changed, 13 insertions(+), 27 deletions(-)
diff --git a
Okay, in that case I will fix and resend the patch.
Kind Regards,
Chris Opperman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Dan,
The header also states "DO NOT EDIT OR MODIFY". As you suggested, I
will rather leave this patch for now.
P.S. Please advise if there is anything specific I can help out with, or I'll
keep looking for more obvious fixes I can make while I'm learning the
ropes.
at be more acceptable?
Kind Regards,
Chris Opperman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Improve readability of prism2_add_key:
a) Reduce nesting and removed goto statement by using more return statements.
b) Added temporary "key" variable to reduce line length.
Signed-off-by: Chris Opperman
---
Improve readability of prism2_add_key:
a) Reduce nesting and removed goto st
Hi Ian/Dan,
In that case I'll stick to the cut-off line format in future. Thanks!
Kind Regards,
Chris Opperman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Ian,
Thank you! Are there any more steps for me to take to complete this
patch process?
Kind Regards,
Chris Opperman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Improve readability of comedi_nsamples_left:
a) Reduce nesting by using more return statements.
b) Declare variables scans_left and samples_left at start of function.
c) Change type of scans_Left to unsigned long long to avoid cast.
Signed-off-by: Chris Opperman
---
Changes v5:
a) Moved
Hi Dan/Ian,
Noted your comments regarding additional text, thanks! Just curious whether
the "scissors" format given at the link below is valid?
https://kernelnewbies.org/PatchTipsAndTricks
It is given as an alternative to placing additional text below the
cut-off line.
Kind Rega
mprove readability of comedi_nsamples_left:
a) Reduce nesting by using more return statements.
b) Declare variables scans_left and samples_left at start of function.
c) Change type of scans_Left to unsigned long long to avoid cast.
Signed-off-by: Chris Opperman
---
drivers/staging/comedi/drivers.
Hi Dan,
Thank you for the feedback, I'll update V4 of the patch accordingly
and resend. I'll soon get a hang of the workflow! :)
Best Regards,
Chris Opperman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverp
Hi Greg,
I've added changelog text to the patch below. Appreciate your
feedback!
Regards,
Chris Opperman
>8--8<
Improved the readability of comedi_nsamples_left:
a) Reduced nesting by using more return calls.
b
Signed-off-by: Chris Opperman
---
drivers/staging/comedi/drivers.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 9d73347..3207ae2 100644
--- a/drivers/staging/comedi
Hi Joe,
Thank you for the feedback! I understand better now and will resend
the patch.
Regards,
Chris Opperman
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Shortened a long line to improve readability in
drivers/staging/comedi/drivers.c
Signed-off-by: Chris Opperman
---
drivers/staging/comedi/drivers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index
Thanks for the feedback! I will retry the submission.
Regards,
Chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch fixes a coding style problem in drivers/staging/comedi/drivers.c
and is submitted for task 10 of the eudyptula challenge.
Signed-off-by: Chris Opperman
---
drivers/staging/comedi/drivers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi
This fixes the following sparse warning:
drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?
Signed-off-by: Chris Coffey
---
Changes in v2:
- Per GregKH's feedback (thanks!), don't add unnecessary new .
Include the local ethtool.h header file in mtk_eth_soc.h so
implementation files have centralized access to it.
This fixes the following sparse warning:
drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?
Signed-off
s.
For this instance, I would go farther and suggest you may want
__GFP_RETRY_MAYFAIL | __GFP_NOWARN to prevent userspace from triggering
the lowmemkiller/oomkiller here.
(I would kill low_order_gfp_flags / high_order_gfp_flags and avoid the
obfuscation.)
-Chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Nov 28, 2017 at 08:26:07AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 27, 2017 at 09:12:39PM +0000, Chris Coffey wrote:
> > This patch fixes build errors that occur when trying to build the
> > MOST modules. For example, the cdev module build fails with:
> >
>
et '_module_drivers/staging' failed
make: *** [_module_drivers/staging] Error 2
Update the Makefile variables and paths with the new directory
structure to fix these errors.
Signed-off-by: Chris Coffey
---
drivers/staging/most/Makefile | 14 +++---
1 file changed, 7 insertions(+),
Replace hard-coded function names in strings with "%s", __func__
in the goldfish_nand.c file. Issue found by checkpatch.pl.
Signed-off-by: Chris Coffey
---
drivers/staging/goldfish/goldfish_nand.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Replace hard-coded function names in strings with '"%s...", __func__' in the
r8190_rtl8256.c file. Issue found by checkpatch.pl.
Signed-off-by: Chris Coffey
---
Patch generated on staging tree, staging-testing branch.
drivers/staging/rtl8192u/r8190_rtl8256.c | 10 +
does not seem to have either a
staging/gpio nor a staging/include/linux/i2c directory to put the
driver's files in.
Please let me know what else I need to read and do, to make this patch
into something that stands a chance of being accepted upstream.
All the best,
Chris.
---
drivers/gp
(+), 44 deletions(-)
Most of these replacements add redundant parentheses around the BIT macro.
IMHO this makes the code less readable.
So I suggest (BIT(c)) -> BIT(c).
Cheers,
Chris
___
devel mailing list
de...@linuxdriverproject.org
h
Samuel Thibault writes:
> This supports spelling unicode characters by just passing them to
> the speech synthesis in direct mode.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
___
devel mailing list
de...@linuxdriverproj
Samuel Thibault writes:
> commit 33590c185299 ("speakup: Support spelling unicode characters")
> mistakenly passed unicode characters to IS_CHAR(), which only
> supports latin1. Let's assume non-latin1 is lower case, like is done
> in spell_word().
void speak_char(u16 ch)
> return;
> }
This is going to misidentify some Unicode characters >= 0x100 as
capital. You probably want to add ch < 0x100 tests to the if(is_char
...) conditions, like you did in spell_word. Please resend with that
fix and you'll get
t; VC. This fixes by just turning the use_unicode parameter to 1.
>
> Signed-off-by: Samuel Thibault
> Tested-by: Zahari Yurukov
Reviewed-by: Chris Brannon
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> situations.
>
> Signed-off-by: Elena Reshetova
> Signed-off-by: Hans Liljestrand
> Signed-off-by: Kees Cook
> Signed-off-by: David Windsor
This looks OK to me.
Acked-by: Chris Leech
> ---
> drivers/scsi/libiscsi.c| 8
> drivers/scsi/qedi/qedi_is
ngs.
> synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are
> however added to put 16bit characters and strings.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Looks good to me.
___
devel m
e Linux only supports 16bit characters,
> we can just hardcode the UTF-8 encoding.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Looks good to me.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject
Walt Feasel writes:
> Make email correction for k...@reisers.ca
>
> Signed-off-by: Walt Feasel
Acked-by: Chris Brannon
> ---
> v2 makes changes to correct for email format patch submission
>
> drivers/staging/speakup/TODO | 2 +-
> 1 file changed, 1 insertion(+)
Walt Feasel writes:
> Modified email address per the TODO file in
> speakup's email listing, also verified email
> address from speakup's website
NAK. The website needs updating, because it has Kirk's old addresses.
k...@reisers.ca is correct.
___
dev
Markus Mayer writes:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
> Acked-by: Samuel Thibault
Acked-by: Chris Brannon
Haven't looked at much kernel code in a while, but this l
result.
--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
checkpatch.pl warns about a bare unsigned. Add type int to make
explicit and suit the coding style.
Signed-off-by Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c
b
checkpatch.pl warns that a cast of 1 to (long long) is unnecessary.
Remove the cast and also add code to check and make sure that
maxdata_list[chan] is not shifted too far, as suggested by Ian
Abbott.
Signed-off-by Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 5 -
1 file
checkpatch.pl warns about a bare unsigned and an unnecessary cast. Patchset
splits fixes for these into two separate patches.
Chris Cesare (2):
staging: comedi: serial2002: Fix bare unsigned styling issue
staging: comedi: serial2002: Fix unnecessary cast styling issue
drivers/staging/comedi
checkpatch.pl reported two warnings: A bare "unsigned" and an
unnecessary cast. Fixed both.
Signed-off-by: Chris Cesare
---
drivers/staging/comedi/drivers/serial2002.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c
er fence_default_wait? You enable
signaling on all, then wait sequentially. The code looks redundant and
could just use fence_default_wait instead.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Mar 23, 2016 at 04:32:59PM +0100, David Herrmann wrote:
> Hi
>
> On Wed, Mar 23, 2016 at 12:56 PM, Chris Wilson
> wrote:
> > On Wed, Mar 23, 2016 at 12:30:42PM +0100, David Herrmann wrote:
> >> My question was rather about why we do this? Semantics for EINTR
eir flush. There are a few other possible deadlocks that are
also avoided with EAGAIN (again, the issue is more or less the lack of
fine grained locking).
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
devel mailing list
d
c11e391da2a8fe973c3c2398452000bed505851e
Author: Daniel Vetter
Date: Thu Feb 11 20:04:51 2016 -0200
dma-buf: Add ioctls to allow userspace to flush
Testcase: igt/gem_concurrent_blit/*dmabuf*interruptible
Testcase: igt/prime_mmap_coherency/ioctl-errors
Signed-off-by: Chris Wilson
Cc: Tiago Vignatti
Cc
Removed unnecessary parentheses.
Signed-off-by: Chris Elliott
---
drivers/staging/rtl8188eu/core/rtw_debug.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c
b/drivers/staging/rtl8188eu/core/rtw_debug.c
index 2c4afb8
e for some time and it can be removed. What is
> happening is libcfs_nid2str is being
> called which requires lnet.ko now. This is a layer violation. I will be
> sending a patch very shortly.
>
Thanks, good to hear.
--chris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Aleksei Fedotov writes:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Aleksey Fedotov
Acked-by: Chris Brannon
Seems fine t
size_t should print using %zu, but here it was use %lu.
we were getting warning while printing.
Signed-off-by: Chris Park
---
drivers/staging/wilc1000/wilc_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c
b/drivers/staging/wilc1000
Minor changes to remove excessive whitespace and improve
readability of ptlrpc functions.
Signed-off-by: Chris Hanna
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 90
drivers/staging/lustre/lustre/ptlrpc/events.c | 60 +++---
drivers/staging/lustre/lustre/ptlrpc
Minor changes to remove excessive whitespace and improve
readability of osc functions.
Signed-off-by: Chris Hanna
---
Sending again due to tree mismatch.
drivers/staging/lustre/lustre/osc/lproc_osc.c | 18 +-
drivers/staging/lustre/lustre/osc/osc_cache.c | 196
Thanks for noticing, I'll re-submit correctly.
Chris
On 6/3/15 1:54 AM, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 11:32:19AM -0400, Chris Hanna wrote:
>> Signed-off-by: Chris Hanna
>>
>> Minor changes to remove excessive whitespace and improve
>>
Signed-off-by: Chris Hanna
Minor changes to remove excessive whitespace and improve
readability of functions.
---
Sending again due to tree mismatch.
drivers/staging/lustre/lustre/osc/lproc_osc.c | 18 +-
drivers/staging/lustre/lustre/osc/osc_cache.c | 196
Minor changes to remove excessive whitespace and improve
readability of functions.
Signed-off-by: Chris Hanna
---
drivers/staging/lustre/lustre/osc/lproc_osc.c | 56 +++---
drivers/staging/lustre/lustre/osc/osc_cache.c | 112 ++--
drivers/staging/lustre/lustre/osc/osc_io.c
much easier
to understand and the resulting function is still viewable within a
single screen.
Signed-off-by: Chris Rorvick
---
As made obvious by the previous version of this patch: compile tested
only.
Regards,
Chris
drivers/staging/emxx_udc/emxx_udc.c | 52
On Fri, Jan 30, 2015 at 5:30 PM, Chris Rorvick wrote:
> +
> + ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE);
> +
Damn. I looked this over twice before sending this and still only
noticed this stupid typo after sending it. Will send a v2 shortly.
S
much easier
to understand and the resulting function is still viewable within a
single screen.
Signed-off-by: Chris Rorvick
---
drivers/staging/emxx_udc/emxx_udc.c | 52 ++---
1 file changed, 14 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/emxx_udc
On Fri, Jan 30, 2015 at 11:35 AM, Rickard Strandqvist
wrote:
> 2015-01-30 15:20 GMT+01:00 Dan Carpenter :
>> Yes. Please send that as a patch which can be applied.
>>
>> regards,
>> dan carpenter
>>
>
>
> Hi
>
> Okay, I'll do it this wee
On Thu, Jan 29, 2015 at 5:46 PM, Chris Rorvick wrote:
> That whole chunk of code looks odd. Why the base 16 conversion when
> we already know it's a decimal digit? Seems like this would work
> without the hassle of the string conversion:
Hmm, or probably even better to do this
On Thu, Jan 29, 2015 at 3:52 PM, Rickard Strandqvist
wrote:
> The last one was more interesting, se below.
> But I can not really see how any error should be handled here?
> Proposal to change to:
>
> if (kstrtol(tempbuf, 16, &num) == 0 && num == 0)
That whole chunk of code looks odd. Why the
On Wed, Jan 28, 2015 at 4:42 PM, Rickard Strandqvist
wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
Each of these changes adds a warning ...
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c
> b/drivers/staging/emxx_
hat it only
applies when units are specified.
Signed-off-by: Chris Rorvick
Reviewed-by: Andreas Dilger
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
b
mult'. Compile tested only.
Chris Rorvick (2):
staging: lustre: Use mult if units not specified
staging: lustre: Track sign separately
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 9 +
1 file changed, 5 insertions(+), 4 del
suffix is specified, but having the effect of taking the
absolute value of the user-provided data.
Signed-off-by: Chris Rorvick
Reviewed-by: Andreas Dilger
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/st
> At Fri, 9 Jan 2015 23:35:46 -0600,
> Chris Rorvick wrote:
>>
>> I have a TonePort UX2 that I've used for testing, meaning that some of
>> this is really only compile-tested.
>
> If anyone is responsible for testing with real hardware, I'll happily
>
The device type can now be used to determine the addresses of the
control endpoints for the interface. Drop the conditional logic and
make these values properties.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 73 +-
drivers/staging
Remove declarations from the header and move the definitions up in the
source so they need not be forward declared.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/pod.c | 58 ++--
drivers/staging/line6/pod.h | 1 -
drivers/staging/line6/podhd.c
Which *_process_message() function (if any) to call when data is
received is known at initialization. Add a function pointer to the
`usb_line6' struct and use to call into the appropriate logic instead
of evaluating the conditional logic for each message.
Signed-off-by: Chris Ro
The device type can now be used to determine the addresses of the
audio endpoints for the interface. Drop the conditional logic and make
these values properties.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/capture.c | 9
drivers/staging/line6/driver.c | 38
Which *_disconnect() to call on disconnect is known at initialization.
Add a function pointer to the `usb_line6' struct and use to call into
the appropriate logic instead of evaluating the conditional logic.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c
Casting the `struct usb_line6' pointer at the call point makes the code
difficult to read. This is substantially cleaned up by moving the cast
into the callees.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 21 ++---
drivers/staging/line6/pod.c
Commit 1027f476f507 (staging: line6: sync with upstream) removed PCM
from the Pocket POD capabilities but left the endpoint configuration.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/pcm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/line6/pcm.c b/drivers
The driver only supports interface 0 of the TonePort UX2 and POD Studio
UX2 devices. Use the device table to filter on this.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/staging
The device type can now be used to determine the altsetting for the
interface. Drop the conditional logic and make this value a property.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 74 +-
drivers/staging/line6/driver.h | 2 ++
2
The driver uses a different altsetting depending on the interface. Add
device type entries for each of these.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 41 -
drivers/staging/line6/driver.h | 3 ++-
drivers/staging/line6/pcm.c
Specify the index of the properties entry explicitly to define this
structure more robustly. Also, drop the `L6PROP' macro in favor of
initializing each member explicitly on its own line since horizontal
space is limited and more attributes will be added later.
Signed-off-by: Chris Ro
The driver only supports interface 1 of the Pocket POD. Use the device
table to filter on this.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/line6/driver.c b/drivers/staging
Define an enum containing the supported devices and associate each entry
in the device table to the respective value.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 54 --
drivers/staging/line6/driver.h | 21
2 files
The PODxt Live device has both a POD and a Variax interface. Add device
type entries for each of these.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 112 -
drivers/staging/line6/driver.h | 8 +--
drivers/staging/line6/pcm.c
Casting the `struct usb_line6' pointer at the call point makes the code
difficult to read. This is substantially cleaned up by moving the cast
into the callees.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 13 -
drivers/staging/line6/pod.c| 3 ++-
dr
Including "BIT" in the macro name is pointless. Replace with "CAP" to
provide some context for what its value represents.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 8
drivers/staging/line6/midi.c | 2 +-
drivers/staging/line6/pcm.c
c and use the device type (via the .driver_info member)
instead.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index 2797e41..c0
These are now only used to build the device table. Each entry in this
table is already clearly documented as to what device it maps to so the
macros become unnecessary indirection.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 56
hat map to specific interfaces on the device so
that this conditional logic can be flattened out.
Signed-off-by: Chris Rorvick
---
drivers/staging/line6/driver.c | 203 ---
drivers/staging/line6/driver.h | 4 +-
drivers/staging/line6/pcm.c | 38 ---
1 - 100 of 128 matches
Mail list logo
