Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread arvindY
On Friday 27 April 2018 06:32 PM, Alex Elder wrote: On 04/27/2018 07:50 AM, Arvind Yadav wrote: On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked through

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

2017-11-30 Thread arvindY
Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++ 1 fil

Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

2017-11-16 Thread arvindY
hi, On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote: On 16/11/17 04:32, Arvind Yadav wrote: pnp_irq() and pnp_port_start() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ 1 file changed, 3 insertio

Re: [PATCH] staging: comedi: dt282x: release irq on dt282x detach

2017-10-06 Thread arvindY
Sorry for noise, ignore this patch. On Friday 06 October 2017 10:06 PM, Arvind Yadav wrote: free_irq() should be called on driver 'dt282x' detach. Signed-off-by: Arvind Yadav --- drivers/staging/comedi/drivers/dt282x.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging