Hi Sasha,
On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote:
> From: "Andrea Parri (Microsoft)"
>
> [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ]
FYI, we found that this commit introduced a regression and posted a
revert:
https:
Currently the discard code in clr_alloc_bitmap() is just dead code.
Move code around so that the discard operation is properly attempted
when enabled.
Signed-off-by: Andrea Righi
---
drivers/staging/exfat/exfat_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a
On Fri, Nov 23, 2018 at 10:51:33AM +0800, Gao Xiang wrote:
> Hi Andrea,
>
> On 2018/11/23 2:50, Andrea Parri wrote:
> > On Thu, Nov 22, 2018 at 06:56:32PM +0800, Gao Xiang wrote:
> >> Hi Greg,
> >>
> >> On 2018/11/22 18:22, Greg Kroah-Hartman wrote:
>
release...
4. It is a good practice to include the above information within an
(inline) comment accompanying the added memory barrier (in fact,
IIRC, checkpatch.pl gives you a "memory barrier without comment"
warning when you omit to do so); not just in the commi
, only compile tested.
Signed-off-by: Andrea della Porta
---
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index e23a0d0..f4d6e48 100644
--- a/drivers/staging/wlan-ng
/llite//file.c:1357:23:expected
unsigned long long [unsigned] [usertype] flags
drivers/staging/lustre/lustre/llite//file.c:1357:23:got restricted
fmode_t [usertype]
Signed-off-by: Andrea della Porta
---
drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
1 file changed, 1
fixed a couple of sparse warning complaining about type mismatch.
Signed-off-by: Andrea della Porta
---
drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_intent.h
b/drivers
Fixed checkpatch warning about line over 80 chars
Signed-off-by: Andrea della Porta
---
Changes in v3:
- rebased on staging-testing
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services
Fixed unaligned function parameters issues, as per checkpatch warning
Signed-off-by: Andrea della Porta
---
Changes in v3:
- rebased on staging-testing
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 43 ++
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git
Andrea della Porta (2):
staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed checkpatch
warning about unaligned function params
staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed codepatch
coding style issue, line over 80
.../vc04_services/bcm2835-audio/bcm2835-pcm.c
Removed an extra spaces at the end of the line
Signed-off-by: Andrea della Porta
---
Changes in v2:
- subject line more explicit
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835
Fixed checkpatch warning about line over 80 chars
Signed-off-by: Andrea della Porta
---
Changes in v2:
- subject line more explicit
- chekpatch output removed as requested, summarized in one line
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 ++-
1 file changed, 2 insertions
Fixed unaligned function parameters issues, as per checkpatch warning
Signed-off-by: Andrea della Porta
---
Changes in v2:
- subject line more explicit
- checkpatch output removed as requested, summarized in one line
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47
Andrea della Porta (3):
staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed checkpatch
warning about unaligned function params
staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed codepatch
coding style issue, line over 80
staging: vc04_services: bcm2835-audio: bcm2835
staging: sm750fb: ddk750_display.c - fixed the following checkpatch warning:
WARNING: line over 80 characters
#149: FILE: drivers/staging/sm750fb/ddk750_display.c:149:
+ swPanelPowerSequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
4);
Signed-off-by: Andrea d
staging: comedi: drivers: s626.c - fixed the following checkpatch issue:
CHECK: Prefer kernel type 's16' over 'int16_t'
#1939: FILE: drivers/staging/comedi/drivers/s626.c:1939:
+ int16_t dacdata = (int16_t)data[i];
Signed-off-by: Andrea della Porta
---
dr
staging: rts5208: ms.c Fixed checkpatch warning:
WARNING: Prefer using "%s", __func__ to embedded function names
#2597: FILE: rts5208/ms.c:2597:
+ dev_dbg(rtsx_dev(chip), "ms_build_l2p_tbl: %d\n", seg_no);
Signed-off-by: Andrea della Porta
---
drivers/staging/rts5208
Fixed the followinf checkpatch warning:
WARNING: braces {} are not necessary for single statement blocks
#258: FILE: drivers/staging/iio/accel/adis16209.c:258:
+ if (ret) {
+ return ret;
+ }
Signed-off-by: Andrea della Porta
---
drivers/staging
Removed an extra spaces at the end of the line
Signed-off-by: Andrea della Porta
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
b/drivers/staging
Fixed issue:
WARNING: line over 80 characters
#545: FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:545:
+ snd_bcm2835_playback_spdif_hw.buffer_bytes_max,
snd_bcm2835_playback_spdif_hw.buffer_bytes_max);
Signed-off-by: Andrea della Porta
---
drivers/staging
vers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:544:
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_CONTINUOUS,
+ snd_dma_continuous_data(GFP_KERNEL),
Signed-off-by: Andrea della Porta
---
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47 ++--
Fixed several chekpatch warnign about alignment of function parameters,
removed spaces after a cast, split one line that was over 80 chars
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 48 +++---
1 file changed, 23 insertions(+), 25 deletions(-)
___
Fixed several chekpatch warnign about alignment of function parameters,
removed spaces after a cast, split one line that was over 80 chars
Signed-off-by: Andrea della Porta
---
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47 ++
1 file changed, 22 insertions(+), 25
From: Andrea della Porta
Subject: staging: xgifb: added blankline after decl.
Fixed checkpatch warning:
WARNING: Missing a blank line after declarations
#882: FILE: drivers/staging/xgifb/XGI_main_26.c:882:
+ const u8 *f =
XGI_TV_filter[filter_tb].filter[filter
Coding style issues fixed
Signed-off-by: Andrea della Porta
---
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47 ++
1 file changed, 22 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
b/drivers/staging
Coding style issue resolved.
Signed-off-by: Andrea della Porta
---
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16209.c
b/drivers/staging/iio/accel/adis16209.c
index 52fa2e0..159a687 100644
--- a
Thank you for your time
regard,
andrea
On Wed, Mar 8, 2017 at 7:22 AM, Dan Carpenter wrote:
> I think this change is buggy.
>
> On Tue, Mar 07, 2017 at 10:36:53PM +0100, Andrea Ghittino wrote:
>> Fixed sparse warnings related to the conversion of le16 and le32 to u16 and
>
On Tue, Mar 07, 2017 at 11:17:36PM +0300, Dan Carpenter wrote:
> On Sat, Mar 04, 2017 at 06:20:50PM +0100, Andrea Ghittino wrote:
> > Sparse generates two warnings related to incorrect type in assignment.
> > This patch changes the types in the struct defined in unisys
>
> Ca
//wilc_wfi_cfgoperations.c:2084:51:expected
unsigned int [unsigned] [assigned] [usertype] ht_tx_bf_cap
drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2084:51:got restricted
__le32 const [usertype] tx_BF_cap_info
Signed-off-by: Andrea Ghittino
---
changelog:
v2) Changed patch
/wilc1000//wilc_wfi_cfgoperations.c:2084:51:got restricted
__le32 const [usertype] tx_BF_cap_info
Signed-off-by: Andrea Ghittino
---
Compile tested only
wilc_wfi_cfgoperations.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000
Sparse generates two warnings related to incorrect type in assignment.
This patch changes the types in the struct defined in unisys
Signed-off-by: Andrea Ghittino
---
Compile tested only
iochannel.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Fixes greybus "line over 80 characters" style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
changelog:
v2) Review patch based on Vaibhav Hiremath review
v3) Fixed email text
v4) Review the patch based on received comments
drivers/staging/greybus/arche-apb-ctr
On Wed, Nov 30, 2016 at 12:21 AM, Dan Carpenter
wrote:
> On Tue, Nov 29, 2016 at 03:59:46PM -0600, Alex Elder wrote:
>> On 11/26/2016 03:50 PM, Andrea Ghittino wrote:
>> > Fixes greybus user/groups permission style warnings
>> > found by checkpatch.pl tool
>> >
Fixes sm750fb tabstop style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
changelog:
v2) Fixed email subject
v3) Fixed email format
drivers/staging/sm750fb/sm750_accel.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb
Fixes greybus "line over 80 characters" style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
changelog:
v2) Review patch based on Vaibhav Hiremath review
v3) Fixed email text
drivers/staging/greybus/arche-apb-ctrl.c |5 +++
drivers/staging/greybus/arche-
Fixes sm750fb tabstop style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging/sm750fb/sm750_accel.c
index 6fd18d2..af0db57 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb
Fixes greybus "line over 80 characters" style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers/staging/greybus/arche-apb-ctrl.c
index 3fda0cd..755120a 100644
--- a/drivers/staging/greybus/arche-
Fixes sm750fb function definition argument style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/ddk750_chip.h
b/drivers/staging/sm750fb/ddk750_chip.h
index e97e859..30653dd 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b
On Mon, Nov 28, 2016 at 12:48 AM, Randy Dunlap wrote:
> On 11/27/16 13:11, Andrea Ghittino wrote:
>> Fixes sm750fb function definition argument style warning
>> found by checkpatch.pl tool
>>
>> Signed-off-by: Andrea Ghittino
>> ---
>
> Does checkpatch no
Fixes greybus "line over 80 characters" style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers/staging/greybus/arche-apb-ctrl.c
index 3fda0cd..755120a 100644
--- a/drivers/staging/greybus/arche-
Fixes greybus "line over 80 characters" style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers/staging/greybus/arche-apb-ctrl.c
index 3fda0cd..755120a 100644
--- a/drivers/staging/greybus/arche-
On Mon, Nov 28, 2016 at 10:14:03AM +0530, Vaibhav Hiremath wrote:
> On Sun, Nov 27, 2016 at 3:43 AM, Andrea Ghittino wrote:
> > Fixes greybus "line over 80 characters" style warnings
> > found by checkpatch.pl tool
> >
>
> It is always trade-off between re
Fixes sm750fb function definition argument style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/ddk750_chip.h
b/drivers/staging/sm750fb/ddk750_chip.h
index e97e859..30653dd 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b
Fixes sm750fb tabstop style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging/sm750fb/sm750_accel.c
index 6fd18d2..af0db57 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb
Fixes sm750fb function definition argument style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/ddk750_chip.h
b/drivers/staging/sm750fb/ddk750_chip.h
index e97e859..30653dd 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b
Fixes sm750fb user/groups permission style warning
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 2d22c51..2d33b80 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750
Fixes greybus "line over 80 characters" style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c
b/drivers/staging/greybus/arche-apb-ctrl.c
index 3fda0cd..755120a 100644
--- a/drivers/staging/greybus/arche-
Fixes greybus user/groups permission style warnings
found by checkpatch.pl tool
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 1c5b41a..4424f63 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus
This patch fix two code style warnings related to "line over 80 characters" in
drivers/staging/octeon-usb/octeon-hcd.c file.
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 9a7858a..92f3a7e 10
This patch fix two code style warnings related to "line over 80 characters" in
drivers/staging/octeon-usb/octeon-hcd.c file.
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 9a7858a..92f3a7e 10
This patch fix two code style warnings related to "line over 80 characters" in
drivers/staging/octeon-usb/octeon-hcd.c file.
index 9a7858a..92f3a7e 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2636,12 +2636,12 @@ static int cvmx_usb_poll_c
This patch fix code style warnings for octeon-usb driver
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 9a7858a..92f3a7e 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb
Dear,
I'm Dr. Andrea Thompson, I'm seeking for investment opportunities around the
globe and wonder if you can be of assistance.
Basically, all I need from you is sincerity, authenticity, integrity
protection, virtue, accountability and honor which brings trust in business. As
y
pdate.
Andrea
On Wed, Apr 9, 2014 at 7:08 PM, Greg KH wrote:
> On Wed, Apr 09, 2014 at 10:10:49AM +0200, Xose Vazquez Perez wrote:
>> hi,
>>
>> Support for RTL8187SE devices(0x8199) was added to
>> rtl8180 recently. See 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
>
> Very
Dear Webmail User,
You are receiving this e-mail because your inbox capacity is currently inactive
in our database.
Your incoming mails were placed on pending status due to the recent upgrade in
our database.
Your incoming mails has been migrated to the Exchange server with Error code:
EXCH2K10
asked something about.
> regards,
> dan carpenter
Thank you a lot for your review!
Andrea
>> +#include "rtl8225se.h"
>> +
>
> Don't include this twice. Only put one blank line, not two consecutive
> blank lines.
OK
> This comment is out of date. RTL
>
> Somehow I missed this patch. Do you know if John Linville picked it up?
>
AFAIK no..
> I'm not sure if the ANAPARAM3 register could handle a 16-bit write on an
> RTL8187B. To be cautious, I wrote and have tested the attached patch using a
> union. The patch includes a fix for an undefined sym
..
Thank you
Andrea
On Tue, Feb 4, 2014 at 6:57 PM, Larry Finger wrote:
> Andrea,
>
> After applying the latest patch, I get the following warning and errors when
> building the USB driver rtl8187:
>
> CC drivers/video/fbmon.o
> drivers/net/wireless/
58 matches
Mail list logo