Re: [bug report] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.

2018-01-23 Thread Zhen, Liang
Hi, I just realized the “free_conn” parameter is unused in kernel source, but it’s actually used in the original patch: https://review.whamcloud.com/#/c/17892 , so I think it should be fixed in the kernel. Regards Liang On 23/01/2018, 4:02 PM, "Zhen, Liang" wrote: Hi there

Re: [bug report] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.

2018-01-23 Thread Zhen, Liang
Hi there, probably the function name is misleading, but L3317: kiblnd_destroy_conn(conn, !peer); This function will NOT free the connection if peer is NULL, and… L3320:if (!peer) L3321 continue; It means the connection is not freed in L3322 and later. Regards Liang On 23

Re: [HPDD-discuss] [PATCH 15/16] staging: lustre: lnet: lnet: fix error return code

2015-04-05 Thread Zhen, Liang
Julia, yes this is a bug that we have already fixed in the latest Lustre. Sorry we haven¹t submitted this patch to kernel on time. Thanks Liang On 4/5/15, 8:06 PM, "Julia Lawall" wrote: >Return a negative error code on failure. > >A simplified version of the semantic match that finds this probl

Re: [bug report] forever loop in ksocknal_push()

2014-04-28 Thread Zhen, Liang
Yes, it is indeed a deadloop, I think we didn¹t catch it because it¹s only called by an utility command which is probably never tried by anyone. I have posted a patch for it: http://review.whamcloud.com/10128 Thanks Liang On 4/28/14, 2:38 AM, "Drokin, Oleg" wrote: >Thanks! > >Liang, any comme