[PATCH v3 0/3] staging: iio_simple_dummy: minor driver fixes

* Fixed the label name to address label location * Changed the type of functions, which always return 0 to void Vladimirs Ambrosovs (3): staging: iio_simple_dummy: fix init function staging: iio_simple_dummy: fix return types staging: iio_simple_dummy: fix module_param type

[PATCH v3 2/3] staging: iio_simple_dummy: fix return types

The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and iio_dummy_evgen_release_irq() were changed to return void instead of int. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_dummy_evgen.c | 4 +--- drivers/staging/iio/iio_dummy_evgen.h | 2

[PATCH v3 3/3] staging: iio_simple_dummy: fix module_param type

Fix the module_param "instances" type to uint, since the variable type holding the value is unsigned. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/iio_simple_

[PATCH v3 1/3] staging: iio_simple_dummy: fix init function

This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and no devices being removed in case the probe function fails, running in a loop. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 9

Re: [PATCH v2 2/3] staging: iio_simple_dummy: fix return types

On Sat, May 30, 2015 at 12:24:42PM +0530, Sudip Mukherjee wrote: > On Sat, May 30, 2015 at 12:45:22AM +0300, Vladimirs Ambrosovs wrote: > > The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and > > iio_dummy_evgen_release_irq() were changed to return void

[PATCH v2 3/3] staging: iio_simple_dummy: fix module_param type

Fix the module_param "instances" type to uint, since the variable type holding the value is unsigned. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/iio_simple_

[PATCH v2 2/3] staging: iio_simple_dummy: fix return types

The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and iio_dummy_evgen_release_irq() were changed to return void instead of int, because these functions always return 0. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_dummy_evgen.c | 4 +--- drivers

[PATCH v2 0/3] staging: iio_simple_dummy: minor driver fixes

v2 Fixed the code as per the comments from version 1: * Removed unnecessary comments * Fixed the label name to address label location * Changed the type of functions, which always return 0 to void Vladimirs Ambrosovs (3): staging: iio_simple_dummy: fix init function

[PATCH v2 1/3] staging: iio_simple_dummy: fix init function

This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and no devices being removed in case the probe function fails, running in a loop. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 9

Re: [PATCH 2/2] staging: iio_simple_dummy: zero check param

On Thu, May 28, 2015 at 09:59:34AM +0300, Dan Carpenter wrote: > On Thu, May 28, 2015 at 01:12:40AM +0300, Vladimirs Ambrosovs wrote: > > On Wed, May 27, 2015 at 11:25:07AM +0300, Dan Carpenter wrote: > > > On Wed, May 27, 2015 at 01:19:58AM +0300, Vladimirs Ambrosovs wrote: >

Re: [PATCH 2/2] staging: iio_simple_dummy: zero check param

On Wed, May 27, 2015 at 11:25:07AM +0300, Dan Carpenter wrote: > On Wed, May 27, 2015 at 01:19:58AM +0300, Vladimirs Ambrosovs wrote: > > Check for zero was added to the module parameter "instances" to > > avoid the allocation of array of zero values. Although it is a vali

Re: [PATCH 1/2] staging: iio_simple_dummy: fix init

On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote: > Hi, > > On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs > wrote: > > This patch fixes the init function for the iio_simple_dummy driver. > > The main issues were absence of kfree for the allocated a

[PATCH 2/2] staging: iio_simple_dummy: zero check param

also changed to unsigned int so that no compiler complaints occur. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_sim

[PATCH 1/2] staging: iio_simple_dummy: fix init

becomes useless as well, hence return value type change. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio

[PATCH v2] staging: fwserial: fix resource leak

allocation failure, and free debugfs entries. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/fwserial/fwserial.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index fdb2418..b3ea4bb 100644

Re: [PATCH 1/1] staging: fwserial: fix resource leak

On Mon, May 25, 2015 at 12:27:22PM +0300, Dan Carpenter wrote: > On Mon, May 25, 2015 at 02:14:32AM +0300, Vladimirs Ambrosovs wrote: > > From: Vladimirs Ambrosovs > > > > No need for this, we get it from your email address. > > > This patch fixes the leak, which

[PATCH 1/1] staging: fwserial: fix resource leak

From: Vladimirs Ambrosovs This patch fixes the leak, which was present in fwserial driver in the init function. in case the tty driver allocation failed the function returned error, leaving debugfs entry in the filesystem. To fix the issue additional error label was added, so that the code will

[PATCH 1/1] staging: fwserial: fix resource leak

From: Vladimirs Ambrosovs This patch fixes the leak, which was present in fwserial driver in the init function. in case the tty driver allocation failed the function returned error, leaving debugfs entry in the filesystem. To fix the issue additional error label was added, so that the code will