Move logical operator to previous line to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging
Swap the terms of comparisons whenever the constant comes first to get
rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
Remove unnecessary parentheses after 'address-of' operator to get rid of
checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8
Remove braces from single if statement to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Replace NULL comparisons in the file to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b
To avoid style issues, remove multiple blank lines.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index
it had some compilatin error.
Vatsala Narang (6):
staging: rtl8723bs: core: Remove blank line.
staging: rtl8723bs: core: Replace NULL comparisons.
staging: rtl8723bs: core: Remove unnecessary parentheses.
staging: rtl8723bs: core: Remove braces from single if statement.
staging
Swap the terms of comparisons whenever the constant comes first to get
rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
Remove braces from single if statement to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Moved logical operator to previous line to get rid of checkpatch
warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging
Remove unnecessary parentheses after 'address-of' operator to get rid of
checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8
This series fix the following warnings:
-Remove multiple blank lines.
-Remove return in void function.
-Replace NULL comparison.
-Remove unnecessary parentheses.
-Remove braces from single if statement.
-Fix variable constant comparison.
-Move logical operator to previous line.
Vatsala Narang (7
Replace NULL comparisons in the file to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b
Remove return in void function to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core
To avoid style issues, remove multiple blank lines.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index
Replace bit shifting on 1 with the BIT(x) macro.
Issue found using coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Avoid NULL comparison, compare using boolean operator.
Issue found using coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_io.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
This patch updates Kconfig with paragraph that describe config symbol
fully.Issue addressed by checkpatch.
Signed-off-by: Vatsala Narang
---
drivers/staging/iio/adc/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
Return value directly without saving it in a variable and remove that
variable.
Issue suggested by Coccinelle.
Signed-off-by: Vatsala Narang
---
Changes in v2:
-Change subject line and log message
-Remove respective unused variable
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
Modify return statement and remove the respective assignment.
Issue found by coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835
To avoid style issues, remove multiple blank lines.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index
Remove else after return statement as it is not useful. Issue found
using checkpatch.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Remove else after return statement as it is not useful. Issue found
using checkpatch.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers
Modify return statement and remove the respective assignment.
Issue found by Coccinelle.
Signed-off-by: Vatsala Narang
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835
Replace explicitely with explicitly to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
Changes in v2:
-added this patch to patchset to fix spelling mistake.
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Change suggested by coccinelle.
Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:
@@
expression c;
@@
-(1 << c)
+BIT(c)
Signed-off-by: Vatsala Narang
---
Changes in v2:
-changed log message
-added space around '&' opreator and after 'if'
-added
Remove return in void function to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index
Challenge suggested by coccinelle.
Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:
@@
expression c;
@@
-(1 << c)
+BIT(c)
Signed-off-by: Vatsala Narang
---
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
28 matches
Mail list logo